palokisa added a comment.
What's happening here? :)
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D5556
To: palokisa, graesslin, cfeck, apol
Cc: bcooksley, #frameworks
palokisa added a comment.
In https://phabricator.kde.org/D5556#104466, @apol wrote:
> Yes, do you have commit/push access? Otherwise we'll push it ourselves.
As I don't know, what are you talking about... probably not
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabr
palokisa added a comment.
Sorry, I'm not familiar with the phabricator process... should I take some
action now?
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D5556
To: palokisa, graesslin, cfeck, apol
Cc: #frameworks
palokisa created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
..as it's not used anywhere (and the KService isn't some kind of
"selfinitializing" library, that only needs to be linked to).
REPOSITORY
palokisa added a comment.
In https://phabricator.kde.org/D5521#103810, @graesslin wrote:
> The other dependencies: well KCoreAddons is needed for KCrash only IIRC.
That is setting the KAboutData.
I've had a look... and the plugins are also handled by there are more of
them: `KPlu
palokisa added a comment.
In https://phabricator.kde.org/D5521#103775, @cfeck wrote:
> Btw, libKF5GlobalAccel is actually Tier1, so applications needing global
shortcuts will not have any (additional) KF5 dependencies, only the runtime has.
But without the runtime the application
palokisa added a comment.
What is `KF5::Service` used for? You don't seem to be `#ifdef` it. Maybe
it's not needed at all?
>>>
>>> I don't know. I didn't investigate that.I thought, it's some kind of
"self-initializing" component and it is enough to link the library.
>>
>>
palokisa added a comment.
> The obvious reason is that it would be impossible to install frameworks and
lxqt at the same time.
Why? With the aforementioned package names example: frameworks will provide
`foo` by `foo-kde` and `foo-lxqt`. LXQt will require `foo` and KDE will
(strictly)
palokisa added a comment.
> Distributions will ship only one variant of kglobalaccel and that will most
likely be the one which is wanted by KDE
Why is that? Why can't we have e.g. one `foo-kde` and other `foo-lxqt`
package, both providing virtual `foo` (these will be in conflict as they
palokisa added a comment.
In https://phabricator.kde.org/D5521#103536, @apol wrote:
> In https://phabricator.kde.org/D5521#103535, @palokisa wrote:
>
> > > Make them optional dependencies.
> >
> > What do you mean by this?
>
>
>
>
> find_package(KF5Crash) #note there's
palokisa added a comment.
> Make them optional dependencies.
What do you mean by this?
> What is `KF5::Service` used for? You don't seem to be `#ifdef` it. Maybe
it's not needed at all?
I don't know. I didn't investigate that.I thought, it's some kind of
"self-initializing"
palokisa created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
By using the MINIMAL_RUNTIME_DEPS we allow minimizing the run-time
dependencies -> remove the KCrash & KService dependency/usage.
Wit
12 matches
Mail list logo
