Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

tps://git.reviewboard.kde.org/r/128397/#comment65647> Ideally, one would want that even if compiled with older Qt, this works as Qt is upgraded. The way to do that would be to hardcode the numerical value of QIconEngine::IsNullHook when compiling with older Qt. - Olivier Goffart On July 7, 2016, 9:

Re: Review Request 127926: KNotifyConfigWidget: add disableAllSounds() method

is no quick way to enable them all again as it was before. - Olivier Goffart On May 15, 2016, 10:53 a.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126568: [KNotifyConfigWidget] Allow selecting a specific event

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126568/#review90327 --- Ship it! Ship It! - Olivier Goffart On Dez. 29, 2015, 10

Re: [Development] setting default widgetStyle (and ColorScheme)

On Friday 27. November 2015 23:39:07 René J.V. Bertin wrote: > Digging through Qt's source code to figure out if and how I can get KF5 > applications to honour theming settings on OS X, I observe the following in > class QKdeThemePrivate in qgenericunixthemes.cpp: > > static QString kdeGlobals

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

marked as submitted. Review request for Dolphin and KDE Frameworks. Changes --- Submitted with commit 42f0d05e8b98c22783c9dbd0426a527a02cb8ef6 by Olivier Goffart to branch master. Repository: kio Description --- The interface from https://git.reviewboard.kde.org/r/125136/ moved

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

/ - Olivier Goffart On Okt. 17, 2015, 3:06 nachm., Olivier Goffart wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

: https://git.reviewboard.kde.org/r/125436/diff/ Testing --- Thanks, Olivier Goffart ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

ivier --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/#review86063 --- On Sept. 28, 2015, 9:14 vorm., Olivier Goffart wrote: >

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

tps://git.reviewboard.kde.org/r/125436/#comment59381> Do you have any example of plugins using this new way so that i can get inspiration from it? - Olivier Goffart On Sept. 28, 2015, 9:14 vorm., Olivier Goffart wrote: > > ---

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

? - Olivier Goffart On Sept. 28, 2015, 9:14 vorm., Olivier Goffart wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

src/widgets/koverlayiconplugin.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/125436/diff/ Testing --- Thanks, Olivier Goffart ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

Diff: https://git.reviewboard.kde.org/r/125436/diff/ Testing --- Thanks, Olivier Goffart ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: QIcon::fromTheme(xxx, someFallback)

On Tuesday 8. September 2015 10:26:20 David Faure wrote: > On Monday 07 September 2015 15:53:31 Olivier Goffart wrote: > > But the problem is that QIcon::isNull is likely to be called anyway. > > And this will again do all the look ups in the file system. > > I don't

Re: QIcon::fromTheme(xxx, someFallback)

On Sunday 23. August 2015 12:01:38 David Faure wrote: > On Sunday 23 August 2015 10:30:13 Olivier Goffart wrote: > > On Friday 21. August 2015 22:30:37 David Faure wrote: > > > > I would also approve a change to Qt to add an overload of > > > > QIcon::fromThe

Re: QIcon::fromTheme(xxx, someFallback)

On Friday 21. August 2015 22:30:37 David Faure wrote: > > I would also approve a change to Qt to add an overload of QIcon::fromTheme > > with only one argument without a fallback. (this would be binary > > compatible, and source compatible unless someone took the address of > > QIcon::fromTheme)

Re: QIcon::fromTheme(xxx, someFallback)

On Friday 21. August 2015 10:05:09 David Faure wrote: > Hi Olivier, > > I've been trying to fix performance problems with QIcon::fromTheme("foo") > when using KIconEngine, and I'm hitting a wall due to the QIcon API - more > precisely, that fallback argument. > > KMail (and all similar large apps

Re: Review Request 122608: Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback

BUG: 342906 Diffs - src/kiconengine.cpp 530403e Diff: https://git.reviewboard.kde.org/r/122608/diff/ Testing --- Thanks, Olivier Goffart ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 122608: Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback

Diff: https://git.reviewboard.kde.org/r/122608/diff/ Testing --- Thanks, Olivier Goffart ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel