Re: OCS Providers File - High Numbers of Requests

2021-09-23 Thread Nicolás Alvarez
El jue, 23 de sep. de 2021 a la(s) 19:31, Aleix Pol (aleix...@kde.org) escribió: > > On Thu, Sep 23, 2021 at 10:12 PM Nicolás Alvarez > wrote: > > > > El jue, 23 de sep. de 2021 a la(s) 08:55, Aleix Pol (aleix...@kde.org) > > escribió: > > > > > >

Re: OCS Providers File - High Numbers of Requests

2021-09-23 Thread Nicolás Alvarez
El jue, 23 de sep. de 2021 a la(s) 08:55, Aleix Pol (aleix...@kde.org) escribió: > > On Thu, Sep 23, 2021 at 11:52 AM Ben Cooksley wrote: > > > > Hi all, > > > > It has recently come to our attention that the number of queries being > > handled for the endpoint https://autoconfig.kde.org/ocs/prov

Re: Requiring Qt 5.15 for KDE Frameworks 5?

2021-03-27 Thread Nicolás Alvarez
> El 27 mar. 2021, a la(s) 12:30, Fabian Vogt escribió: > Moin, > > Am Samstag, 27. M?rz 2021, 14:11:38 CET schrieb David Faure: > On samedi 27 mars 2021 12:51:37 CET Kai Uwe Broulik wrote: Hi everyone, during the ongoing KDE Frameworks 6 sprint we were just contemplating wh

Re: Information regarding upcoming Gitlab Migration

2020-05-01 Thread Nicolás Alvarez
> On 1 May 2020, at 15:17, Alexander Potashev wrote: > > On Tue, Apr 28, 2020 at 6:47 AM Bhushan Shah wrote: >> Use case 4 : Tom is a student in Germany and is interested in >> contributing to wikitolearn, and he asks where can I find code of the >> wikitolearn? > > Hi, > > I have a similar

Re: Information regarding upcoming Gitlab Migration: clarifications

2020-04-30 Thread Nicolás Alvarez
El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid (aa...@kde.org) escribió: > > El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va escriure: > > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić wrote: > > > > > > > We have made a big fuss in the past about having different pro

Re: Update on Status of Gitlab Migration

2020-04-11 Thread Nicolás Alvarez
El sáb., 11 de abr. de 2020 a la(s) 16:26, Johan Ouwerkerk (jm.ouwerk...@gmail.com) escribió: > > On Sat, Apr 11, 2020 at 8:39 PM Ben Cooksley wrote: > > > > Yes, the hostname git.kde.org will be fully retired as part of this > > transition. > > > > From my understanding kdesrc-build will automat

Re: Update on Status of Gitlab Migration

2020-04-11 Thread Nicolás Alvarez
El 11 abr. 2020, a la(s) 08:31, Johan Ouwerkerk escribió: > > On Sat, Apr 11, 2020 at 11:36 AM Ben Cooksley wrote: >> Should anyone have any questions on the above, please let us know. > > Does the migration also mean that `git.kde.org` push URL will be > retired and would need to be remapped

Re: Banning QNetworkAccessManager

2020-02-20 Thread Nicolás Alvarez
El jue., 20 de feb. de 2020 a la(s) 10:30, Allen Winter (win...@kde.org) escribió: > > On Wednesday, February 19, 2020 6:09:02 PM EST Albert Astals Cid wrote: > > El dimecres, 19 de febrer de 2020, a les 9:28:22 CET, Volker Krause va > > escriure: > > > Additionally, improved documentation, a poss

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

2017-07-17 Thread Nicolás Alvarez
nalvarez added a comment. Looks reasonable – although I wonder why on earth you're building KDE stuff on Cygwin... REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6762 To: winterz, skelly, #build_system, #windows Cc: nalvarez, #frameworks, #build_system

D5788: Add syntax highlighting for YANG data modeling language

2017-06-17 Thread Nicolás Alvarez
nalvarez added a comment. I knew the text of RFCs was under a somewhat-restrictive license. I didn't know code snippets were explicitly excluded and BSD'd instead. We can work with that then :) REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.

D5788: Add syntax highlighting for YANG data modeling language

2017-06-17 Thread Nicolás Alvarez
nalvarez added a comment. Sorry, I don't know enough about the language to provide a meaningful test. I made these highlighting rules on request by @jkt, partly translating the .vim file and partly reading the RFC, without even understanding what the language is for. I was hoping he could pr

D5788: Add syntax highlighting for YANG data modeling language

2017-05-09 Thread Nicolás Alvarez
nalvarez created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Add syntax highlighting for YANG data modeling language, based on yang.vim .

D5656: Adds method to force the reloading of a document

2017-05-01 Thread Nicolás Alvarez
nalvarez added a comment. I'm pretty sure this breaks ABI by adding a new virtual function... If an application was compiled against a previous version of KTextEditor and calls `documentSave()`, when run with a newer KTextEditor version (with this patch) it may end up calling the new `docume

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Nicolás Alvarez
nalvarez added a comment. Are you saying the d-bus service name should be equal to the .desktop filename? I don't see where this requirement comes from. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D5405 To: stikonas, mpyne, kossebau, aacid, ltoscano Cc: nalva

D4234: Change algorithm for autobrace.

2017-03-19 Thread Nicolás Alvarez
nalvarez added a comment. Writing tests for this might not be easy, so even having passing tests for the current behavior would be very useful, as a first step. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4234 To: cactus, #ktexteditor, mwolff Cc: nalvarez, mw

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

2017-02-25 Thread Nicolás Alvarez
nalvarez added a comment. This might be better solved by a krazy-like check, instead of making the compilation fail... REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

Re: CI trouble

2017-02-04 Thread Nicolás Alvarez
2017-02-04 16:19 GMT-03:00 David Faure : > Today the CI seems capricious ;) > > - build.kde.org was down for a bit Yep, Jenkins ran out of memory in the JVM. Restarted a while ago. > - DNS problems in > https://build.kde.org/view/Frameworks%20kf5-qt5/job/kparts%20master%20kf5-qt5/409/console Bl

Re: Phabricator: All repositories registered - upcoming workflow changes

2017-02-02 Thread Nicolás Alvarez
2017-02-02 7:23 GMT-03:00 René J.V. Bertin : > On Thursday February 2 2017 22:09:34 Ben Cooksley wrote: > >>For those who dismiss decay as an issue - problems with previous >>Reviewboard upgrades not taking cleanly have resulted in some reviews >>being damaged, causing their diffs to become unavail

Re: kconfig_compiler (Re: KDE Frameworks 5.29.0)

2016-12-10 Thread Nicolás Alvarez
> El 10 dic 2016, a las 17:10, David Faure escribió: > >> On samedi 10 décembre 2016 19:49:07 CET Martin Graesslin wrote: >> So from my point of view breaking the incorrect behavior could be acceptable >> here. > > Yes, but after the next kdevplatform release, then, to avoid breaking > compila

[Differential] [Changed Subscribers] D3636: [kconfig_compiler] Improve documentation about Inherits

2016-12-10 Thread Nicolás Alvarez
nalvarez added inline comments. INLINE COMMENTS > README.dox:111 >Class the generated class inherits from. This class must inherit > - KConfigSkeleton. > + KConfigSkeleton and must provide an empty ctor, an ctor taking a QString > argument and a ctor taking > + a KSharedConfig::Ptr as arg

[Differential] [Commented On] D3091: Windows: Don't display error dialogs

2016-10-17 Thread Nicolás Alvarez
nalvarez added a comment. Meanwhile I'm skeptical of the need to "set it back". Is there any case where such error dialog boxes would be desirable? It seems like their existence is an ancient-app-compatibility thing. The documentation for `SetErrorMode` recommends setting `SEM_FAILCRITICALER

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-20 Thread Nicolás Alvarez
wish it was done over all other KDE software using flex/bison. - Nicolás Alvarez On Mayo 20, 2016, 3:39 a.m., Pino Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

2016-03-28 Thread Nicolás Alvarez
> On March 28, 2016, 5:22 p.m., Sven Brauch wrote: > > Hmm. Do we really need code for that? Can't you simply assign those buttons > > to the forward / backward actions as shortcuts? Try setting them as > > alternate shortcuts by default. > > Anthony Fieroni wrote: > This code is needed. Q

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

2016-02-25 Thread Nicolás Alvarez
project in `~/local`, system Qt in `/usr`), nothing changes. I was concerned because I have seen other projects always try to install stuff in eg. `/etc`, even if `CMAKE_INSTALL_PREFIX` is somewhere in `$HOME`, because some system daemon expects its config there. But that's not the case her

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

2016-02-25 Thread Nicolás Alvarez
ntogit/packages.git/tree/trunk/PKGBUILD?h=packages/kcoreaddons > > http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/wily/pkg-kde-tools/wily/view/head:/datalib/kf5_flags > https://pkgs.fedoraproject.org/cgit/rpms/kf5.git/tree/macros.kf5 > > Nicolás Alvarez wrote: >

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

2016-02-24 Thread Nicolás Alvarez
> On Feb. 24, 2016, 4:06 p.m., Stephen Kelly wrote: > > Hi Aleix, > > > > I'm not familiar with the 'tiny mess'. Can you say what it is? I would > > expect the libs go in the same place, but maybe the plugins are affected by > > this? Can you be more specific? > > > > Thanks, > > Aleix Pol G

Re: Menu/Command capitalization

2016-01-08 Thread Nicolás Alvarez
> On Jan 8, 2016, at 08:51, Jaroslaw Staniek wrote: > >> On 8 January 2016 at 00:28, Pino Toscano wrote: >> Hi, >> >> In data giovedì 7 gennaio 2016 22:42:18, Jaroslaw Staniek ha scritto: >>> Not too long ago MS Windows has moved from "Title Capitalization" to >>> "Sentence capitalization" for

Re: KDE PIM Split?

2015-12-01 Thread Nicolás Alvarez
> El 1 dic 2015, a las 05:10, Ben Cooksley escribió: > >> On Tue, Dec 1, 2015 at 6:50 PM, laurent Montel wrote: >> Le lundi 30 novembre 2015, 22:43:36 CET Ben Cooksley a écrit : >>> Hi Pim devels, >> >> Hi, >> So I reorganized source yesterday. >> I verified that all was ok >> So how I do now

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

2015-11-19 Thread Nicolás Alvarez
> On Nov. 18, 2015, 4:22 a.m., Martin Gräßlin wrote: > > src/plugins/osx/macpoller.cpp, lines 222-227 > > > > > > seriously? You care about idle timeouts below 5 msec? This is a > > framework to tell the applica

Re: [CRITICAL] KIO Test "threadtest" can enter into infinite loop

2015-11-08 Thread Nicolás Alvarez
2015-11-07 7:23 GMT-03:00 David Faure : > On Saturday 07 November 2015 10:36:18 David Faure wrote: >> On Saturday 07 November 2015 11:17:31 Ben Cooksley wrote: >> > Hi all, >> > >> > It appears the test running with the binary name of "threadtest" in >> > kio has a grave bug which can lead to it en

Re: Review Request 125756: Initialize QFunctionPointer to Q_NULLPTR

2015-10-22 Thread Nicolás Alvarez
> On Oct. 22, 2015, 9:09 a.m., Martin Gräßlin wrote: > > src/declarativeimports/core/windowthumbnail.h, lines 128-129 > > > > > > AFAIK we are not yet allowed to use nullptr in frameworks. You need to > > use Q_

Re: [OS X] adding a link module to all KF5 targets

2015-09-22 Thread Nicolás Alvarez
2015-09-22 19:28 GMT-03:00 Albert Astals Cid : > El Dimarts, 22 de setembre de 2015, a les 23:04:22, René J.V. Bertin va > escriure: >> On Tuesday September 22 2015 22:35:40 Albert Astals Cid wrote: >> > Shouldn't KF5 work with those sandboxing? I'd expect that KF5 goal is that >> > you can use it

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-17 Thread Nicolás Alvarez
> On Jul. 15, 2015, 6:36 a.m., Milian Wolff wrote: > > src/kextracolumnsproxymodel.cpp, line 85 > > > > > > ah, a pity. Btw, in KDevelop where I can use lambdas (can you here?), I > > stopped using private signal

Re: a problem with kdesktopfile.cpp

2015-02-04 Thread Nicolás Alvarez
2015-02-04 15:54 GMT-03:00 Guy Maurel : > Hello! > > I wonder about the code of kdesktopfile.cpp at line 80: > ... > QString KDesktopFile::locateLocal(const QString &path) > { > QString relativePath; > // Relative to config? (e.g. for autostart) > Q_FOREACH (const QString &dir, > QStand

Re: OSX/CI: QSP patch ( was "KF5 Update Meeting Minutes 2014-w28" )

2015-01-03 Thread Nicolás Alvarez
2015-01-03 11:04 GMT-03:00 René J.V. : > On Saturday January 03 2015 11:53:48 Andrius da Costa Ribas wrote: > >> Regarding oxygen, we'd probably change it later into breeze. > > My advice: don't, it's ugly and way too spacious ;) > Then again, "oxygen5" is, too. > >> Oxygen works >> fine (Qt fallba

Re: Review Request 121283: Allow using new style connect in KActionCollection::add[Action]()

2014-12-20 Thread Nicolás Alvarez
esn't work). - Nicolás Alvarez On Nov. 30, 2014, 11:11 a.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2014-12-20 Thread Nicolás Alvarez
esn't work). - Nicolás Alvarez On Nov. 30, 2014, 11:29 a.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-12 Thread Nicolás Alvarez
On Dic. 11, 2014, 1:02 p.m., Ralf Habacker wrote: > > Regarding patterns, why not just using a list of the icons we need? > > patterns+cmake have weird effects... > > Would it be possible to include a test? It's reasonably easy to create ecm > > tests nowadays and very useful afterwards. You'll

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2014-12-12 Thread Nicolás Alvarez
> On Nov. 9, 2014, 9:52 p.m., Alexander Richardson wrote: > > When I originally got KF5 to compile on windows I seem to remember having > > to do this a few times manually as well. > > > > Would it make sense to add the macro to KCoreAddons? KDEPimLibs also depends on this macro in several pla

Re: Review Request 121400: Add a new macro to create VERSIONINFO resources for Windows

2014-12-10 Thread Nicolás Alvarez
iff: https://git.reviewboard.kde.org/r/121400/diff/ Testing --- Tested with CMake 3.0.2 in kcoreaddons (review /r/121401), MSVC2013, Windows 7. Explorer tooltip shows description and version. File properties shows all the new information. Thanks, Nicolás Alvarez __

Re: Review Request 121400: Add a new macro to create VERSIONINFO resources for Windows

2014-12-10 Thread Nicolás Alvarez
cally generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121400/#review71745 ----------- On Dec. 9, 2014, 2:01 a.m., Nicolás Alvarez wrote: > > --- > This is an aut

Review Request 121400: Add a new macro to create VERSIONINFO resources for Windows

2014-12-08 Thread Nicolás Alvarez
File properties shows all the new information. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121401: Add Windows VERSIONINFO to KF5CoreAddons.dll

2014-12-08 Thread Nicolás Alvarez
shows description and version. File properties shows all the new information. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext -> HTML conversion

2014-12-08 Thread Nicolás Alvarez
2014-12-08 23:37 GMT-03:00 Nicolás Alvarez : >> https://git.reviewboard.kde.org/r/121094/ > > This change fails to compile on Windows, because the unit test has > ktexttohtml.cpp as a source file *and* it's linking to the kcoreaddons > library which obviously defines the sam

Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext -> HTML conversion

2014-12-08 Thread Nicolás Alvarez
> https://git.reviewboard.kde.org/r/121094/ This change fails to compile on Windows, because the unit test has ktexttohtml.cpp as a source file *and* it's linking to the kcoreaddons library which obviously defines the same function. In addition, ktexttohtml.h in this context is declaring the funct

Re: Review Request 121075: Also export inner KBookmarkOwner::FutureBookmark

2014-12-05 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121075/#review71451 --- Ship it! Ship It! - Nicolás Alvarez On Nov. 8, 2014, 7:13

Re: Supporting MSVC2010 in ktexteditor framework

2014-11-17 Thread Nicolás Alvarez
El domingo, 16 de noviembre de 2014, Ivan Čukić escribió: > Hi, > > The topic of increasing the compiler versions we require might have been > started for the specific issue one of the frameworks had, but I think it > shouldn't have died out when the issue in question got patched. > The issue in

Re: How to port KTabBar::mouseMiddleClick?

2014-11-10 Thread Nicolás Alvarez
2014-11-09 7:28 GMT-03:00 Frank Reininghaus : > Hi, > > 2014-11-06 2:59 GMT+01:00 Milian Wolff: >> Hey all, >> >> what do I do to get middle-click-closes-tab in Qt 5 without KTabBar? >> Previously, we used KTabBar and its mouseMiddleClick signal. > > AFAIK, currently the only solution is to subclas

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-06 Thread Nicolás Alvarez
2014-11-05 23:44 GMT-03:00 Sebastian Kügler : > So, this code is in a bit of a draft stage, I'd very much welcome feedback > about the approach, and of course the code itself. It can be found in > kservice[sebas/kpluginindex]. the kpluginmetadata autotest gives a useful > testing target. I didn't s

Re: Supporting MSVC2010 in ktexteditor framework

2014-11-05 Thread Nicolás Alvarez
2014-11-05 15:18 GMT-03:00 Nicolás Alvarez : > 2014-11-05 10:35 GMT-03:00 Kevin Ottens : >> VS2012 hits the sweet spot of being relatively widespread while starting to >> have a useful subset of C++11 (case in point ktexteditor which prompted this >> thread builds with it)

Re: Supporting MSVC2010 in ktexteditor framework

2014-11-05 Thread Nicolás Alvarez
2014-11-05 10:35 GMT-03:00 Kevin Ottens : > VS2012 hits the sweet spot of being relatively widespread while starting to > have a useful subset of C++11 (case in point ktexteditor which prompted this > thread builds with it). Actually I just found it doesn't build with VS2012 either, ugh. And I exp

Supporting MSVC2010 in ktexteditor framework

2014-11-04 Thread Nicolás Alvarez
Hi all, According to https://community.kde.org/Frameworks/C++11, KDE Frameworks support MSVC2010 and later versions. Since ktexteditor is part of KF5, it is supposed to work on MSVC2010. It currently doesn't; several unsupported C++11 features were introduced to the library in the past few months.

DLL version info on WIndows

2014-11-03 Thread Nicolás Alvarez
Windows has a way for executables and shared libraries (DLLs) to contain version information in a machine-readable format. This information can be seen in Explorer in the file properties (http://goo.gl/UbJGte) and also in the tooltip when hovering the file. It's also used by Windows Installer to av

Re: Detailed dependencies of frameworks on external resources like icons

2014-11-02 Thread Nicolás Alvarez
2014-09-17 18:44 GMT-03:00 Friedrich W. H. Kossebau : > Two years ago, to fight the number of "unknown" icons appearing in the UI and > reducing duplicated icons in the Calligra repo itself, some macros have been > introduced in Calligra, to tag all icon name ids being used in the program, so > aut

Re: Whoopsie in KF5::WindowSystem 5.3.0

2014-10-10 Thread Nicolás Alvarez
2014-10-10 19:47 GMT-03:00 David Faure : > On Friday 10 October 2014 17:14:41 Martin Graesslin wrote: >> I recommend to either do a 5.3.1 >> release for KWindowSystem with just that commit added > > Done. > > kwindowsystem v5.3.1 > 49f34827a0cbd46320149c7b835abd8431287083 > 80765c897128907307558dbe

Re: Review Request 120508: Port kio_trash_win to KF5

2014-10-05 Thread Nicolás Alvarez
://git.reviewboard.kde.org/r/120508/diff/ Testing --- It builds, MSVC2013. Haven't tested if it works (the unit test still doesn't build). Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.o

Review Request 120508: Port kio_trash_win to KF5

2014-10-05 Thread Nicolás Alvarez
unit test still doesn't build). Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kio_trash

2014-10-01 Thread Nicolás Alvarez
2014-10-01 4:49 GMT-03:00 David Faure : > On Monday 22 September 2014 22:26:06 David Faure wrote: >> On Saturday 13 September 2014 20:29:18 Luigi Toscano wrote: >> > Luigi Toscano ha scritto: >> > > Nicolás Alvarez ha scritto: >> > >> 2014-09-13 15:13 G

Re: Minimum compiler versions

2014-09-18 Thread Nicolás Alvarez
2014-09-17 14:12 GMT-03:00 Nicolás Alvarez : > If we'll keep the compiler requirements as-is, I volunteer to fix > what's broken in the minimum versions we claim to support. But I think > we need CI for gcc 4.5, otherwise it will keep breaking... Okay, that wasn't so hard

Minimum compiler versions

2014-09-17 Thread Nicolás Alvarez
Hello devs, Currently our Policies wiki page[1] says the minimum supported compilers for KF5 are gcc 4.5, clang 3.1 and MSVC 2010. Due to the use of range-based for loops, ThreadWeaver doesn't compile on MSVC2010 or gcc4.5. kcoreaddons doesn't build on gcc 4.5 because it uses nullptr. More testin

Re: kio_trash

2014-09-13 Thread Nicolás Alvarez
2014-09-13 15:13 GMT-03:00 Nicolás Alvarez : > 2014-09-09 12:22 GMT-03:00 David Faure : >> On Sunday 17 August 2014 00:03:41 David Faure wrote: >>> kio_trash is currently in kde-workspace/kio-extras, but KIO actually offers >>> API that depends on kio_trash (KIO::tras

Re: kio_trash

2014-09-13 Thread Nicolás Alvarez
2014-09-09 12:22 GMT-03:00 David Faure : > On Sunday 17 August 2014 00:03:41 David Faure wrote: >> kio_trash is currently in kde-workspace/kio-extras, but KIO actually offers >> API that depends on kio_trash (KIO::trash(), JobUiDelegateExtension::Trash, >> support for trash in FileUndoManager, and

Re: There's no proper replacement for KIcon

2014-09-03 Thread Nicolás Alvarez
2014-09-03 17:05 GMT-03:00 Mark Gaiser : > On Wed, Sep 3, 2014 at 10:01 PM, Albert Astals Cid wrote: >> El Dimecres, 3 de setembre de 2014, a les 21:42:24, Mark Gaiser va escriure: >>> On Wed, Sep 3, 2014 at 7:16 PM, Albert Astals Cid wrote: >>> > Porting guide lies in saying that KIcon should be

Re: OSX/CI: threadweaver fails to build test

2014-08-20 Thread Nicolás Alvarez
2014-08-20 14:21 GMT-03:00 Marko Käning : > Linking CXX executable ThreadWeaverJobTests > [100%] Built target ThreadWeaverJobTests > /Users/marko/WC/KDECI-builds/threadweaver/examples/ThumbNailer/Model.cpp:77:24: > error: use of undeclared identifier 'accumulate' > auto const soFar = accumulat

Re: Review Request 119736: Convert the ki18n programmers' guide to Markdown

2014-08-13 Thread Nicolás Alvarez
mmers-guide.md PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119736/diff/ Testing --- I ensured the final HTML result from doxygen looks (nearly) identical to the .dox version. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing

Review Request 119736: Convert the ki18n programmers' guide to Markdown

2014-08-12 Thread Nicolás Alvarez
sting --- I ensured the final HTML result from doxygen looks (nearly) identical to the .dox version. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: OSX/CI: kgeography fails to build on branch frameworks

2014-08-11 Thread Nicolás Alvarez
2014-08-11 21:30 GMT+02:00 Marko Käning : > > [ 44%] /Users/marko/WC/KDECI-builds/kgeography/src/kgeography.cpp:18:10: > fatal error: 'kicon.h' file not found > #include > ^ > Building CXX object src/CMakeFiles/kgeography.dir/mypopup.cpp.o > [ 48%] Building CXX object src/CMakeFiles/kgeo

Re: KDELibs4Support fails to install on Windows if DocBookXML4 absent

2014-07-23 Thread Nicolás Alvarez
El miércoles, 23 de julio de 2014, Luigi Toscano escribió: > On Wednesday 23 of July 2014 00:27:18 Nicolás Alvarez wrote: > > Hello, > > > > Currently KDELibs4Support fails to install on Windows. It gives the > > following error: > > > > CMake Err

KDELibs4Support fails to install on Windows if DocBookXML4 absent

2014-07-22 Thread Nicolás Alvarez
Hello, Currently KDELibs4Support fails to install on Windows. It gives the following error: CMake Error at src/cmake_install.cmake:264 (file): file RELATIVE_PATH must be passed a full path to the file: searched_dir-NOTFOUND Call Stack (most recent call first): cmake_install.cmake:115 (inclu

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

2014-07-12 Thread Nicolás Alvarez
longer SIDs to identify users. These are not returned by stat (stat always returns zero in the st_uid member). I would just ifdef away the UDS_USER and UDS_GROUP lines on Windows. - Nicolás Alvarez On Jul. 12, 2014, 11:20 a.m., Cristian Oneț wrote

Re: OSX/CI system: analitza build broken on branch frameworks

2014-07-10 Thread Nicolás Alvarez
2014-07-10 6:25 GMT-03:00 Aleix Pol : > On Thu, Jul 10, 2014 at 6:48 AM, Marko Käning wrote: >> >> Thanks, now it there is more progress, but there’s s till a build failure >> later on. See below. >> >> Greets, >> Marko >> >> >> ——— >> >> >> >> 80%] Building CXX object >> analitzaplot/CMakeFiles/

Re: OSX/CI system: analitza with configure problem on branch master

2014-07-09 Thread Nicolás Alvarez
2014-07-09 19:45 GMT-03:00 Marko Käning : > Hi, > > see below for analitza’s configure problem, which seems to require > kde4-config for some reason... > > I don’t know why this is happening, since it is shown DONE for KF5 on [1]. > > Greets, > Marko > > > [1] http://community.kde.org/KDEEdu/Route

Directory structure under share/

2014-07-03 Thread Nicolás Alvarez
The subdirectories of prefix/share/ that KF5 installs seem inconsistent. For example, KAuth installs some data files in share/kf5/kauth, while KService services go to share/kservices5. Do we prefix things with kf5/ or not? Or is there a reason why some are prefixed and some aren't? -- Nicolás __

Re: OSX/MacPorts KDE CI System: Build failed for framework solid

2014-07-03 Thread Nicolás Alvarez
2014-07-03 3:31 GMT-03:00 Kevin Ottens : > Hello, > > On Wednesday 02 July 2014 08:33:01 Marko Käning wrote: >> on OSX solid fails to build because of this: >> >> --- >> /Users/marko/WC/KDECI-builds/solid/src/solid/devices/backends/iokit/iokitdev >> ice.cpp:227:25: error: allocating an object of ab

Re: Review Request 118852: [kconfig] Fix build on Visual C++ 2010

2014-06-29 Thread Nicolás Alvarez
s. Diffs - autotests/kconfigtest.cpp a8482b7 Diff: https://git.reviewboard.kde.org/r/118852/diff/ Testing --- Compiles on MSVC2010, kconfigtest passes (with testEnums skipped). I haven't tried compiling on other compilers. Thanks, Nicolás Alvarez

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

2014-06-27 Thread Nicolás Alvarez
2014-06-27 20:59 GMT-03:00 David Faure : > On Friday 27 June 2014 23:01:33 Marko Käning wrote: >> I guess I’ve spotted that one of the frameworks obviously messes up when >> writing to the standard location below “Library/Application Support/“ >> because it omits the trailing slash leading to this

Re: Review Request 118852: [kconfig] Fix build on Visual C++ 2010

2014-06-27 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118852/#review61114 ----------- On June 20, 2014, 9:20 p.m., Nicolás Alvarez wrote: > > --

Re: Review Request 118852: [kconfig] Fix build on Visual C++ 2010

2014-06-23 Thread Nicolás Alvarez
iewboard.kde.org/r/118852/#review60850 --- On June 20, 2014, 9:20 p.m., Nicolás Alvarez wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Review Request 118852: [kconfig] Fix build on Visual C++ 2010

2014-06-20 Thread Nicolás Alvarez
Testing --- Compiles on MSVC2010, kconfigtest passes (with testEnums skipped). I haven't tried compiling on other compilers. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/m

Re: Review Request 118039: Simplify KConfig::readEntry/writeEntry

2014-06-20 Thread Nicolás Alvarez
2014-05-07 14:15 GMT-03:00 Thomas Braxton : > > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118039/ > > Review request for KDE Frameworks and kdewin. > By Thomas Braxton. > > Summary > > Simplify KConfig::readEntry/writeEntry > > Description (upd

Re: git hooks for reviews mandatory?

2014-06-19 Thread Nicolás Alvarez
2014-06-19 18:21 GMT-03:00 Marco Martin : > Hi all, > I was thinking, since the policy for committing in frameworks is to always > asking for a review, what about on repositories under frameworks/* adding an > hook that accepts pushes only if the comment has a REVIEW: line? > > I have been guilty t

Re: Review Request 118374: Fix finding of Qt5LinguistTools on some systems

2014-05-28 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118374/#review58677 --- Ship it! Ship It! - Nicolás Alvarez On May 28, 2014, 8:32

Themed icons on Windows

2014-05-25 Thread Nicolás Alvarez
The QIcon::fromTheme documentation says: "By default, only X11 will support themed icons. In order to use themed icons on Mac and Windows, you will have to bundle a compliant theme in one of your themeSearchPaths and set the appropriate themeName." I can confirm this; Okteta5 doesn't show icons on

Re: KFileAudioPreview

2014-05-12 Thread Nicolás Alvarez
2014-05-12 18:46 GMT-03:00 Alex Merry : > Perhaps it's too late to change this, but it seems to me that this > plugin should either be in KIO or kio-extras. The reason it isn't in KIO > is that it depends on Phonon. KIO already depends indirectly on KNotifications which depends on Phonon. -- Nic

Re: Review Request 118077: Fix build of kdelibs4migration.cpp on MSVC2010

2014-05-11 Thread Nicolás Alvarez
/util/kdelibs4migration.cpp 94655d9 Diff: https://git.reviewboard.kde.org/r/118077/diff/ Testing --- Compiles, tests pass. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinf

Review Request 118077: Fix build of kdelibs4migration.cpp on MSVC2010

2014-05-10 Thread Nicolás Alvarez
sting --- Compiles, tests pass. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117961: remove several warnings on mingw

2014-05-02 Thread Nicolás Alvarez
org/r/117961/#comment39856> What's the warning here? Is it about signed vs unsigned? If so, change the format specifier to %u instead of casting. - Nicolás Alvarez On May 2, 2014, 6:16 p.m., Patrick Spendrin wrote: > > ---

Re: KF5 Update Meeting Minutes 2014-w17

2014-04-22 Thread Nicolás Alvarez
maintainers > > mck182> so can people please please update the list > > mck182> http://community.kde.org/Frameworks/List > > mck182> that is, if you're a maintainer and your framework says TBD, > please update > > mck182> also I reset the assignee on som

Re: Remnants of monolithic kdelibs.git building

2014-04-21 Thread Nicolás Alvarez
2014-04-21 16:53 GMT-03:00 Nicolás Alvarez : > 2014-03-27 13:18 GMT-03:00 Alex Merry : >> On 27/03/14 15:39, Nicolás Alvarez wrote: >>> Many frameworks' top-level CMakeLists.txt still wrap their >>> find_package calls in: >>> >>> if ("${

Re: Review Request 117680: Fix linker errors with MSVC

2014-04-21 Thread Nicolás Alvarez
013 should be working even without this patch, as Q_DISABLE_COPY will use =delete instead of declaring the functions private. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/li

Re: Remnants of monolithic kdelibs.git building

2014-04-21 Thread Nicolás Alvarez
2014-03-27 13:18 GMT-03:00 Alex Merry : > On 27/03/14 15:39, Nicolás Alvarez wrote: >> Many frameworks' top-level CMakeLists.txt still wrap their >> find_package calls in: >> >> if ("${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}") &g

Re: Review Request 117655: Move the libgcrypt search to the backend CMakeLists.txt

2014-04-21 Thread Nicolás Alvarez
being built (ie. if BUILD_KWALLETD=OFF). Diffs - CMakeLists.txt 9aad9c0 src/runtime/kwalletd/backend/CMakeLists.txt 4c36767 Diff: https://git.reviewboard.kde.org/r/117655/diff/ Testing --- Builds, Linux and Windows. Thanks, Nicolás Alvarez

Review Request 117655: Move the libgcrypt search to the backend CMakeLists.txt

2014-04-21 Thread Nicolás Alvarez
/kwalletd/backend/CMakeLists.txt 4c36767 Diff: https://git.reviewboard.kde.org/r/117655/diff/ Testing --- Builds, Linux and Windows. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Review Request 117680: Fix linker errors with MSVC

2014-04-21 Thread Nicolás Alvarez
laring the functions private. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117654: Replace range-based for loop with Qt foreach

2014-04-21 Thread Nicolás Alvarez
https://git.reviewboard.kde.org/r/117654/diff/ Testing --- All of KWallet builds on Windows with MSVC2010 (if review #117652 is applied too). Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/lis

Re: Review Request 117652: Rewrite FindLibGcrypt.cmake to not use gcrypt-config

2014-04-21 Thread Nicolás Alvarez
/diff/ Testing --- Tested on Windows with MSVC2010, cmake 2.8.12, finding emerge-built libgcrypt. Also tested on Debian Linux, cmake 2.8.12.1, finding the distro's libgcrypt. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-

Re: Review Request 117652: Rewrite FindLibGcrypt.cmake to not use gcrypt-config

2014-04-20 Thread Nicolás Alvarez
src/runtime/kwalletd/backend/CMakeLists.txt 4c36767 Diff: https://git.reviewboard.kde.org/r/117652/diff/ Testing --- Tested on Windows with MSVC2010, cmake 2.8.12, finding emerge-built libgcrypt. Also tested on Debian Linux, cmake 2.8.12.1, finding the distro's libgcrypt. Thanks

Review Request 117652: Rewrite FindLibGcrypt.cmake to not use gcrypt-config

2014-04-19 Thread Nicolás Alvarez
crypt. Also tested on Debian Linux, cmake 2.8.12.1, finding the distro's libgcrypt. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117654: Replace range-based for loop with Qt foreach

2014-04-19 Thread Nicolás Alvarez
eview #117652 is applied too). Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117454: Implement KUser::faceIconPath for Windows XP

2014-04-11 Thread Nicolás Alvarez
s, as otherwise the code became too redundant. Feedback welcome on identifier names, that's a known hard problem :) Diffs - src/lib/util/kuser_win.cpp aa48c04 Diff: https://git.reviewboard.kde.org/r/117454/diff/ Testing --- Ran faceicontest on Windows 7 and on XP. Thanks, Nicol

  1   2   >