krutovmikhail abandoned this revision.
krutovmikhail added a comment.
Yup
REVISION DETAIL
https://phabricator.kde.org/D20026
To: krutovmikhail, ngraham, #dolphin
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
krutovmikhail added a comment.
Thanks for the headsup!
https://invent.kde.org/frameworks/kio/-/merge_requests/74
REVISION DETAIL
https://phabricator.kde.org/D20026
To: krutovmikhail, ngraham, #dolphin
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
krutovmikhail added a comment.
So, I'm really sorry for *very* long absence in this context. Updated diff..
Which works. I'll go over style and things tomorrow.
REVISION DETAIL
https://phabricator.kde.org/D20026
To: krutovmikhail, ngraham, #dolphin
Cc: meven, kde-frameworks-devel, LeGast00
krutovmikhail updated this revision to Diff 83328.
krutovmikhail added a comment.
- fix build
- Fixes for behaviour
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20026?vs=54897&id=83328
BRANCH
arcpatch-D20026
REVISION DETAIL
https://phabricator.kde.org/D20026
AFFECTED FILES
krutovmikhail added a comment.
Hi @ngraham,
Sorry for long time no update. I'll be getting back to this soon.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20026
To: krutovmikhail, ngraham, #dolphin
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham
krutovmikhail added a comment.
@ngraham , I have a problem with toLocalFile() which I'm not sure how to
solve. Namely, from docs:
> qDebug() << QUrl("file.txt").toLocalFile(); // ""; wasn't
a local file as it had no scheme
KUrlNavigator's locationUrl() doesn't inclu
krutovmikhail added a comment.
Whoops. I have a mix-up between two machines on which code is on, this
compiles on one I've developed it on (no _urls/urls change), but not on one
I've pushed from. I'll update this in several hours.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.
krutovmikhail updated this revision to Diff 54897.
krutovmikhail added a comment.
- Update per phabricator comments: styling, boolean to enum, windows fix
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20026?vs=54893&id=54897
BRANCH
mkrutov/20190324/feat/kur
krutovmikhail added a comment.
Yes, I was mostly pointing out that it seems to be out of scope of this
revision to fix that problem :-)
https://bugs.kde.org/show_bug.cgi?id=157593#c4 this seems to be the most
reasonable solution, if to keep the patch there. However, pressing "return" or
krutovmikhail updated this revision to Diff 54893.
krutovmikhail marked 11 inline comments as done.
krutovmikhail added a comment.
- Update per phabricator comments: styling, boolean to enum, windows fix
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20026?vs=5
krutovmikhail added a comment.
ngraham, in Dolphin, this commit is to blame for loosing editMode on changing
URL:
https://github.com/KDE/dolphin/commit/2af331b42c0514f4fdf848d0cc22f02717f7bec0
I don't think that this behavior has any logic in it to be honest; but it
seems that it was ex
krutovmikhail added a comment.
Thanks, I'll apply styling changes & will take a look at GWenView. Out of KDE
Applications, what other consumers use KUrlNavigator? Is there an easy way to
find out?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20026
To: krutovmikhail,
krutovmikhail updated this revision to Diff 54815.
krutovmikhail added a comment.
Upated - Working variant with proper widgets - amending due to lost changes
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20026?vs=54812&id=54815
BRANCH
mkrutov/20190324/feat
krutovmikhail updated this revision to Diff 54812.
krutovmikhail edited the summary of this revision.
krutovmikhail added a comment.
Updated - Working variant with proper widgets
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20026?vs=54810&id=54812
BRANCH
krutovmikhail retitled this revision from "WIP: Bug 195801 - go up in folder
hierachy when in "edit mode"" to "Bug 195801 - go up in folder hierachy when in
"edit mode"".
krutovmikhail edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D2002
krutovmikhail marked 2 inline comments as done.
krutovmikhail added a comment.
After bit digging, found out a proper-er solution to both questions.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20026
To: krutovmikhail, ngraham, #dolphin
Cc: kde-frameworks-devel, michae
krutovmikhail updated this revision to Diff 54810.
krutovmikhail added a comment.
Updated - Working variant with proper widgets
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20026?vs=54758&id=54810
BRANCH
mkrutov/20190324/feat/kurlnavigator_keypresses_in_e
krutovmikhail added a comment.
I've updated the diff with a couple questions I have (about UI mostly). Still
WIP.
INLINE COMMENTS
> kurlnavigator.cpp:406
> +hasParent = (currentDirectory != currentDirectory.resolved(levelUp));
> +currentDirectory = QUrl(parentDirectory(curren
krutovmikhail updated this revision to Diff 54758.
krutovmikhail added a comment.
- initial take at dropdown list
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20026?vs=54722&id=54758
BRANCH
mkrutov/20190324/feat/kurlnavigator_keypresses_in_edit_mode
REVIS
krutovmikhail abandoned this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20025
To: krutovmikhail, #dolphin, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
krutovmikhail added a comment.
This was created as a new revision due to --amend prior to arc diff. Not sure
on how to update diff on previous one properly, previous is abandoned now.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20026
To: krutovmikhail, ngraham, #dol
krutovmikhail retitled this revision from "Initial adaptation of patch from
Dolphin; keyUp -> goUp" to "WIP: Bug 195801 - go up in folder hierachy when in
"edit mode"".
krutovmikhail edited the summary of this revision.
krutovmikhail added reviewers: ngraham, Dolphin.
REPOSITORY
R241 KIO
REVI
krutovmikhail created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
krutovmikhail requested review of this revision.
REPOSITORY
R241 KIO
BRANCH
mkrutov/20190324/feat/kurlnavigator_keypresses_in_edit_mode
REVISION DETAIL
https://phabrica
krutovmikhail retitled this revision from "WIP: Initial adaptation of patch
from Dolphin; keyUp -> goUp" to "WIP: Bug 195801 - go up in folder hierachy
when in "edit mode"".
krutovmikhail edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D2
krutovmikhail retitled this revision from "Initial adaptation of patch from
Dolphin; keyUp -> goUp" to "WIP: Initial adaptation of patch from Dolphin;
keyUp -> goUp".
krutovmikhail added reviewers: Dolphin, ngraham.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20025
To:
krutovmikhail created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
krutovmikhail requested review of this revision.
REPOSITORY
R241 KIO
BRANCH
mkrutov/20190324/feat/kurlnavigator_keypresses_in_edit_mode
REVISION DETAIL
https://phabrica
26 matches
Mail list logo
