D26342: Allow overriding to disable auto language detection

mludwig added a comment. @Simon: If you add a call 'setAutoDetectLanguageDisabled(false)' to 'BackgroundChecker::changeLanguage' and 'BackgroundChecker::setSpeller', you should be able to take Albert's suggestion into account. For the Highlighter it should be similar. REPOSITORY R246

D26342: Allow overriding to disable auto language detection

mludwig added a comment. In D26342#619785 , @aacid wrote: > without having used Sonnet much, this seems the wrong API to me. > > Are you saying that it can happen that you tell Sonnet "use this language" and it goes and say "nah i'll ignore y

D25495: Fix Sonnet autodetect failing on Indian langs

mludwig added a comment. Thanks for the updated patch! In D25495#585855 , @waqar wrote: > > There is also a bug in GuessLanguagePrivate::guessFromTrigrams(const QString &sample, const QStringList &languages): if m_minConfidence is left to i

D26346: Sonnet: Fix returning from GuessLanguagePrivate::guessFromTrigrams

mludwig updated this revision to Diff 72552. mludwig added a comment. Small fix to the documentation. REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26346?vs=72551&id=72552 REVISION DETAIL https://phabricator.kde.org/D26346 AFFECTED FILES src/core/gues

D26346: Sonnet: Fix returning from GuessLanguagePrivate::guessFromTrigrams

mludwig created this revision. mludwig added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mludwig requested review of this revision. REVISION SUMMARY The documentation states that "Default is returning best guess without caring abo

D26342: Allow overriding to disable auto language detection

mludwig added a comment. I'd support such a change for the BackgroundChecker as well. KTextEditor needs a way to do its own language detection or override the detected language. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D26342 To: sdepiets, #frameworks Cc: mludw

D25495: Fix Sonnet autodetect failing on Indian langs

mludwig added a comment. You are right that in GuessLanguage::identify(const QString &text, const QStringList &suggestionsListIn), if a language without trigrams is not present in 'suggestionsListIn', it will never be 'guessed'. I'd suggest to move your changes to GuessLanguage::identify

D26321: Expose show-line-count in the ConfigInterface

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:3026a9caa868: Add "line-count" property to the ConfigInterface (authored by mludwig). CHANGED PRIOR TO COMMIT https:/

D26321: Expose show-line-count in the ConfigInterface

mludwig added a comment. In D26321#585381 , @cullmann wrote: > I am ok with this , but in the long run, we want to change the behavior of the view's config interface to just dispatch to the internal config interface like for the document. > Y

D26321: Expose show-line-count in the ConfigInterface

mludwig updated this revision to Diff 72484. mludwig added a comment. Add "line-count" to KTextEditor::ViewPrivate::configKeys() REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26321?vs=72445&id=72484 REVISION DETAIL https://phabricator.kde.org/D26321

D26321: Expose show-line-count in the ConfigInterface

mludwig created this revision. mludwig added a reviewer: KTextEditor. mludwig added a project: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. mludwig requested review of this revision. REVISION SUMMARY The show-line-count prope

D25244: Implement ISpellChecker backend for Windows >= 8

mludwig added a comment. I've tried it out and works just fine! :) REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25244 To: cullmann, #frameworks, vonreth Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25244: Implement ISpellChecker backend for Windows >= 8

mludwig added a comment. In D25244#562817 , @cullmann wrote: > Some feedback? > Else I would just try that. > For me it worked fine (obviously). I will try it out over the weekend. It's something I planned to work on myself, but you

D17310: Use a Kile Icon that is similar to the original

mludwig accepted this revision. REPOSITORY R266 Breeze Icons BRANCH improve-kile-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D17310 To: trickyricky26, #vdg, ngraham, #kile, mludwig Cc: alex-l, loh.tar, mludwig, ndavis, ngraham, kde-frameworks-devel, michaelh,

D17310: Use a Kile Icon that is similar to the original

mludwig added a comment. In D17310#387589 , @trickyricky26 wrote: > - Make Kile letters a lighter color Yep, thanks. That's a great icon now - I like it a lot! REPOSITORY R266 Breeze Icons BRANCH improve-kile-icon (branched from mas

D17310: Use a Kile Icon that is similar to the original

mludwig added a comment. In D17310#387633 , @alex-l wrote: > I'm the author of this one: > > F6530055: immagine.png > > That has been in Breeze for years. Please next time don't wait so much to compl

D17310: Improve Kile icon with LaTeX font

mludwig added a comment. In D17310#385180 , @trickyricky26 wrote: > Here are some designs that are more faithful to the original: > > F6520878: kile-faithful.svg.png > This has almost the same letter

D17310: Improve Kile icon with LaTeX font

mludwig added a comment. In D17310#383350 , @ngraham wrote: > #kile folks, are you good with this now? If we don't hear back in a week or two, we'll have to assume yes. :) Sorry, but I'm still not a

D17310: Improve Kile icon with LaTeX font

mludwig added a comment. In D17310#370758 , @ngraham wrote: > I would not recommend embedding the app name into the icon itself. The text isn't localizable, the icon would become really cramped, and in any event it would look weird since no othe

D17310: Improve Kile icon with LaTeX font

mludwig added a comment. Hey, thanks for working on this. I don't mind the change in font style. However, do you think it's possible to add "Kile" somewhere onto the icon as well, preferably quite largely. With this icon, I always find it hard to locate Kile in the task manager. RE

D13442: Implemented displaying of total lines in kate

mludwig added a comment. If you decide to add a config option, it would be great if you could add a programmatic way to inform applications that don't use the default status bar about changes regarding that config option. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kd

D11838: Turn on line numbers by default

mludwig added a comment. In D11838#238728 , @dhaumann wrote: > Personally, I dislike the idea of passing options in createView for a very simple reason: we have document variables, .kateconfig files, settings on the UI, the command line, the Con

D11838: Turn on line numbers by default

mludwig added a comment. In D11838#238269 , @ngraham wrote: > So what's our path forward here? Is there a way to only turn on line numbers for Kate itself, and not for the katepart? One suggestion would be to extend the method for creatin

D11838: Turn on line numbers by default

mludwig added a comment. In D11838#238269 , @ngraham wrote: > That said, I'm still struggling to understand what the problems is with line numbers in Kile. Most of the editors listed at https://beebom.com/best-latex-editors/ have line numbers on

D11838: Turn on line numbers by default

mludwig requested changes to this revision. mludwig added a comment. This revision now requires changes to proceed. I don't think that this is ok for Kile. KatePart is an editor component that needs to fit many different contexts. For Kile, I don't see a need to have line numbers switched

Re: KTabWidget vs QTabWidget

On 09/25/2015 01:57 AM, Jeremy Whiting wrote: Michel, Would you mind if I move the DropWidget you wrote for kile into kwidgetsaddons and give it a name like KDropWidget and relicense it to LGPL v2+ ? That's totally fine with me. Michel ___ Kde-fram