michalhumpula accepted this revision.
michalhumpula added a reviewer: michalhumpula.
michalhumpula added a comment.
This revision is now accepted and ready to land.
Hi Francis, it probably got switched during massive refactor few years back
by me. Looks good. Thanks for the fix!
REPOSITORY
Hi there,
does anyone know, what are the ./configure params the Qt is compiled on
Jenkins machine with? There is some failing test in kate due to assertion in
Qt and I'm failing to reproduce the error locally.
Cheers
Michal
___
Kde-frameworks-devel ma
/
Testing
---
Thanks,
Michal Humpula
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
, except the kinit, which needs a little patch.
Diffs
-
kde-modules/KDEFrameworkCompilerSettings.cmake c27af0c
Diff: https://git.reviewboard.kde.org/r/115012/diff/
Testing
---
Thanks,
Michal Humpula
___
Kde-frameworks-devel mailing list
Kde
/diff/
Testing
---
Thanks,
Michal Humpula
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
,
Michal Humpula
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
board.kde.org/r/115013/diff/
Testing
---
Thanks,
Michal Humpula
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
Thanks,
Michal Humpula
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/KDEFrameworkCompilerSettings.cmake c27af0c
Diff: https://git.reviewboard.kde.org/r/115012/diff/
Testing
---
Thanks,
Michal Humpula
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
it's lazy patch, but considering that it's not a single option that is getting
removed, I would say it's ok.
Diffs
-
CMakeLists.txt c471101
Diff: https://git.reviewboard.kde.org/r/115013/diff/
Testing
---
Thanks,
---
this is necessary to compile the kinit with QT_USE_QSTRINGBUILDER on.
Diffs
-
src/kdeinit/kinit.cpp 8c7e53d
Diff: https://git.reviewboard.kde.org/r/115011/diff/
Testing
---
Thanks,
Michal Humpula
___
Kde-frameworks-devel mailing
Description
---
looks like some leftover, compiles ok without it.
Diffs
-
src/runtime/kwalletd/backend/tests/CMakeLists.txt 54ec000
Diff: https://git.reviewboard.kde.org/r/115010/diff/
Testing
---
Thanks,
Michal Humpula
___
Kde
On Tuesday 07 of January 2014 23:10:11 John Layt wrote:
> On 7 January 2014 19:55, Albert Astals Cid wrote:
> > El Dimarts, 7 de gener de 2014, a les 18:24:41, Alex Merry va escriure:
> >> On 07/01/14 17:10, John Layt wrote:
> >> > I've put myself down (rather obviously) for KPrintUtils. Most of
ationText(const QList &urlList)
doesn't call any setUrl, which hints that it could actually be correct.
Diffs
-
src/filewidgets/kfilewidget.cpp 11597b3
Diff: https://git.reviewboard.kde.org/r/114693/diff/
Testing
---
Thanks,
Michal Humpula
_
> >
> > Back to KF5: does this fix it?
> >
> > - if (!url.path().isEmpty()) {
> > +if (!url.isRelative()) {
> >
> > I'm curious as to why the setUrl("passwd") behaved differently from kde4
> > though?
> >
> >
this might explain the difference of (Q|K)Url(QString) constructor:
http://community.kde.org/Frameworks/Porting_Notes#KDECore_Changes
- Michal
-------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r
-
src/filewidgets/kfilewidget.cpp 11597b3
Diff: https://git.reviewboard.kde.org/r/114693/diff/
Testing
---
Thanks,
Michal Humpula
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
o some diffing between version, maybe something will
pop out.
- Michal
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114693/#review46448
-----------
On Sunday 29 of December 2013 14:44:59 David Faure wrote:
> On Thursday 19 December 2013 15:28:27 Dominik Haumann wrote:
> > On Thursday, December 19, 2013 15:12:01 Michal Humpula wrote:
> > > On Thursday 19 of December 2013 14:57:33 Dominik Haumann wrote:
> > > > O
t it could actually be correct.
Diffs
-
src/filewidgets/kfilewidget.cpp 11597b3
Diff: https://git.reviewboard.kde.org/r/114693/diff/
Testing
---
Thanks,
Michal Humpula
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
ht
On Tuesday 24 of December 2013 14:05:36 David Faure wrote:
> On Tuesday 24 December 2013 13:50:29 Michal Humpula wrote:
> > On Tuesday 24 of December 2013 13:22:05 David Faure wrote:
> > > On Tuesday 24 December 2013 12:30:56 Michal Humpula wrote:
> > > > Hi there,
On Tuesday 24 of December 2013 13:22:05 David Faure wrote:
> On Tuesday 24 December 2013 12:30:56 Michal Humpula wrote:
> > Hi there,
> >
> > as suggested without fully functional reviewboard, here is the little
> > patch
> > for discussion.
> >
> >
Hi there,
as suggested without fully functional reviewboard, here is the little patch
for discussion.
Emit urlChanged only when actually changing url trough setUrl. The drawback of
this is that now the fast assignment is replaced by possibly expensive string
comparison. On the other hand, when
Hi there,
I was trying to post a patch for kparts today, but failed to find a kparts
repository in reviewboard. So, what is the current way of submitting patch to
any of frameworks libs?
Cheers
Michal
___
Kde-frameworks-devel mailing list
Kde-framewo
Hi there,
I was wondering if there is a recommended migration path from
KDE4_ADD_APP_ICON cmake makro.
Cheers
Michal
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
of December 2013 14:56:46 Aleix Pol wrote:
> On Mon, Dec 16, 2013 at 5:18 PM, Michal Humpula
wrote:
> > Hi there,
> >
> > have a small glitch with icon loading on frameworks. If I understand
> > correctly, the migration path for KIcon is QIcon::fromTheme, right?
> >
Hi there,
have a small glitch with icon loading on frameworks. If I understand
correctly, the migration path for KIcon is QIcon::fromTheme, right?
Unfortunately this is giving me empty results, which might be caused by
QIcon::themeName() giving me empty string. If I configure the theme manually
27 matches
Mail list logo
