Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

2016-11-07 Thread Michael Stemle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/#review100694 --- Ship it! Ship It! - Michael Stemle On Nov. 7, 2016, 6

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

2016-11-06 Thread Michael Stemle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/#review100652 --- Ship it! Ship It! - Michael Stemle On Nov. 6, 2016

Re: Review Request 129257: [KNewStuff] Make it possible to query installed entries

2016-11-05 Thread Michael Stemle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129257/#review100624 --- Ship it! Ship It! - Michael Stemle On Oct. 25, 2016

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

2016-11-05 Thread Michael Stemle
(line 169) <https://git.reviewboard.kde.org/r/129186/#comment67544> PEDANTIC QUESTION: Why do we `resize()` rather than just using `QByteArray((values.size() + 1) * 5, '\0')`? I get that it's effectively the same thing, but it seems like it would be more concise to use th

Re: Review Request 129110: Generate the icon into the appstream file

2016-10-05 Thread Michael Stemle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129110/#review99804 --- Ship it! Ship It! - Michael Stemle On Oct. 6, 2016, 12

Re: Review Request 129106: Give a different name to Breeze Dark icon theme

2016-10-05 Thread Michael Stemle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129106/#review99803 --- Ship it! Ship It! - Michael Stemle On Oct. 5, 2016, 1

Re: Review Request 129106: Give a different name to Breeze Dark icon theme

2016-10-05 Thread Michael Stemle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129106/#review99801 --- +1 - Michael Stemle On Oct. 5, 2016, 1:21 p.m., Aleix Pol

Re: Review Request 129110: Generate the icon into the appstream file

2016-10-05 Thread Michael Stemle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129110/#review99800 --- +1 - Michael Stemle On Oct. 6, 2016, 12:54 a.m., Aleix