D12320: add ability to read embedded cover files

michaelh added a comment. Too bad `ffmpegthumbs` is for videos only. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun

D12320: add ability to read embedded cover files

michaelh added a comment. https://cgit.kde.org/ffmpegthumbs.git/ should be useable. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun

D12156: implement reading of rating tag

michaelh added a comment. In D12156#249971 , @astippich wrote: > In D12156#249951 , @michaelh wrote: > > > It's for elisa I guess, could you please elaborate how POPM/RATING is going to be used and

D12233: Avoid manipulation of lists with quadratic complexity

michaelh updated this revision to Diff 32595. michaelh added a comment. - Indent REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12233?vs=32322&id=32595 BRANCH remove-if (branched from master) REVISION DETAIL https://phabricator.kde.org/D12233 AFFECTED

D12156: implement reading of rating tag

michaelh added a comment. It's for elisa I guess, could you please elaborate how POPM/RATING is going to be used and why xattr are not applicable? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: bruns, #frameworks, a

D10694: epubextractor: Handle multiple subjects better

michaelh added inline comments. INLINE COMMENTS > bruns wrote in epubextractor.cpp:85 > I think we should add each title individually (there may be one per language). > > Dito for all other properties, see below. I think we should port away from libepub. Multiple titles result in one ';'-joine

D12342: Update CMakeLists.txt

michaelh added a reviewer: elvisangelaccio. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D12342 To: michaelh, #baloo, #dolphin, #frameworks, elvisangelaccio Cc: ashaposhnikov, astippich, spoorun

D12222: baloodb: Use complete access filtering for all outputs

michaelh marked an inline comment as done. michaelh added a comment. I'm sorry for making so much noise with all those stupid mistakes. It's probably best for me to let this rest for a few days, relax a little and gain some distance. REPOSITORY R293 Baloo REVISION DETAIL https://phabric

D12222: baloodb: Use complete access filtering for all outputs

michaelh updated this revision to Diff 32580. michaelh added a comment. - That was no typo REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1?vs=32579&id=32580 BRANCH sanitize-dry (branched from master) REVISION DETAIL https://phabricator.kde.org/D122

D12222: baloodb: Use complete access filtering for all outputs

michaelh updated this revision to Diff 32579. michaelh added a comment. - Correct typo REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1?vs=32578&id=32579 BRANCH sanitize-dry (branched from master) REVISION DETAIL https://phabricator.kde.org/D1

D12222: baloodb: Use complete access filtering for all outputs

michaelh updated this revision to Diff 32578. michaelh marked 5 inline comments as done. michaelh added a comment. - Revert most previous changes - Use `isMounted()` and `isObscured()` - Remove documents recursively REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.k

D11753: baloodb: Add clean command

This revision was automatically updated to reflect the committed changes. Closed by commit R293:675d989823ec: baloodb: Add clean command (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11753?vs=32320&id=32565 REVISION DETAIL https://pha

D12197: autotests: Test for multiple values

michaelh requested review of this revision. michaelh marked an inline comment as done. michaelh added inline comments. INLINE COMMENTS > bruns wrote in multivaluetest.cpp:91 > Again, I prefer this notation versus `expectedresult` > You can make this somewhat shorter by using > `QVariantList{QSt

D12197: autotests: Test for multiple values

michaelh added a reviewer: bruns. REPOSITORY R286 KFileMetaData BRANCH multi-value-test (branched from master) REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo, #frameworks, mgallien, bruns Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun

D12197: autotests: Test for multiple values

michaelh updated this revision to Diff 32559. michaelh added a comment. - Rebase - Apply some suggested changes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12197?vs=32122&id=32559 BRANCH multi-value-test (branched from master) REVISION DETAIL

D11489: Make concatenated strings wrappable

This revision was automatically updated to reflect the committed changes. Closed by commit R286:c30204f7b9c0: Make concatenated strings wrappable (authored by michaelh). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11489?vs=29926&id=32556 REVISION DET

D12108: ffmpegextractor: Silence deprecation warnings

michaelh added a comment. In D12108#249246 , @mgallien wrote: > Thanks. > > I did try to fix it some months ago but did not finished however I noticed that there is no automatic tests for it. Do you have time to work on some ? It's al

D12108: ffmpegextractor: Silence deprecation warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R286:037208a787e0: ffmpegextractor: Silence deprecation warnings (authored by michaelh). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12108?vs=32552&id=32553 RE

D12108: ffmpegextractor: Silence deprecation warnings

michaelh updated this revision to Diff 32552. michaelh edited the test plan for this revision. michaelh added a comment. -Rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12108?vs=31872&id=32552 BRANCH ffmpeg_deprecated (branched from master)

D12342: Update CMakeLists.txt

michaelh added inline comments. INLINE COMMENTS > CMakeLists.txt:4 > +set(KF5_VERSION "5.45.0") # handled by release scripts > +#TODO: Verify it is handled by release scripts > + There is not indication that `baloo-widgets` is an Application. Yet it resides in the `kde/applications` folder. Sho

D12342: Update CMakeLists.txt

michaelh added a dependent revision: D11245: infopanel: Add choice of date display formats. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D12342 To: michaelh, #baloo, #dolphin, #frameworks Cc: ashaposhnikov, astippich, spoorun

D12342: Update CMakeLists.txt

michaelh created this revision. michaelh added reviewers: Baloo, Dolphin, Frameworks. Restricted Application added a project: Baloo. michaelh requested review of this revision. REVISION SUMMARY Update CMakeLists.txt taking `kwidgetsaddons` as a template TEST PLAN make clean && make Dolphin

D12222: baloodb: Use complete access filtering for all outputs

michaelh marked 6 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D1 To: michaelh, #baloo, #frameworks Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun

D12222: baloodb: Use complete access filtering for all outputs

michaelh marked an inline comment as done. michaelh added inline comments. INLINE COMMENTS > databasesanitizer.cpp:196 > + summary.accessible += (info.deviceId == > deviceId && info.accessible ? 1 : 0); > + return info.deviceId == deviceI

D12222: baloodb: Use complete access filtering for all outputs

michaelh updated this revision to Diff 32426. michaelh added a comment. - Filter by device id REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1?vs=32422&id=32426 BRANCH sanitize-dry (branched from master) REVISION DETAIL https://phabricator.kde.org/D

D12222: baloodb: Use complete access filtering for all outputs

michaelh added a comment. I went I little overboard with `remove_if` and had to repair. Device filtering is also broken see inline comment. INLINE COMMENTS > databasesanitizer.cpp:160 > const QByteArray rootPath = > QFile::encodeName(vol.rootPath()); > con

D12222: baloodb: Use complete access filtering for all outputs

michaelh updated this revision to Diff 32422. michaelh added a comment. - Apply suggested changes - Correct summary error - Repair cleaning - Comment some decisions REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1?vs=32321&id=32422 BRANCH sanitiz

D12233: Avoid manipulation of lists with quadratic complexity

michaelh marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: michaelh, #baloo Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12233: Avoid manipulation of lists with quadratic complexity

michaelh marked 4 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: michaelh, #baloo Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12233: Avoid manipulation of lists with quadratic complexity

michaelh updated this revision to Diff 32322. michaelh added a comment. - Apply suggested change REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12233?vs=32285&id=32322 BRANCH remove-if (branched from master) REVISION DETAIL https://phabricator.kde.org/D

D12222: baloodb: Use complete access filtering for all outputs

michaelh added inline comments. INLINE COMMENTS > databasesanitizer.cpp:180 > + [deviceId,&summary] (const FileInfo& info) { > + summary.accessible += info.accessible; > + return info.id == deviceId; How can this

D12222: baloodb: Use complete access filtering for all outputs

michaelh updated this revision to Diff 32321. michaelh added a comment. - Use remove_if REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1?vs=32176&id=32321 BRANCH sanitize-dry (branched from master) REVISION DETAIL https://phabricator.kde.org/D1

D12222: baloodb: Use complete access filtering for all outputs

michaelh added inline comments. INLINE COMMENTS > bruns wrote in databasesanitizer.cpp:252 > If ignoredDevices is a Set/List, you can do a filter pass over the fileList > first. > > auto& fileList = listResult.first; > auto tail = fileList.end(); > for (auto deviceId : ignoredDevices) { >

D11753: baloodb: Add clean command

michaelh added inline comments. INLINE COMMENTS > bruns wrote in databasesanitizer.cpp:173 > Pass in a List/Set of deviceIds, and return the same type. Your suggestion in D1 can be reused. I'll do it there. > bruns wrote in databasesanitizer.cpp:187 > A

D11753: baloodb: Add clean command

michaelh updated this revision to Diff 32320. michaelh marked 17 inline comments as done. michaelh added a comment. - Apply suggested changes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11753?vs=32255&id=32320 BRANCH sanitize-clean (branched from master

D12233: Avoid manipulation of lists with quadratic complexity

michaelh added inline comments. INLINE COMMENTS > bruns wrote in fileindexscheduler.cpp:148 > You can put the lambda into the `remove_if` invocation: > > auto tail = std::remove_if(list.begin(), list.end(), > [&dir](const QString& file) { >

D12233: Avoid manipulation of lists with quadratic complexity

michaelh updated this revision to Diff 32285. michaelh added a comment. - Include omissions - Const! REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12233?vs=3&id=32285 BRANCH remove-if (branched from master) REVISION DETAIL https://phabricator.kde

D12226: balooshow: Colorize only when attached to terminal

This revision was automatically updated to reflect the committed changes. Closed by commit R293:094d6e90d4c0: balooshow: Colorize only when attached to terminal (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12226?vs=32256&id=32257 REVIS

D12226: balooshow: Colorize only when attached to terminal

michaelh updated this revision to Diff 32256. michaelh added a comment. - Rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12226?vs=32193&id=32256 BRANCH no-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D12226 AFFECTED F

D11753: baloodb: Add clean command

michaelh added inline comments. INLINE COMMENTS > bruns wrote in databasesanitizer.cpp:344 > do the calls to m_transaction using a wrapper, e.g. > `DatabaseSanitizer::removeDocument(info.id)` I'm assuming you meant `DatabaseSanitizerImpl::removeDocument(info.id)`. If you meant `DatabaseSanitiz

D11753: baloodb: Add clean command

michaelh updated this revision to Diff 32255. michaelh added a comment. - Wrap transaction operations REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11753?vs=32254&id=32255 BRANCH sanitize-clean (branched from master) REVISION DETAIL https://phabricator

D11753: baloodb: Add clean command

michaelh updated this revision to Diff 32254. michaelh added a comment. - Remove unrelated whitespace change REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11753?vs=32201&id=32254 BRANCH sanitize-clean (branched from master) REVISION DETAIL https://phab

D12233: Avoid manipulation of lists with quadratic complexity

michaelh added a comment. If this is correct, I can extend. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: michaelh, #baloo Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12233: Avoid manipulation of lists with quadratic complexity

michaelh created this revision. michaelh added a reviewer: Baloo. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. REVISION SUMMARY When removing items from lists Baloo uses an implementat

D12233: Avoid manipulation of lists with quadratic complexity

michaelh added a task: T8502: Avoid manipulation of lists with quadratic complexity. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: michaelh, #baloo Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12135: Allow disabling of CoW to fail when not supported by filesystem

michaelh added a comment. In D12135#246895 , @bcooksley wrote: > If there are multiple reviewers then approval of all reviewers is required which is why your approval was also needed Good to know, thanks. REPOSITORY R293 Baloo REVISI

D12135: Allow disabling of CoW to fail when not supported by filesystem

michaelh added a comment. In D12135#246831 , @bcooksley wrote: > The original author/submitter of a diff for review isn't able to approve their own review, which is why Stefan wasn't permitted to approve this diff. Yes, thanks. That's th

D12044: baloodb: Improve interface

michaelh edited dependencies, added: D1: baloodb: Use complete access filtering for all outputs; removed: D11753: baloodb: Add clean command. REPOSITORY R293 Baloo BRANCH sanitize-improve-ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D12044 To: michaelh, #balo

D11753: baloodb: Add clean command

michaelh removed a dependent revision: D12044: baloodb: Improve interface. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11753 To: michaelh, #baloo, #frameworks, bruns Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D12222: baloodb: Use complete access filtering for all outputs

michaelh added a dependent revision: D12044: baloodb: Improve interface. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D1 To: michaelh, #baloo, #frameworks Cc: ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12044: baloodb: Improve interface

michaelh updated this revision to Diff 32212. michaelh added a comment. This revision is now accepted and ready to land. - Rebase on D12044 REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12044?vs=31684&id=32212 BRANCH s

D11753: baloodb: Add clean command

michaelh updated this revision to Diff 32201. michaelh added a comment. - Rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11753?vs=32175&id=32201 BRANCH sanitize-clean (branched from master) REVISION DETAIL https://phabricator.kde.org/D11753 AFFE

D11820: Handle properties with multiple values

michaelh added a comment. Surprising! master F5808891: cur-noidx.png patch F5808893: patch.png REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11820 To: michaelh, #baloo, #frame

D12047: Avoid crash when reading corrupt data from document terms db

michaelh added a comment. > Corrupt the database As described in BUG: 392877? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12047 To: bruns, #baloo, michaelh, ngraham Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12226: balooshow: Colorize only when attached to terminal

michaelh created this revision. michaelh added a reviewer: Baloo. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. TEST PLAN $ balooshow otto.txt $ balooshow otto.txt | head -n 12 R

D12114: Revive 'Description' property

michaelh planned changes to this revision. michaelh added a comment. Create cross extractor test REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12114 To: michaelh, #baloo, #frameworks Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11882: autotests: Use built executable instead of installed

michaelh added a comment. In D11882#245719 , @bruns wrote: > Maybe we can add a trivial dummy extractor which is used in unittests, but not anywhere else. It could e.g. return the current date, compilation timestamp (i.e. __DATE__), and the KF v

D12222: baloodb: Use complete access filtering for all outputs

michaelh added inline comments. INLINE COMMENTS > main.cpp:161 > return i18n("\n\nCommands:\n%1", allCommandsStr); > } > Ideas for better formatting this are welcome. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D1 To: michaelh, #baloo, #frameworks Cc:

D11820: Handle properties with multiple values

michaelh added a subscriber: bruns. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11820 To: michaelh, #baloo, #frameworks Cc: bruns, astippich, mgallien, elvisangelaccio, ashaposhnikov, spoorun, alexeymin

D12135: Allow disabling of CoW to fail when not supported by filesystem

michaelh accepted this revision. michaelh added a comment. This revision is now accepted and ready to land. Of course, but what's the logic here? Does it have to be accepted by a member of Baloo other than you? If I had known REPOSITORY R293 Baloo BRANCH master REVISION DETAIL ht

D12192: Decode more documentUrls

michaelh added a comment. In D12192#246449 , @bruns wrote: > Can you add a little bit more info to the commit message, e.g. an example how the output looks before and after? I don't know... I realized the necessity to `QFile::decodeNam

D12192: Decode more documentUrls

michaelh edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12192 To: michaelh, #baloo, bruns Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11820: Handle properties with multiple values

michaelh added a comment. In D11820#246525 , @astippich wrote: > Sorry for the late answer. Isn't this already handled in widgetfactory.cpp toString function (line 87)? During my testing with multiple values I've never had issues with baloo-wid

D12197: autotests: Test for multiple values

michaelh edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo, #frameworks, mgallien Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11820: Handle properties with multiple values

michaelh planned changes to this revision. michaelh added a comment. Due to a bug in calligra `test.odt` file is broken. see D11971 . REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11820 To: michaelh, #baloo, #frameworks Cc

D12222: baloodb: Use complete access filtering for all outputs

michaelh added a task: T8250: Sanitize the database. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D1 To: michaelh, #baloo, #frameworks Cc: ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11745: databasesanitizer: Use flags for filtering

This revision was automatically updated to reflect the committed changes. Closed by commit R293:6fb268be2c42: databasesanitizer: Use flags for filtering (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11745?vs=32147&id=32178 REVISION DETA

D11753: baloodb: Add clean command

michaelh added inline comments. INLINE COMMENTS > bruns wrote in databasesanitizer.cpp:166 > Why do you remove the private: here? 340: m_pimpl->m_transaction->removeDocument(info.id); and more > bruns wrote in databasesanitizer.cpp:343 > remove `sep`, use `QStringLiteral(" device: %1") instead

D12222: baloodb: Use complete access filtering for all outputs

michaelh edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D1 To: michaelh, #baloo, #frameworks Cc: ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11753: baloodb: Add clean command

michaelh added a dependent revision: D1: baloodb: Use complete access filtering for all outputs. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11753 To: michaelh, #baloo, #frameworks, bruns Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngr

D12222: baloodb: Use complete access filtering for all outputs

michaelh added a dependency: D11753: baloodb: Add clean command. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D1 To: michaelh, #baloo, #frameworks Cc: ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12222: baloodb: Use complete access filtering for all outputs

michaelh created this revision. michaelh added reviewers: Baloo, Frameworks. Restricted Application added projects: Frameworks, Baloo. michaelh requested review of this revision. REVISION SUMMARY Add `mounted-only` option to 'list' and 'devices' command Use a common function to determine if a

D11745: databasesanitizer: Use flags for filtering

michaelh added inline comments. INLINE COMMENTS > bruns wrote in databasesanitizer.cpp:250 > This line definitely needs a comment why this is here added in D11753 REPOSITORY R293 Baloo BRANCH sanitize-enums (branched from master) REVISION DETAIL http

D11753: baloodb: Add clean command

michaelh updated this revision to Diff 32175. michaelh added a comment. - Improve access filtering REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11753?vs=32105&id=32175 BRANCH sanitize-clean (branched from master) REVISION DETAIL https://phabricator.kd

D11745: databasesanitizer: Use flags for filtering

michaelh updated this revision to Diff 32147. michaelh added a comment. - Ignore tmpfs devices REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11745?vs=32104&id=32147 BRANCH sanitize-enums (branched from master) REVISION DETAIL https://phabricator.kde.or

D12206: Don't show "Open With" for folders, as was apparently originally intended

michaelh added a comment. In D12206#246284 , @ngraham wrote: > In D12206#246282 , @michaelh wrote: > > > "Open with VLC" is of course nonsense. > > > Huh? Not sure I understand. The def

D12206: Don't show "Open With" for folders, as was apparently originally intended

michaelh added a comment. In D12206#246284 , @ngraham wrote: > In D12206#246282 , @michaelh wrote: > > > I find "Open with..." for folders useful. > > > What apps do you typically open fo

D12206: Don't show "Open With" for folders, as was apparently originally intended

michaelh added a comment. I find "Open with..." for folders useful. "Open with VLC" is of course nonsense. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206 To: ngraham, #frameworks, rkflx Cc: michaelh, ngraham, bruns

D12017: taglibextractortest: Test for multiple values

michaelh abandoned this revision. michaelh added a comment. Superseded by D12197 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12017 To: michaelh Cc: #frameworks, astippich, mgallien, ashaposhnikov, michaelh, spoorun, ngr

D10694: epubextractor: Handle multiple subjects better

michaelh updated this revision to Diff 32124. michaelh edited the summary of this revision. michaelh added a comment. Remove tests from epubextractortest use multivaluetest instead Depends on D12197 REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDA

D10694: epubextractor: Handle multiple subjects better

michaelh edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D10694 To: michaelh, mgallien, dfaure Cc: bruns, astippich, #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, isidorov, firef, ngraham, andrebarros, alexeymin

D10694: epubextractor: Handle multiple subjects better

michaelh added a dependency: D12197: autotests: Test for multiple values. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D10694 To: michaelh, mgallien, dfaure Cc: bruns, astippich, #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, isidorov, firef, ngr

D12197: autotests: Test for multiple values

michaelh added a dependent revision: D10694: epubextractor: Handle multiple subjects better. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo, #frameworks, mgallien Cc: ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymi

D12197: autotests: Test for multiple values

michaelh added inline comments. INLINE COMMENTS > multivaluetest.cpp:86 > + > +// Provide Property::Subject only when there is exactly one dc:subject > +QTest::newRow("epub/1 subject") The following behaviours need to be discussed. They are just suggestions. REPOSITORY R286 KFileMetaD

D12197: autotests: Test for multiple values

michaelh created this revision. michaelh added reviewers: Baloo, Frameworks, mgallien. Restricted Application added projects: Frameworks, Baloo. michaelh requested review of this revision. REVISION SUMMARY Prepare sample files with multiple tags - epub: 'dc:subject' - office docs: keyword

D11587: [WIP] autotests: Introduce TermGeneratorTestUTF

michaelh added a subscriber: bruns. michaelh added a comment. @bruns: `autotests/unit/engine/queryparsertest.cpp` and `autotests/unit/engine/termgeneratortest.cpp` are encoded with iso-8859-15. Maybe you're able to convert them to utf-8. Even with a lot of help I couldn't. Please give it a

D11587: [WIP] autotests: Introduce TermGeneratorTestUTF

michaelh edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11587 To: michaelh, #baloo, #frameworks Cc: ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12192: Decode more documentUrls

michaelh added inline comments. INLINE COMMENTS > transaction.cpp:469 > for (quint64 id: allIds) { > QByteArray url = docUrlDb.get(id); > if (url.isEmpty()) { For your convenience REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12192 To: michaelh,

D12192: Decode more documentUrls

michaelh created this revision. michaelh added a reviewer: Baloo. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. TEST PLAN make test REPOSITORY R293 Baloo BRANCH file-encoding (bra

D12044: baloodb: Improve interface

michaelh planned changes to this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12044 To: michaelh, #baloo, ngraham Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11753: baloodb: Add clean command

michaelh updated this revision to Diff 32105. michaelh added a comment. - Adapt to upstream changes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11753?vs=31208&id=32105 BRANCH sanitize-clean (branched from master) REVISION DETAIL https://phabricator.k

D11745: databasesanitizer: Use flags for filtering

michaelh updated this revision to Diff 32104. michaelh added a comment. - Adapt to upstream changes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11745?vs=32014&id=32104 BRANCH sanitize-enums (branched from master) REVISION DETAIL https://phabricator.k

D12165: Use QStorageInfo instead of a homegrown implementation

michaelh accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D12165 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12005: Fix merging of terms in the AdvancedQueryParser

michaelh accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH baloo_term_cleanup_2 REVISION DETAIL https://phabricator.kde.org/D12005 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D12138: Remove FSUtils::getDirectoryFileSystem

michaelh accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH disble_cow_unconditionally REVISION DETAIL https://phabricator.kde.org/D12138 To: bruns, #baloo, #freebsd, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun,

D12135: Allow disabling of CoW to fail when not supported by filesystem

michaelh added a comment. +1 LGTM REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12135 To: bruns, #baloo, adridg, #frameworks, michaelh Cc: adridg, #freebsd, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11882: autotests: Use built executable instead of installed

michaelh added a comment. Ping REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11882 To: michaelh, elvisangelaccio, #baloo, #frameworks Cc: alexeymin, ashaposhnikov, astippich, spoorun

D12145: autotests: Do not use QScopedPointer for plugins

michaelh updated this revision to Diff 32052. michaelh added a comment. - Rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12145?vs=31966&id=32052 BRANCH plugin-simple (branched from master) REVISION DETAIL https://phabricator.kde.org/D1214

D12145: autotests: Do not use QScopedPointer for plugins

This revision was automatically updated to reflect the committed changes. Closed by commit R286:8b8857cb6bc3: autotests: Do not use QScopedPointer for plugins (authored by michaelh). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12145?vs=32052&id=32053

D12029: taglibextractor: Fix empty genre bug

This revision was automatically updated to reflect the committed changes. Closed by commit R286:d66b9853b55d: taglibextractor: Fix empty genre bug (authored by michaelh). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12029?vs=32050&id=32051 REVISION DE

  1   2   3   4   5   6   7   >