D20169: Add profile support interface for TerminalInterface

2019-06-02 Thread Maximilian Schiller
mschiller added a comment. Oh sry, I wasn't aware of that. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-06-02 Thread Maximilian Schiller
mschiller added a comment. ping REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-05-14 Thread Maximilian Schiller
mschiller updated this revision to Diff 58095. mschiller added a comment. - Remove install of profileinterface REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20169?vs=58094&id=58095 BRANCH terminal-interface-profiles (branched from master) REVISION DETAI

D20169: Add profile support interface for TerminalInterface

2019-05-14 Thread Maximilian Schiller
mschiller updated this revision to Diff 58094. mschiller added a comment. Move the interface to TerminalInterfaceV2 REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20169?vs=56697&id=58094 BRANCH terminal-interface-profiles (branched from master) REVISION

D20169: Add profile support interface for TerminalInterface

2019-05-10 Thread Maximilian Schiller
mschiller added a comment. Ping REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-04-22 Thread Maximilian Schiller
mschiller updated this revision to Diff 56697. mschiller added a comment. change KDEPARTS to KPARTS REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20169?vs=56696&id=56697 BRANCH terminal-interface-profiles (branched from master) REVISION DETAIL https:/

D20169: Add profile support interface for TerminalInterface

2019-04-22 Thread Maximilian Schiller
mschiller marked 3 inline comments as done. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-04-22 Thread Maximilian Schiller
mschiller updated this revision to Diff 56696. mschiller added a comment. Remove getProfilePath and remove get prefixes REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20169?vs=56672&id=56696 BRANCH terminal-interface-profiles (branched from master) REVIS

D20169: Add profile support interface for TerminalInterface

2019-04-21 Thread Maximilian Schiller
mschiller added a comment. > wrt getProfilePath: what if an application does not store a profile as single filename, for example as directory, or even stored e.g. in a DB? maybe it would be better to have this as property of a profile Yeah Konsole Profiles seem to already have a path pro

D20169: Add profile support interface for TerminalInterface

2019-04-21 Thread Maximilian Schiller
mschiller updated this revision to Diff 56672. mschiller edited the summary of this revision. mschiller added a comment. Move the profile support to different class REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20169?vs=55201&id=56672 BRANCH terminal-int

D20169: Add profile support interface for TerminalInterface

2019-04-21 Thread Maximilian Schiller
mschiller edited the summary of this revision. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-04-01 Thread Maximilian Schiller
mschiller added a reviewer: hindenburg. mschiller removed a subscriber: kde-frameworks-devel. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg Cc: michaelh, ngraham, bruns, kde-frameworks-devel

D20169: Add profile support interface for TerminalInterface

2019-04-01 Thread Maximilian Schiller
mschiller created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mschiller requested review of this revision. REVISION SUMMARY This enables handling profiles for the active konsolepart and has to be implemented by konsole. REPOSITORY R306