Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

> On Feb. 28, 2014, 3:41 p.m., Matthew John Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what h

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

anging the behaviour of the constructor. - Matthew John Dawson On Feb. 27, 2014, 4:18 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 115963: Fix interference from kdeplatformtheme into unittests

. src/core/ksharedconfig.cpp <https://git.reviewboard.kde.org/r/115963/#comment35846> Nitpick: please use Q_NULLPTR instead of 0 here. - Matthew John Dawson On Feb. 27, 2014, 3:01 p.m., David Faure wrote: > > ---

Re: Review Request 115960: Add sharedConfig() accessor, to avoid manipulating a raw KConfig * as returned by config().

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115960/#review50833 --- Ship it! Ship It! - Matthew John Dawson On Feb. 23, 2014

Re: Review Request 115963: KSharedConfig: Fix interference from kdeplatformtheme into unittests

org/r/115963/#comment35595> Can you also please clear GlobalSharedConfigList::mainConfig please? It should be reset anyways if a config is opened, but I rather be safe then sorry. - Matthew John Dawson On Feb. 23, 2014, 6:54 a.m., David Faure

Re: Review Request 115832: Print the diff to stdout on comparison failure

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115832/#review50120 --- Ship it! Looks good, thanks! - Matthew John Dawson On Feb

Re: Review Request 115635: Make kconfig_compiler signals actually useful

src/kconfig_compiler/kconfig_compiler.cpp <https://git.reviewboard.kde.org/r/115635/#comment35233> Can you please add a newline before this line? It just separates the concerns :) - Matthew John Dawson On Feb. 17, 2014, 10:44 a.m., Alexander Rich

Re: Review Request 115634: Add kconfig_compiler autotest that checks whether signals are emitted

> On Feb. 17, 2014, 1:39 a.m., Matthew John Dawson wrote: > > autotests/kconfig_compiler/kconfigcompiler_test_signals.cpp, line 153 > > <https://git.reviewboard.kde.org/r/115634/diff/1/?file=243130#file243130line153> > > > > As this appears to preform the sa

Re: Review Request 115634: Add kconfig_compiler autotest that checks whether signals are emitted

autotests/kconfig_compiler/signals_test.kcfg <https://git.reviewboard.kde.org/r/115634/#comment35121> Whitespace :) - Matthew John Dawson On Feb. 10, 2014, 7:47 p.m., Alexander Richardson wrote: > > --- > This is an aut

Re: Review Request 115635: Make kconfig_compiler signals actually useful

iler.cpp <https://git.reviewboard.kde.org/r/115635/#comment35116> This change breaks the kconfigcompiler_test, as the reference file for signals (autotests/kconfig_compiler/test_signal.cpp.ref) no longer matches. Please update the reference file to match, as the changes are wanted :) - Matt