D12696: Use the new uds implementation

martinkostolny added a comment. I've managed to get more info about the crash also by following this guide: https://community.kde.org/Guidelines_and_HOWTOs/Debugging/Debugging_IOSlaves#Attaching_gdb_to_an_io-slave Here is backtrace from gdb: F5905112: udsentry_bt.txt

D12696: Use the new uds implementation

martinkostolny added a comment. Thanks for guidance regarding getting additional debug info. I'll try to get it soon :). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12696 To: jtamate, dfaure, #frameworks Cc: martinkostolny, kde-frameworks-devel, bruns, michaelh, ngr

D12696: Use the new uds implementation

martinkostolny added a comment. Hi! Probably after this commit sftp slave crashes when showing a directory with links. Please see my code comment. Can you also reproduce or is it on my side only? Here is a crash log: log_kio_sftp: readdir: "/mnt/ext/files" , details: "2" ASS

D11278: [KateCompletionWidget] Create configuration interface on demand

martinkostolny added a comment. Hi! After this commit I don't see a completion dropdown anymore. And after it should be opened an one presses backspace, kate or kwrite crashes. Simple example: 1. open empty Kate 2. write "", enter, "", backspace I will provide backtrace on

Re: Fallback Icon Theme

issing non-standard icon images for hicolor theme in Krusader. If there is a better way of solving our situation, please tell us :). Thanks! Martin On sobota 3. března 2018 12:16:17 CET Albert Astals Cid wrote: > El dijous, 1 de març de 2018, a les 23:37:14 CET, Martin Kostolný va esc

Fallback Icon Theme

Hi! We at Krusader would like to address a rather standard issue of applications - missing icons. And we would like an opinion of you as experts :). Starter discussion (which led in here) is on Krusader's phabricator: https://phabricator.kde.org/D10352 Krusader is using a lot of icons existing

D7829: KKeyServer: fix handling of Meta+Shift+Print, Alt+Shift+arrowkey etc.

martinkostolny added a comment. > I hope you remembered to revert locally the commit. Of course I didn't, sorry. But now I did. I reverted the KGlobalAccel commit, tested that previous bugs reappeared, then applied this patch and tested again - bugs are gone. So now it is properly t

D7829: Fix kglobalaccel regression on Alt+Shift+arrowkey.

martinkostolny added a comment. I've tested meta+shift+arrow, alt+shift+arrow, meta+shift+PrtSc and they are working for me, thanks! So far I didn't notice any regressions. I'll keep this version around and will report problem if I see one. Unfortunately I'm unable to properly review the co

D6233: KKeyServer: fix handling of KeypadModifier.

martinkostolny added a comment. Sorry, to be a bit late, but after updating to kwindowsystem 5.38, global shortcuts "meta+shift+" and "alt+shift+" stopped working on my system (Arch Linux). They can be configured no-problem (they are recognized and saved in configuration), but they do nothin

D5394: KAuth integration in document saving - vol. 2

This revision was automatically updated to reflect the committed changes. Closed by commit R39:f7a9573d973e: KAuth integration in document saving - vol. 2 - various security improvements (authored by martinkostolny). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5394?vs=14013&id=14020#to

D5394: KAuth integration in document saving - vol. 2

martinkostolny added a comment. One more thing I've changed in the last diff: When creating a new file in privileged directory, the file is then set to be readable by group and others. This is because kate wouldn't be able to read it later with regular user who managed to create it in the f

D5394: KAuth integration in document saving - vol. 2

martinkostolny updated this revision to Diff 14013. martinkostolny added a comment. Thanks for noticing the security issues! And sorry for the pause. Here is an updated diff which should ensure, QFile is using relative path. I've managed to reduce the use of absolute paths to this state - str

D5394: KAuth integration in document saving - vol. 2

martinkostolny updated this revision to Diff 13621. martinkostolny added a comment. Understood and implemented by switching to "current directory" where the final rename is taking place. This way I could use filenames only rename. Hopefully I didn't miss anything. One other issue I've no

D5394: KAuth integration in document saving - vol. 2

martinkostolny marked 2 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5394 To: martinkostolny, #ktexteditor, fvogt Cc: elvisangelaccio, aacid, ivan, lbeltrame, fvogt, apol, anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, davidedmun

D5394: KAuth integration in document saving - vol. 2

martinkostolny updated this revision to Diff 13539. martinkostolny added a comment. Thanks for noticing all these security issues! Both issues should now be fixed. Regarding the KAuth dialog, I agree, but couldn't find a simple way of propagating additional info to the dialog. I didn

D5394: KAuth integration in document saving - vol. 2

martinkostolny updated this revision to Diff 13517. martinkostolny added a comment. Updated diff based on Fabian's advisory. Thanks, Fabian! I've implemented the first option: checksum -> tempfile1 -> read in privileged action -> checksum -> tempfile2 -> permissions -> rename. It works w

D5394: KAuth integration in document saving - vol. 2

martinkostolny added a comment. One more question - is it necessary to show the checksum to the user? I don't see what it would be good for, but I'm probably missing something. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5394 To: martinkostolny, #ktexteditor,

D5394: KAuth integration in document saving - vol. 2

martinkostolny added a comment. Sorry for answering after a longer time. I need to be sure I understand everything correctly: ad checksum: I think it would be good to revert to previous code and start from ther (to ensure writing only once and not over d-bus): 1. create a temp file

D4847: KAuth integration in document saving

martinkostolny added a comment. I've created a follow-up diff https://phabricator.kde.org/D5394 and added every subscriber from here. I hope it wasn't too invasive of me. > Once implemented, it will be possible to get kauth for free when calling (for example) KIO::move(). Not sure if tha

D5394: KAuth integration in document saving - vol. 2

martinkostolny created this revision. martinkostolny added projects: KTextEditor, Frameworks. Restricted Application added subscribers: Frameworks, kwrite-devel. REVISION SUMMARY This is a follow-up of https://phabricator.kde.org/D4847, trying to fix issues pointed out by Fabian: - send th

D4847: KAuth integration in document saving

This revision was automatically updated to reflect the committed changes. Closed by commit R39:ae60880c5f9b: KAuth integration in document saving (authored by martinkostolny). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4847?vs=12941&id=13049 REVISION D

D4847: KAuth integration in document saving

martinkostolny added a comment. Sure, no problem :). REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4847 To: martinkostolny, dhaumann, #ktexteditor, dfaure Cc: apol, dfaure, anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, davidedmundson, palant, kwrite-

D4847: KAuth integration in document saving

martinkostolny marked 3 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4847 To: martinkostolny, dhaumann, #ktexteditor Cc: apol, dfaure, anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, davidedmundson, palant, kwrite-devel, #framewor

D4847: KAuth integration in document saving

martinkostolny updated this revision to Diff 12941. martinkostolny added a comment. Updating diff with refinements based on David's insights, thanks David! Regarding static slot, it was quite convenient to call it statically in unit test mode and it works. So I left it there like this. I

D4847: KAuth integration in document saving

martinkostolny added a comment. > it should work as it is now, or I am mistaken? I believe the latest diff update is indeed making use of atomic rename. I will roughly summarize what the code currently does: 1. First try to open QSaveFile, if succeeded -> finish writing as before the

D4847: KAuth integration in document saving

martinkostolny added a comment. I know there is a lot of other stuff going on. So just to be sure: am I supposed to do something else - are we waiting for me? Also if I'm too rookie for this, feel free to commandeer the revision. :) REPOSITORY R39 KTextEditor REVISION DETAIL https:/

D4847: KAuth integration in document saving

martinkostolny updated this revision to Diff 12309. martinkostolny added a comment. Good point! I was about to say that the target folder is in most cases non-writable without elevated privileges. But we can actually use KAuth action twice, for 2 simple jobs: 1. Create temporary file rig

D4847: KAuth integration in document saving

martinkostolny marked 7 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4847 To: martinkostolny, dhaumann, #ktexteditor Cc: apol, dfaure, anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, davidedmundson, palant, kwrite-devel, #framewor

D4847: KAuth integration in document saving

martinkostolny updated this revision to Diff 12272. martinkostolny added a comment. Thanks a sorry for all the rookie mistakes. I tried to fix the problems You mentioned: - QT->Qt - get rid of useless streams - no more setting permissions and sync-to-disk when using QSaveFile - usin

D4847: KAuth integration in document saving

martinkostolny marked 4 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4847 To: martinkostolny, dhaumann, #ktexteditor Cc: dfaure, anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, davidedmundson, palant, kwrite-devel, #frameworks, he

D4847: KAuth integration in document saving

martinkostolny updated this revision to Diff 12251. martinkostolny added a comment. Thanks a lot for all the thoughts and suggestions! I tried to work them in, but I need help with some of them. I'm struggling with the atomic rename. I still find Christoph's suggestion (save to temp file

D4847: KAuth integration in document saving

martinkostolny updated this revision to Diff 12185. martinkostolny added a comment. Understood and agreed, kauth_ktexteditor_helper it is :). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4847?vs=12181&id=12185 REVISION DETAIL https://phabricator.kde

D4847: KAuth integration in document saving

martinkostolny marked 2 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4847 To: martinkostolny, dhaumann, #ktexteditor Cc: anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, davidedmundson, palant, kwrite-devel, #frameworks, head7, kfu

D4847: KAuth integration in document saving

martinkostolny updated this revision to Diff 12181. martinkostolny added a comment. Thanks for your guidance and for having the patience with me. QScopedPointer was indeed very useful. One thing I've noticed - it seems there isn't any naming convention for KAuth helper binary. Sometimes

D4847: KAuth integration in document saving

martinkostolny updated this revision to Diff 12177. martinkostolny added a comment. Good point, thanks! I now the helper is really light-weight. Helper is now only moving a temporary file and setting permissions/owner. I've also added a unit test. It directly calls the action method inste

D4847: KAuth integration in document saving

martinkostolny added a comment. I've learnt a few things about autotests (`KTextEditor::EditorPrivate::unitTestMode()` was really helpful, thanks!). I managed to create a test case, which allowed the code to go through KAuth action. But I was unsuccessful to finish it to my satisfaction - I

D4847: KAuth integration in document saving

martinkostolny updated this revision to Diff 12084.martinkostolny added a comment. View RevisionAfter reading though bug mentioned by Luigi and this QT bug (https://bugreports.qt.io/browse/QTBUG-56366) I'm not so convinced that we want to directly write to file in order to maintain owner, because w

D4847: KAuth integration in document saving

martinkostolny added a comment. View RevisionI think that leaving it as it is is not a solution In that case, I favour the second option (direct write to file).REPOSITORYR39 KTextEditorREVISION DETAILhttps://phabricator.kde.org/D4847EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/email

[Diff] D4847: KAuth integration in document saving

martinkostolny updated this revision to Diff 12058.martinkostolny added a comment. View RevisionNext iteration, still without autotests, I need to study them more. This diff includes preserving owner and group when file is saved with elevated privileges. Actually loosing owner was (and is) already

[Diff] D4847: KAuth integration in document saving

martinkostolny marked 2 inline comments as done. View RevisionREPOSITORYR39 KTextEditorREVISION DETAILhttps://phabricator.kde.org/D4847EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: martinkostolny, dhaumann, KTextEditorCc: dhaumann, graesslin, davidedmundson, palan

[Diff] D4847: KAuth integration in document saving

martinkostolny updated this revision to Diff 12054.martinkostolny added a comment. View RevisionThanks for all the feedback! I'm updating the diff to reflect most Dominik's points. I'll learn from them next time :). Anyway I was unable to remove the KAuth namespace. It doesn't work without it, thi

[Differential] [Updated, 318 lines] D4847: KAuth integration in document saving

martinkostolny updated this revision to Diff 11991. martinkostolny added a comment. I once again updated the diff - I've only renamed 2 variables to better reflect what they mean: readAction -> saveAction (I copied that one from tutorial page and forgot to rename) dataToWrite -> dataToSav

[Differential] [Updated, 318 lines] D4847: KAuth integration in document saving

martinkostolny updated this revision to Diff 11990. martinkostolny added a comment. I missed this one - thanks, Wladimir. Fixed. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4847?vs=11974&id=11990 REVISION DETAIL https://phabricator.kde.org/D4847 A

[Differential] [Request, 318 lines] D4847: KAuth integration in document saving

martinkostolny created this revision. martinkostolny added a project: KTextEditor. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY Before this patch: if one opens a write protected document, makes changes an

Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves

marked as submitted. Review request for KDE Frameworks, David Edmundson, David Faure, and Marco Martin. Changes --- Submitted with commit 19568657af443b085e4e534f1be96410e75155b3 by Martin Kostolný to branch master. Repository: kio Description --- We have an option called "

Re: Review Request 127912: Add 2 methods to gain more info about a mimetype or protocol

> In other words, if you know you want to prefer krarc, why not just query > > whether krarc is available and use it if yes? > > Martin Kostolný wrote: > I'm sorry, it is very well possible that I don't know the required API > for these queries. It is as You said:

Re: Review Request 127912: Add 2 methods to gain more info about a mimetype or protocol

> In other words, if you know you want to prefer krarc, why not just query > > whether krarc is available and use it if yes? > > Martin Kostolný wrote: > I'm sorry, it is very well possible that I don't know the required API > for these queries. It is as You said:

Re: Review Request 127912: Add 2 methods to gain more info about a mimetype or protocol

Testing --- I've tested both methods through Krusader code. Partially covered in this phabricator task: https://phabricator.kde.org/T2401 Thanks, Martin Kostolný ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.

Re: Review Request 127912: Add 2 methods to gain more info about a mimetype or protocol

> In other words, if you know you want to prefer krarc, why not just query > > whether krarc is available and use it if yes? > > Martin Kostolný wrote: > I'm sorry, it is very well possible that I don't know the required API > for these queries. It is as You said:

Re: Review Request 127912: Add 2 methods to gain more info about a mimetype or protocol

visit: https://git.reviewboard.kde.org/r/127912/#review95467 ------- On May 14, 2016, 11:38 a.m., Martin Kostolný wrote: > > --- > This is an automatically generate

Review Request 127912: Add 2 methods to gain more info about a mimetype or protocol

covered in this phabricator task: https://phabricator.kde.org/T2401 Thanks, Martin Kostolný ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves

s for > > the user to turn off some global setting (like the one you just added) and > > then (forget to) turn it back on. Right? :-) > > Martin Kostolný wrote: > Sorry for my late response. I agree with every word you said, David. :-) > Thanks for taking your time to discuss thi

Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves

s for > > the user to turn off some global setting (like the one you just added) and > > then (forget to) turn it back on. Right? :-) > > Martin Kostolný wrote: > Sorry for my late response. I agree with every word you said, David. :-) > Thanks for taking your time to discuss thi

Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves

s for > > the user to turn off some global setting (like the one you just added) and > > then (forget to) turn it back on. Right? :-) > > Martin Kostolný wrote: > Sorry for my late response. I agree with every word you said, David. :-) > Thanks for taking your time to discuss thi

Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves

like a runtime option to temporarily but globally disable MarkPartial. Something similar to "Enable Power Management" button available in expanded battery plasmoid. - Martin --- This is an automatically generated e-mai

Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves

h f7a0abc src/kcms/kio/netpref.cpp 24273a3 Diff: https://git.reviewboard.kde.org/r/127154/diff/ Testing --- Tested toggling MarkPartial on SMB, SFTP slaves. FISH slave was and still is ignoring it (no .part extension). I didn't test NFS and others. Thanks, Martin Kostolný