D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli updated this revision to Diff 46321. lsartorelli added a comment. Added @since and @author in the header documentation REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17013?vs=46248&id=46321 REVISION DETAIL https://phabricator.kde.org/D

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli added a comment. Usually the message should be always shown, but I think there there are some exceptions. - for Kate the message is supposed to be off till its code base is upgraded with the removal of ts own popup. - for dolphin the message should be shown only if the menu

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli updated this revision to Diff 46248. lsartorelli added a comment. Hi, you are right, I did not realize a bit of mess in between my revisions. Now all the requests should have been fulfilled properly. Thanks for this massive support and please, just let me know if I need to

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli marked an inline comment as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham, #frameworks, #kde_applications Cc: aacid, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli updated this revision to Diff 45934. lsartorelli marked an inline comment as done. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17013?vs=45874&id=45934 REVISION DETAIL https://phabricator.kde.org/D17013 AFFECTED FILES src/CMakeLists.t

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli marked an inline comment as done. lsartorelli added inline comments. INLINE COMMENTS > aacid wrote in ktoggleshowmenubaraction.cpp:77 > If shortcut() returns a QKeySequence (i think it does), you want > toString(NativeText) > > Not a native speaker but i don't think "typing" is what

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli updated this revision to Diff 45874. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17013?vs=45821&id=45874 REVISION DETAIL https://phabricator.kde.org/D17013 AFFECTED FILES src/CMakeLists.txt src/ktoggleshowmenubaraction.cpp src/kt

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli updated this revision to Diff 45821. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17013?vs=45812&id=45821 REVISION DETAIL https://phabricator.kde.org/D17013 AFFECTED FILES src/CMakeLists.txt src/ktoggleshowmenubaraction.cpp src/kt

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli marked 3 inline comments as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham, #frameworks, #kde_applications Cc: cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli added inline comments. INLINE COMMENTS > cfeck wrote in ktoggleshowmenubaraction.h:28 > reminds > > Additionally, "show back" does not sound like proper english, but I am not a > native english speaker. Unfortunately, me too, ... any suggestion is appreciated REPOSITORY R236 KWi

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli updated this revision to Diff 45812. lsartorelli marked 2 inline comments as done. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17013?vs=45811&id=45812 REVISION DETAIL https://phabricator.kde.org/D17013 AFFECTED FILES src/CMakeLists.t

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli updated this revision to Diff 45811. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17013?vs=45807&id=45811 REVISION DETAIL https://phabricator.kde.org/D17013 AFFECTED FILES src/CMakeLists.txt src/ktoggleshowmenubaraction.cpp src/kt

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli added a dependent revision: D17016: Show menu bar, how to re-enable, common shortcut dialog. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17014: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli added a dependent revision: D17016: Show menu bar, how to re-enable, common shortcut dialog. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D17014 To: lsartorelli, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli marked 2 inline comments as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli updated this revision to Diff 45807. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17013?vs=45798&id=45807 REVISION DETAIL https://phabricator.kde.org/D17013 AFFECTED FILES src/CMakeLists.txt src/ktoggleshowmenubaraction.cpp src/kt

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli added a dependent revision: D17014: Show menu bar, how to re-enable, common shortcut dialog. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17014: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli created this revision. lsartorelli added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. lsartorelli requested review of this revision. REVISION SUMMARY Provide a common message ,encapsulated into the ShowMenuBarAction, with a

D17014: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli added a dependency: D17013: Show menu bar, how to re-enable, common shortcut dialog. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D17014 To: lsartorelli, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli created this revision. lsartorelli added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. lsartorelli requested review of this revision. REVISION SUMMARY Provide a common message ,encapsulated into the ShowMenuBarAction, with a

D15644: Provide option to hide menu bar for Ksysguard

lsartorelli marked 6 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D15644 To: lsartorelli, ngraham, #plasma, #frameworks Cc: broulik, sitter, acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15644: Provide option to hide menu bar for Ksysguard

lsartorelli updated this revision to Diff 42368. lsartorelli added a comment. little clean up CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15644?vs=42350&id=42368 REVISION DETAIL https://phabricator.kde.org/D15644 AFFECTED FILES gui/ksysguard.cpp gui/ksysguard.h To: lsarto

D15644: Provide option to hide menu bar for Ksysguard

lsartorelli updated this revision to Diff 42350. lsartorelli added a comment. Removed unused parameter in toggleShowMenuBar() CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15644?vs=42298&id=42350 REVISION DETAIL https://phabricator.kde.org/D15644 AFFECTED FILES gui/ksysguard.c

D15644: Provide option to hide menu bar for Ksysguard

lsartorelli added a comment. Thank you very much, I am so happy and proud for my first patch. Here my details: Name: Luca Surname: Sartorelli Mail: dj3...@gmail.com And here is the patch for gwenview: https://phabricator.kde.org/D15747 Just added you as reviewer 2 se

D15644: Provide option to hide menu bar for Ksysguard

lsartorelli updated this revision to Diff 42298. lsartorelli added a comment. Added remainder message box with keyboard shortcut, to have back the menu bar. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15644?vs=42101&id=42298 REVISION DETAIL https://phabricator.kde.org/D15644 A

D15644: Provide option to hide menu bar for Ksysguard

lsartorelli added a comment. Hi Nathaniel, thanks for all the support. I can understand and agree with your concerns. Not sure but maybe an option could be to add the hide menu bar entry in the setting menu via kxmlguiwindow and another entry to unhide it maybe can be putted in the contex

D15644: Provide option to hide menu bar for Ksysguard

lsartorelli retitled this revision from "Provide option to hide menu bar for Ksysguard - Bug 395349" to "Provide option to hide menu bar for Ksysguard". lsartorelli edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D15644 To: lsartorelli, ngraham, #plasma, #frame

D15644: Provide option to hide menu bar for Ksysguard - Bug 395349

lsartorelli updated this revision to Diff 42101. lsartorelli retitled this revision from "Bug 395349" to "Provide option to hide menu bar for Ksysguard - Bug 395349". lsartorelli edited the summary of this revision. lsartorelli added a comment. Thank you, for all the feedback. Yes, I have

Re: Review Request 124684: Cmake fail to parse proper taglib version - kdelibs4support

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 75ce05d1aef1b1d3697affe69c4d42f02afbd25d by Michael Pyne on behalf of Luca Sartorelli to branch master. Repository: kdelibs4support Description --- Wrong string comparison of taglib version

Re: Review Request 124684: Cmake fail to parse proper taglib version - kdelibs4support

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124684/#review83685 --- On Aug. 10, 2015, 9:56 a.m., Luca Sartorelli wrote: > > -

Re: Review Request 124682: Cmake fail to parse proper taglib version - extra-cmake-modules

found and parsed Thanks, Luca Sartorelli ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124684: Cmake fail to parse proper taglib version - kdelibs4support

and parsed Thanks, Luca Sartorelli ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel