D5405: Create desktop file name based on organization domain unless set explicitely

2017-06-13 Thread Leslie Zhai
This revision was automatically updated to reflect the committed changes. Closed by commit R467:ddd546251022: Set organization name for Wayland icon. (authored by lesliezhai). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5405?vs=13342&id=15416#toc REPOSITORY R467 K3b CHANGES SINCE L

D4932: Cookies KCM: disable "delete" button when there is no current item

2017-03-04 Thread Leslie Zhai
lesliezhai accepted this revision. lesliezhai added a comment. This revision is now accepted and ready to land. Hi David, Looks good to me! Regards, Leslie Zhai REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D4932 To: dfaure, lesliezhai Cc

Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

2016-09-17 Thread Leslie Zhai
oxtest 14 click 'Details' button, detailsGroup is *NOT* able to show correctly! I will try to fix as Anthony suggested! Regards, Leslie Zhai - Leslie --- This is an automatically generated e-mail. To rep

Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

2016-09-17 Thread Leslie Zhai
Returns a copy of this string repeated the specified number of times. > > Anthony Fieroni wrote: > Fix it here > https://api.kde.org/frameworks/kwidgetsaddons/html/kmessagebox_8cpp_source.html#l00200 Hi Anthony, Thanks for your hint,

Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

2016-09-17 Thread Leslie Zhai
such as add files from samba, but KMessageBox::detailedSorry hide some part of detailsGroup https://pbs.twimg.com/media/CqxlXX1W8AAtoee.jpg so it is better to show it directly by default! Regards, Leslie Zhai Diffs (updated) - tests/kmessageboxtest.cpp 8ea2848 Diff: https

Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

2016-09-15 Thread Leslie Zhai
detailsGroup https://pbs.twimg.com/media/CqxlXX1W8AAtoee.jpg so it is better to show it directly by default! Regards, Leslie Zhai Diffs - src/kmessagebox.cpp 194ffae tests/kmessageboxtest.cpp 8ea2848 Diff: https://git.reviewboard.kde.org/r/128768/diff/ Testing --- add case 26

Re: Is it able to make kservice's weightedOffers public access?

2016-07-10 Thread Leslie Zhai
ader::self()->query("Applications"); -- Regards, Leslie Zhai https://git.reviewboard.kde.org/users/lesliezhai/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Is it able to make kservice's weightedOffers public access?

2016-06-28 Thread Leslie Zhai
Trader(const KServiceTypeTrader &other); KServiceTypeTrader &operator=(const KServiceTypeTrader &rhs); -static KServiceOfferList weightedOffers(const QString &serviceType); - KServiceTypeTraderPrivate *const d; friend class KServi