D26394: ECMGeneratePriFile: Fix static configurations

This revision was automatically updated to reflect the committed changes. Closed by commit R240:fafbc8cec665: ECMGeneratePriFile: Fix static configurations (authored by kfunk). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26394?vs=72687&id=75155

D26364: SlaveBase::dispatchLoop: Fix timeout calculation

This revision was automatically updated to reflect the committed changes. Closed by commit R241:27271405f408: SlaveBase::dispatchLoop: Fix timeout calculation (authored by Julien Goodwin , committed by kfunk). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://

D26394: ECMGeneratePriFile: Fix static configurations

kfunk added reviewers: winterz, vkrause. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26394 To: kfunk, dfaure, winterz, vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D26394: ECMGeneratePriFile: Fix static configurations

kfunk created this revision. kfunk added a reviewer: dfaure. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kfunk requested review of this revision. REVISION SUMMARY Populate module_config with staticlib. This is needed for Qt 5.

D26364: SlaveBase::dispatchLoop: Fix timeout calculation

kfunk added a reviewer: broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26364 To: kfunk, chinmoyr, davidedmundson, dfaure, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26364: SlaveBase::dispatchLoop: Fix timeout calculation

kfunk added reviewers: chinmoyr, davidedmundson, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26364 To: kfunk, chinmoyr, davidedmundson, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26364: SlaveBase::dispatchLoop: Fix timeout calculation

kfunk created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kfunk requested review of this revision. REVISION SUMMARY Old version of the code: ms = qMax(d->nextTimeout.elapsed() - d->nextTimeoutMsecs, 1); ... will mean the sleep i

D17325: Fix leak in kemoticons

kfunk updated this revision to Diff 46787. kfunk added a comment. Use QSharedPointer REPOSITORY R301 KEmoticons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17325?vs=46765&id=46787 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17325 AFFECTED FILES src/core/

D17325: Fix leak in kemoticons

kfunk added a comment. Not entirely sure about whether this is the right fix for this. Can someone check why this was commented before? The leak is fixed with this patch. Unit tests still work, too. And it kind of makes sense to have the `KEmoticonsTheme` class own its provider. RE

D17325: Fix leak in kemoticons

kfunk created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kfunk requested review of this revision. REVISION SUMMARY ASAN trace: Indirect leak of 64 byte(s) in 2 object(s) allocated from: #0 0x52a000 in operator new(unsigned long)

D17031: Fix a few memory leaksASAN: Fix leak in AppletQuickItem

kfunk added a comment. Yep, those are in fact separate commits. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17031 To: kfunk, mart Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns

D17031: Fix a few memory leaksASAN: Fix leak in AppletQuickItem

This revision was automatically updated to reflect the committed changes. Closed by commit R242:421e1c01266e: ASAN: Fix memory leak in CalendarPlugin (authored by kfunk). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17031?vs=45849&id=45891#toc REPOSITORY R242 Plasma Framework (Librar

D17031: Fix a few memory leaksASAN: Fix leak in AppletQuickItem

kfunk created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kfunk requested review of this revision. REVISION SUMMARY Direct leak of 3960 byte(s) in 15 object(s) allocated from: #0 0x544cc0 in operator new(unsigned long) (/home/kfunk/

D16894: [ECM] use a macro to add compiler flags conditionally

kfunk requested changes to this revision. kfunk added a comment. This revision now requires changes to proceed. I don't like the hiding of the if-branches as argument to macro. We shouldn't to this as it makes the code harder to understand. The general issue with the existing code here is

D15002: Allow to install syntax files instead of having them in a resource

kfunk added inline comments. INLINE COMMENTS > CMakeLists.txt:3 > macro(generate_php_syntax_definition targetFile srcFile) > -add_custom_command( > -OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/${targetFile} > -COMMAND ${PERL_EXECUTABLE} > ${CMAKE_CURRENT_SOURCE_DIR}/generators/genera

D14987: hunspell: Restore build with hunspell <=v1.5.0

This revision was automatically updated to reflect the committed changes. Closed by commit R246:a18b3810a18d: hunspell: Restore build with hunspell <=v1.5.0 (authored by kfunk). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14987?vs=40190&id=40200 REVISION DE

D14987: hunspell: Restore build with hunspell <=v1.5.0

kfunk added inline comments. INLINE COMMENTS > dfaure wrote in hunspelldict.cpp:130 > lst.reserve(nbWord); Note: That's just old/copied code. Unlikely to be called on recent distros anyway. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D14987 To: kfu

D14987: hunspell: Restore build with hunspell <=v1.5.0

kfunk added reviewers: rjvbb, dfaure, mlaurent. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D14987 To: kfunk, rjvbb, dfaure, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14987: hunspell: Restore build with hunspell <=v1.5.0

kfunk created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kfunk requested review of this revision. REVISION SUMMARY Commit 0a96acf251baa5c9dd042d093ab2bf8fcee10502

D11193: Sonnet : use current hunspell API

kfunk added a comment. Please see concerns on https://phabricator.kde.org/R246:0a96acf251baa5c9dd042d093ab2bf8fcee10502 REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D11193 To: rjvbb, #frameworks, dfaure, mlaurent, vkrause Cc: kfunk, kde-frameworks-devel, michaelh,

D9408: extractors: Hide warnings from system headers

This revision was automatically updated to reflect the committed changes. Closed by commit R286:b680861aa2ed: extractors: Hide warnings from system headers (authored by kfunk). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9408?vs=33189&id=33191 REVISI

D9408: extractors: Hide warnings from system headers

kfunk updated this revision to Diff 33189. kfunk added a comment. Add PRIVATE REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9408?vs=33121&id=33189 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9408 AFFECTED FILES src/extractors/

Re: kfilemetadata compile failure

egards, Kevin > It may be expecting a newer version of ffmpeg > > Jonathan -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

D9408: extractors: Hide warnings from system headers

kfunk added a reviewer: mgallien. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D9408 To: kfunk, mgallien Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D9408: extractors: Hide warnings from system headers

kfunk updated this revision to Diff 33121. kfunk added a comment. Restricted Application added a project: Baloo. Rebased REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9408?vs=24101&id=33121 BRANCH master REVISION DETAIL https://phabricator.kde.

D12112: Fix compiler warning under Clang

This revision was automatically updated to reflect the committed changes. Closed by commit R244:53f44072c70a: Fix compiler warning under Clang (authored by kfunk). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12112?vs=31888&id=31914 REVISION DETAIL ht

D12112: Fix compiler warning under Clang

kfunk updated this revision to Diff 31888. kfunk added a comment. Address concerns. I knew why I put this up for review. /me grabs another coffee... REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12112?vs=31878&id=31888 BRANCH master REVISION DETAI

D12112: Fix compiler warning under Clang

kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kfunk requested review of this revision. REVISION SUMMARY Issue: In file included from .../kcoreaddons/src/lib/caching/kshareddatacache.cpp:25: .../kcoreadd

D11610: clang-tidy: modernize-use-default-member-init run

This revision was automatically updated to reflect the committed changes. Closed by commit R39:40d801599549: clang-tidy: modernize-use-default-member-init run (authored by kfunk). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11610?vs=30305&id=31852 REVIS

D11948: [KFileWidget] Hardcode example user name

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. Makes sense to me. Go for it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11948 To: broulik, #frameworks, kfunk Cc: kfunk, elvisangelaccio, michaelh, ngraham, bruns

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

kfunk resigned from this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd, poboiko, bruns Cc: bruns, adridg, kfunk, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

Re: Asking for recommendations on how to add a feature to KTextEditor

without modifying KTextEditor? > > Including kwrite-devel where many kate developers live. :) > Looking forward to seeing your feature implemented in KDevelop! :D > > Aleix -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

D10739: Remove deprecated cmake code

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D10739 To: vonreth, kfunk, dfaure, vkrause, mlaurent Cc: apol, #frameworks, michaelh, ngraham

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

kfunk requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5865 To: rjvbb, #frameworks, #build_system, cgilles, kfunk Cc: thiago, kfunk, michaelh, ngraham

D11610: clang-tidy: modernize-use-default-member-init run

kfunk added a comment. I'll wait until v5.45 got branched off. No need to hurry with this. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D11610 To: kfunk, dhaumann Cc: dhaumann, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sa

D11610: clang-tidy: modernize-use-default-member-init run

kfunk edited the summary of this revision. kfunk edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11610 To: kfunk Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D11610: clang-tidy: modernize-use-default-member-init run

kfunk created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. kfunk requested review of this revision. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D11610 AFFECTED FILES

D11278: [KateCompletionWidget] Create configuration interface on demand

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. In D11278#224484 , @kfunk wrote: > Looks like you don't need the member at all? Otherwise late-init wouldn't work this way. > > `m_configWid

D11278: [KateCompletionWidget] Create configuration interface on demand

kfunk added a comment. Looks like you don't need the member at all? Otherwise late-init wouldn't work this way. `m_configWidget` seems only used in `showConfig()`. Let's remove the member altogether? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11278 To:

Re: Converting KDE4 projects to KF5

to use the porting scripts here: git://anongit.kde.org/kde-dev-scripts, subdirectory kf5 Happy porting! Regards, Kevin > Thanks > Robin -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

Re: KDirListerCache destroy comment in kcoredirlister.cpp

leted via atexit; a lucky > shot in the dark that makes a lot of sense in retrospect.) > > Thanks for any pointers, > R. -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

D9766: Use at least the requested width for the argument hint tree

kfunk added a comment. Whoops. Sorry for accidentally reopening it to begin with. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9766 To: mwolff, #kdevelop, #kate Cc: dhaumann, kfunk, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars

D9766: Use at least the requested width for the argument hint tree

kfunk reopened this revision. kfunk added a comment. LGTM. Just a had a quick look at the appearance of the popup before vs. after the patch when doing code completion inside the a function call parameter list. Looks more consisten now, thanks! REPOSITORY R39 KTextEditor REVISION DET

D9760: Fix kded dbus name in solid-networking howto

kfunk accepted this revision. REPOSITORY R239 KDELibs4Support BRANCH master REVISION DETAIL https://phabricator.kde.org/D9760 To: habacker, kfunk Cc: kfunk, #frameworks

D9760: Fix kded dbus name in solid-networking howto

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. //src/solid-networkstatus/DESIGN// also still references `org.kde.kded`. Please update, too. Rest LGTM REPOSITORY R239 KDELibs4Support BRANCH master REVISION DETAIL https://phabr

D9750: ExpandingWidgetModel: find the right-most column based on location

kfunk added a comment. LGTM, but I'll let someone else approve. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9750 To: mwolff, #kate Cc: kfunk, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D9749: Simplify code: return early to reduce indentation depth

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9749 To: mwolff, #kate, kfunk Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'

kfunk added a comment. @dfaure Opinions? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9423 To: habacker, dfaure, bcooksley, kfunk Cc: kfunk, broulik, #frameworks

D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'

kfunk added a comment. In https://phabricator.kde.org/D9423#181460, @habacker wrote: > In https://phabricator.kde.org/D9423#181442, @kfunk wrote: > > > And I agree. There shouldn't be a need to use two different input files. That's the whole point of `configure_file(...)`: the interpo

D9424: Fix 'Exec line in kglobalaccel5 service file must not have any path prefix on Windows'

kfunk added a comment. Please let's discuss on https://phabricator.kde.org/D9423 exclusively. This is basically fixing the same issue in a different repository. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9424 To: habacker, dfaure, bcooksley, apol Cc: kfunk

D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'

kfunk requested changes to this revision. kfunk added a comment. This revision now requires changes to proceed. And I agree. There shouldn't be a need to use two different input files. That's the whole point of `configure_file(...)` the interpolation of values happens *inside* the input files

D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'

kfunk added a comment. Could you please squash the commits and just keep this review for all the changes in KIO? Doesn't make sense to have different Phab Diffs for that (makes it harder to review, harder to revert in case, etc.). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.

D9398: Fix TagLib detection and build on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit R320:5e6c6fe0c7a1: Fix TagLib detection and build on Windows (authored by kfunk). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9398?vs=24075&id=24104 REVISION DETA

D9408: extractors: Hide warnings from system headers

kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Also prefer kde_target_enable_exceptions() over the function enabling exceptions globally. REPOSITORY R286 KFileMetaData BRANCH master

D9398: Fix TagLib detection and build on Windows

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D9398 To: leinir, #frameworks, kfunk Cc: vonreth

D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes

kfunk added a comment. Sorry for being late, but I didn't have time to follow up on this one. My concerns: - If you have that option `ON` and all frameworks install into the same prefix, `prefix.sh` will be overwritten. => Bad. - I still don't fully see how to adopt the use case ap

D9321: Fix another CMake CMP0071 warning

This revision was automatically updated to reflect the committed changes. Closed by commit R216:fb80c0549aed: Fix another CMake CMP0071 warning (authored by kfunk). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9321?vs=23887&id=23896 REVISION DET

D9321: Fix another CMake CMP0071 warning

kfunk added reviewers: mlaurent, dfaure. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D9321 To: kfunk, mlaurent, dfaure Cc: #frameworks

D9321: Fix another CMake CMP0071 warning

kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY CMake Warning (dev) in data/CMakeLists.txt: Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files. Run "cma

D9277: Remove cmake warning about generating moc file

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. Yes. Makes sense to me. INLINE COMMENTS > KF5ConfigMacros.cmake:98 > > + set_property(SOURCE ${_header_FILE} PROPERTY SKIP_AUTOMOC TRUE) # > don't run automoc on this file > +

D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes

kfunk added a comment. In https://phabricator.kde.org/D9299#179036, @cgiboudeaux wrote: > In https://phabricator.kde.org/D9299#179035, @cgiboudeaux wrote: > > > In https://phabricator.kde.org/D9299#179032, @kfunk wrote: > > > > > If we'd name this file somewhat less generic then it

D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes

kfunk added inline comments. INLINE COMMENTS > sitter wrote in KDEInstallDirs.cmake:699 > From a style perspective, I'd suggest having the prefix.sh live somewhere in > the installed ECM tree and get copied, rather than maintained as a glorified > heredoc in the cmake code. That's just a sugges

D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes

kfunk added a comment. If we'd name this file somewhat less generic then it could be even installed by default, no? I had the scheme of the QNX setup script in my mind: https://github.com/acklinr/qnx660/blob/master/qnx660-env.sh Thus: Maybe rename prefix.sh to say 'ecm-env.sh' and

D9182: return nullptr -> return {} for QFlags

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. For the record, see comment https://phabricator.kde.org/D3987#174960 REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D9182 To: mkoller, kfunk, kossebau Cc: #fra

D9118: ki18n cmake macros: Mark UIC-generated .h files to skip AUTOMOC by default

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. This shouldn't create any troubles with earlier CMake versions. Also note that we set the same properties unconditionally in newer Qt5 CMake macros: https://codereview.qt-project.org/#/c/

D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk added a comment. In https://phabricator.kde.org/D3987#174960, @mkoller wrote: > I just found out that this change introduced wrong replacements. It did not, the changes are correct, though they're probably not what everyone expects. Please read through the comments in t

D8979: ecm_add_test: Use proper path sep on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit R240:64915e0291cd: ecm_add_test: Use proper path sep on Windows (authored by kfunk). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8979?vs=22863&id=22869 R

D8979: ecm_add_test: Use proper path sep on Windows

kfunk added a reviewer: cgiboudeaux. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8979 To: kfunk, dfaure, cgiboudeaux Cc: #frameworks, #build_system

D8979: ecm_add_test: Use proper path sep on Windows

kfunk added a reviewer: bcooksley. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8979 To: kfunk, dfaure, cgiboudeaux, bcooksley Cc: #windows, #frameworks, #build_system

D8979: ecm_add_test: Use proper path sep on Windows

kfunk added a subscriber: Windows. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8979 To: kfunk, dfaure, cgiboudeaux Cc: #windows, #frameworks, #build_system

D8979: ecm_add_test: Use proper path sep on Windows

kfunk created this revision. kfunk added a reviewer: dfaure. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY We need to separate paths in environment variables with a semincolon (;) on Windows

D8976: Remove redundant map look-ups

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D8976 To: apol, #frameworks, jgrulich, kfunk

D8923: Offer QWindow API for KJobWidgets:: decorators

kfunk added inline comments. INLINE COMMENTS > apol wrote in kjobwidgets.cpp:67 > Note I didn't change any code, I just moved it around. > > Removing the cast still seems to work, so I'll do that. > Note I didn't change any code, I just moved it around. Whoops, sorry. Didn't notice. REPOSITOR

D8923: Offer QWindow API for KJobWidgets:: decorators

kfunk added inline comments. INLINE COMMENTS > kjobwidgets.cpp:67 > +if (window) { > +job->setProperty("window-id", > QVariant::fromValue(qptrdiff(window->winId(; > +} `WId` is a `quintptr`: `src/gui/kernel/qwindowdefs.h:99:typedef QT_PREPEND_NAMESPACE(quintptr) WId;` Besi

Re: How is symbol visibility set in KF5 and KDE?

SIBILITY_PRESET hidden) 225:set(CMAKE_VISIBILITY_INLINES_HIDDEN 1) Regards, Kevin > Thanks, Shaheed > > [1] I'm also a bit mystified by the fact that I am deliberately querying > CMake for the COMPILE_FLAGS to use, but I have not seen -fvisibility > anywhere... -- Kevin Fun

D8810: Do not look for kioslave binary in applicationDirPath (#386859)

kfunk requested changes to this revision. kfunk added a comment. This revision now requires changes to proceed. Just chiming in here, without having a final solution for your problem: This search path has been added for a reason -- to find a kioslave.exe next to the application binary in appl

D8810: Do not look for kioslave binary in applicationDirPath (#386859)

kfunk added a reviewer: cullmann. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8810 To: kkofler, #frameworks, kfunk, cullmann Cc: kfunk

D8577: Fix: Missing dependencies for ktexeditor autotests

kfunk added a comment. In https://phabricator.kde.org/D8577#164815, @cullmann wrote: > Could you just remove the problematic includes and try to compile without the dependency, IMHO I see no use of QtScript stuff. Done with: https://phabricator.kde.org/R39:631b1447c97f1d81de2e81d

D8544: KTextEditor : avoiding QML crashes

kfunk added inline comments. INLINE COMMENTS > kateglobal.cpp:104 > +// disable the QML JIT compiler as a protection against an unknown bug > +// in Qt's V4 engine which can provoke a crash in certain of our scripts. > +qputenv("QV4_FORCE_INTERPRETER", QByteArrayLiteral("1")); Please

D8437: KWidgetsAddons : more compact password dialog

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. Looks like it :) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8437 To: rjvbb, #frameworks, kfunk, ngraham Cc: cfeck, ngraham

D8437: KWidgetsAddons : more compact password dialog

kfunk requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8437 To: rjvbb, #frameworks, kfunk Cc: cfeck, ngraham

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

kfunk requested changes to this revision. kfunk added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > iokitdevice.cpp:307 > +default: > +vendor = QString(); > +break; Why not `return` here as well? For consistency. You can end the function w

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

kfunk added inline comments. INLINE COMMENTS > iokitopticaldrive.cpp:27 > + > +#ifdef EJECT_USING_DISKARBITRATION > +// for QCFType: Where's that defined via the build system? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7401 To: rjvbb, #frameworks, kfunk Cc: kfunk,

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

kfunk requested changes to this revision. kfunk added a comment. This revision now requires changes to proceed. This definitely needs another revision. Please fix the outstanding issues. INLINE COMMENTS > iokitblock.h:43 > + > +virtual int deviceMajor() const; > +virtual int deviceMin

Re: What removes protocoltojson with make install in kio?

e directories -- install into a different prefix. Regards, Kevin > and protocoltojson is indeed gone from the bin folder. > Running find . -iname "protocoltojson" > only gives me the build folder for it, the binary is actually gone... > > Am i doing anything wrong? >

Re: Adding build info attribute to KAboutData to improve bug report data?

On Monday, 16 October 2017 07:10:29 CEST Luca Beltrame wrote: > Il giorno Sun, 08 Oct 2017 19:45:00 +0200 > > Kevin Funk ha scritto: > > Heya, > > > > The KDevelop team is currently discussing a patch which adds > > > > git-describe like informat

D8314: Fix deprecation warning

This revision was automatically updated to reflect the committed changes. Closed by commit R39:68d42865076e: Fix deprecation warning (authored by kfunk). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8314?vs=20813&id=20841 REVISION DETAIL https://phabric

D8315: CMake cleanup: Don't hardcode -std=c++0x

This revision was automatically updated to reflect the committed changes. Closed by commit R279:265b9f9f3120: CMake cleanup: Don't hardcode -std=c++0x (authored by kfunk). REPOSITORY R279 ThreadWeaver CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8315?vs=20814&id=20840 REVISION DET

FYI: Added .arcconfig files to all frameworks

Heya, just pushed an .arcconfig file to all framework repositories. There were still lots of frameworks without them. Example commit: https://cgit.kde.org/qqc2-desktop-style.git/commit/? id=146e370704938e6cab6278a5e203f3ef2cf93946 Regards, Kevin -- Kevin Funk | kf...@kde.org | http

D8315: CMake cleanup: Don't hardcode -std=c++0x

kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This is both set by ECM & Qt5 CMake config files REPOSITORY R279 ThreadWeaver BRANCH master REVISION DETAIL https://phabricator.kde.or

D8314: Fix deprecation warning

kfunk created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Warning: /home/kfunk/devel/src/kf5/ktexteditor/src/dialogs/katedialogs.cpp:1455:11: warning: 'runUrl' is deprecated [-Wdeprecat

Re: Adding build info attribute to KAboutData to improve bug report data?

On Sunday, 8 October 2017 19:45:00 CEST Kevin Funk wrote: > Heya, > > The KDevelop team is currently discussing a patch which adds git-describe > like information to the version string in KAboutData: > https://phabricator.kde.org/D8158 > (don't bother readi

Re: concise instructions how to use sub...@bugs.kde.org?

traight-forward and sustainable variant? I thought this is working in general? Why do we need diverge again (i.e. introducing a tool where no-one is familiar with) instead of completing existing work? Thanks, Kevin > Thank, > René -- Kevin Funk | kf...@kde.org | http://kfunk.org signa

D8296: Use Ctrl+, as the standard shortcut for "Configure "

kfunk added a comment. In KDevelop, this is also a really important shortcut for navigating through the source. `Ctrl+,` for jumping to definition, `Ctrl+.` for jumping to declaration. /me wonders if one really needs a shortcut for configuring shortcuts at all. https://lxr.kde.org/sear

D8264: Fix build of breeze-icons on the Android CI

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. That comment could be a bit more verbose and better placed (i.e. move it next to `set(BINARY_ICONS_RESOURCE_OPTION_DEFAULT OFF)` and make it something along "When cross-compiling qrcAlias wou

D8264: Fix build of breeze-icons on the Android CI

kfunk requested changes to this revision. kfunk added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:23 > +if (CMAKE_CROSSCOMPILING) > +set(GENERATE_ICONS_DEFAULT OFF) > +else() Better: `GENERATE_ICONS_DEFAULT` -> `BINARY_ICONS_RESOURCE_OPTIO

D8209: Use https for KDE urls

This revision was automatically updated to reflect the committed changes. Closed by commit R263:1ee609564a8f: Use https for KDE urls (authored by kfunk). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8209?vs=20493&id=20504 REVISION DETAIL https://phabricato

D8207: Use https for KDE urls

kfunk added a comment. In https://phabricator.kde.org/D8207#153510, @mpyne wrote: > I support the idea, but I think there's a few more spots where we can convert http:// to https://. I ran `ag --only-matching --no-heading 'http:.*k.*\.org'` in the kcoreaddons source directory, with the

D8207: Use https for KDE urls

This revision was automatically updated to reflect the committed changes. Closed by commit R244:3cc8b8f5ad26: Use https for KDE urls (authored by kfunk). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8207?vs=20491&id=20502#toc REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE ht

D8209: Use https for KDE urls

kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D8209 AFFECTED FILES make_kdepackages_updated.py src/kaboutapplicat

  1   2   3   4   5   6   >