D8791: Avoid inconsistent passworddialog

2017-11-20 Thread Kees vd Broek
cryptodude edited the test plan for this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8791 To: cryptodude, dfaure, cfeck Cc: ngraham, #frameworks

D8791: Avoid inconsistent passworddialog

2017-11-20 Thread Kees vd Broek
cryptodude added a comment. > so if something doesn't work, let me know ;-) It took me quite some figuring out how this works. Thanks for stating it really should work. The only way that I managed to get it to work is load the project in QtCreator and select the 'debug' build there. I

D8791: Avoid inconsistent passworddialog

2017-11-20 Thread Kees vd Broek
cryptodude added a comment. The changes are pretty simple, but testing it would require a lot of work as it requires a full up-to-date KDE development system and I just don't have that option. So I can't give you a screenshot, as the "test plan" indicates, I visually can't test it. REP

D8791: Avoid inconsistent passworddialog

2017-11-13 Thread Kees vd Broek
cryptodude created this revision. cryptodude added reviewers: dfaure, cfeck. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY In case the user starts the KPasswordDialog without the KPasswordDialog::ShowUsernameLine, t