D16395: Update the "About KDE" text

2018-10-24 Thread Julian Schraner
xyquadrat added a comment. > KDE is a cooperative enterprise in which no single entity controls the efforts or efforts or products of KDE to the exclusion of others. I think this sentence is too complex. I'd suggest writing something like "KDE is a cooperative enterprise: nobody controls

D14674: handle non-ASCII encodings of file names in tar archives

2018-08-08 Thread Julian Schraner
xyquadrat added a comment. Two links that might be useful when writing the unit test: https://community.kde.org/Guidelines_and_HOWTOs/UnitTests https://wiki.qt.io/Writing_Unit_Tests Also, there are already a few unit tests in this repo that you could take a look at. Thank you for yo

D12321: Hide file preview when icon is too small

2018-04-19 Thread Julian Schraner
xyquadrat added a comment. In D12321#249981 , @ngraham wrote: > Fabulous. I agree with @rkflx that before committing this, we should also prepare a similar patch for Dolphin to unify the behaviors. That would be great, as this would solve