Hello KDE developers,
If anyone is interested, here is a brief report on something I have been
working on in my spare time.
TLDR: Here are some scripts to build KDE frameworks and okular statically using
gcc/musl and cross-building for mingw: https://github.com/jschultz/kde-static
Look in the
jonathans added a comment.
I wrote the first patch to be as minimal as possible and to be consistent
with the previous coding style. I therefore left the early returns in place.
I wrote the latest patch based on my interpretation of your (@kfunk) feedback
that it makes more sense to tes
jonathans set the repository for this revision to R239 KDELibs4Support.
jonathans updated this revision to Diff 10021.
jonathans marked 2 inline comments as done.
jonathans added a comment.
Restricted Application added a project: Frameworks.
Found a couple of places in old code where d->w made
jonathans added a comment.
Apparently updating the diff has had the side-effect of:
> https://phabricator.kde.org/source/kdelibs4support/ KDELibs4Support as the
repository for this revision.
Please excuse my bumbling - I don't know why that happened or how to repair
it. :(
REVISIO
jonathans removed R239 KDELibs4Support as the repository for this revision.
jonathans updated this revision to Diff 10020.
jonathans added a comment.
Following @kfunk comments, I've changed the patch to test d->w rather than
d->native, and used nullptr instead of 0 where appropriate.
CHANGES
jonathans added a comment.
Agreed that would be more robust. In writing the patch I was seeking
consistency with those functions that already did the test, so those would also
need to be updated. Are there any situations where the two tests would yield a
different result, ie d->native is tru
Sorry for cross-posting, but kde-frameworks-devel seems to be a more
active list than kde-devel where I previously raised this issue.
I'd like to file a bug report for kdelibs4support/kio/kfiledialog but
don't seem to be able to find a relevant category in KDE Bugzilla. If
someone can point me
