D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

2019-07-16 Thread Jonathan Rubenstein
JJRcop updated this revision to Diff 61883. JJRcop added a comment. Updated @since to 5.61. @ngraham REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20181?vs=61526&id=61883 REVISION DETAIL https://phabricator.kde.org/D20181 AFFECTED FILES READM

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

2019-07-10 Thread Jonathan Rubenstein
JJRcop added a comment. After some quick research I should have done a while ago, I have determined that KFormat is not nearly the same as what KUnitConversion does. KFormat can take an input number and output a string with the input formatted properly to the desired unit. KUnitConv

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

2019-07-10 Thread Jonathan Rubenstein
JJRcop updated this revision to Diff 61526. JJRcop added a comment. Update version number to 5.60 REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20181?vs=59308&id=61526 REVISION DETAIL https://phabricator.kde.org/D20181 AFFECTED FILES README.m

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

2019-06-07 Thread Jonathan Rubenstein
JJRcop added a comment. It does work without any other code, because of the converter addon from R114 Plasma Addons . The screenshots seen in the report were generated after building KUnitConversion with this patch on KDE neon dev with no

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

2019-06-07 Thread Jonathan Rubenstein
JJRcop added a comment. @aacid Are you asking me to use the KFormat functions for the KUnitConversion category I've created, or do you not think this should be supported by KUnitConversion at all? REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20181 To: JJ

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

2019-06-06 Thread Jonathan Rubenstein
JJRcop updated this revision to Diff 59308. JJRcop added a comment. Updated version number in comments to 5.59 since 5.58 came out earlier in May. REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20181?vs=55227&id=59308 REVISION DETAIL https://phab

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

2019-04-25 Thread Jonathan Rubenstein
JJRcop edited the test plan for this revision. JJRcop set the repository for this revision to R292 KUnitConversion. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20181 To: JJRcop, broulik, #plasma, ngraham Cc: abetts, cfeck, apol, aacid, ngraham, kde-frameworks

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

2019-04-01 Thread Jonathan Rubenstein
JJRcop added a comment. In D20181#441887 , @aacid wrote: > Can we use https://api.kde.org/frameworks/kcoreaddons/html/classKFormat.html instead of doing this again? I think that's out of scope for this patch. It should be done in another

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

2019-04-01 Thread Jonathan Rubenstein
JJRcop updated this revision to Diff 55227. JJRcop added a comment. Update @since from 5.57 to 5.58 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20181?vs=55218&id=55227 REVISION DETAIL https://phabricator.kde.org/D20181 AFFECTED FILES README.md src/CMakeLists.txt src/bina

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

2019-04-01 Thread Jonathan Rubenstein
JJRcop retitled this revision from "Adds Binary Data units (bits, kilobytes, kibibytes ... yottabytes)" to "Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)". REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20181 To: JJRcop Cc: kde-frameworks-d

D20181: Adds Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

2019-04-01 Thread Jonathan Rubenstein
JJRcop created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. JJRcop requested review of this revision. REVISION SUMMARY New data category BinaryDataCategory featuring bits and bytes, both SI units and powers of two, from normal bits all the