d on Qt+KF5"
>
> But I don't even know if e.g. LXQt wants to see the KDE File Dialog or the Qt
> File Dialog.
> -> CC'ing Jerome Leclanche for input.
>
> However, as Martin says, the *current* code is only loaded in a plasma
> session anyway (Qt looks for e.g. $X
marked as submitted.
Review request for KDE Frameworks, Localization and Translation (l10n), Albert
Astals Cid, Martin Gräßlin, and Martin Klapetek.
Changes
---
Submitted with commit 4928539a48edd4729174f9c8aa906cf63fbe1b45 by Martin
Klapetek on behalf of Jerome Leclanche to branch master
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122680/#review76863
-------
On March 2, 2015, 8:02 a.m., Jerome Leclanche wrote:
>
> -
d.cpp 4e7cb9d
src/runtime/main.cpp fdf4d62
Diff: https://git.reviewboard.kde.org/r/122680/diff/
Testing
---
Compiles and runs. No further testing done.
Thanks,
Jerome Leclanche
___
Kde-frameworks-devel mailing list
Kde-frameworks
5e4a9
src/runtime/globalshortcutsregistry.cpp 3e4d720
src/runtime/kglobalacceld.cpp 4e7cb9d
src/runtime/main.cpp fdf4d62
Diff: https://git.reviewboard.kde.org/r/122680/diff/
Testing
---
Compiles and runs. No further testing done.
Thanks,
Jerome Leclanche
___
On March 2, 2015, 4:21 a.m., Jerome Leclanche wrote:
> > Should we be using ::tr here instead of not translating at all?
Consensus on IRC six days ago was that dropping translation altogether was fine.
I can add some ::tr but it's arguable whether some of those values should
Gräßlin wrote:
> I agree that the application data needs to be set, so that bug reports in
> case of e.g. crashes work.
>
> Jerome Leclanche wrote:
> So would something like this be acceptable?
>
> ```
> app.setApplicationVersion("0.2");
>
5e4a9
src/runtime/globalshortcutsregistry.cpp 3e4d720
src/runtime/kglobalacceld.cpp 4e7cb9d
src/runtime/main.cpp fdf4d62
Diff: https://git.reviewboard.kde.org/r/122680/diff/
Testing
---
Compiles and runs. No further testing done.
Thank
Gräßlin wrote:
> I agree that the application data needs to be set, so that bug reports in
> case of e.g. crashes work.
>
> Jerome Leclanche wrote:
> So would something like this be acceptable?
>
> ```
> app.setApplicationVersion("0.2");
>
Gräßlin wrote:
> I agree that the application data needs to be set, so that bug reports in
> case of e.g. crashes work.
>
> Jerome Leclanche wrote:
> So would something like this be acceptable?
>
> ```
> app.setApplicationVersion("0.2");
>
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122680/#review76462
---
On Feb. 23, 2015, 10:34 a.m., Jerome Leclanche wrote:
>
On Feb. 23, 2015, 11:14 a.m., Jerome Leclanche wrote:
> > That said, you're removing 2 very small dependencies there...
See the lxqt issue (especially the last few comments). Plan is to remove more
dependencies one way or another, but these two are essentially free - and
althou
me/kglobalacceld.cpp 4e7cb9d
src/runtime/main.cpp fdf4d62
Diff: https://git.reviewboard.kde.org/r/122680/diff/
Testing
---
Compiles and runs. No further testing done.
Thanks,
Jerome Leclanche
___
Kde-frameworks-devel mailing list
Kde-frameworks
13 matches
Mail list logo
