mardelle closed this revision.
mardelle added a comment.
Fixed in commit
https://commits.kde.org/breeze-icons/7a7cbad866bbab362b4b27e2e283c1ff94458927
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D28273
To: mardelle, nicolasfella, ngraham
Cc: ngraham, kde-fra
mardelle created this revision.
mardelle added a reviewer: nicolasfella.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mardelle requested review of this revision.
REVISION SUMMARY
Trying to build breeze icons fails on the 24px icons generations with
follow
Ouch sorry about that! Won't be able to work on it before tomorrow afternoon at
best. Feel free to revert if you think it's best and I can work on an updated
version...
On Dec 13, 2019, 21:49, at 21:49, David Faure wrote:
>dfaure added a comment.
>
>
> It *also* broke Windows compilation:
>
>C
mardelle added a comment.
Oh sorry about that. Won't be able to work on it before sunday.. feel free to
revert if you think it's best - no computer access now... and I can work on an
updated patch...
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D24489
To: mar
mardelle added a comment.
I have now committed https://phabricator.kde.org/D24489
REPOSITORY
R244 KCoreAddons
BRANCH
l-kautosave-unittest (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25767
To: ahmadsamir, #frameworks, mpyne, dfaure
Cc: mardelle, dhaumann, dfaure
mardelle marked 3 inline comments as done.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D24489
To: mardelle, #frameworks, dfaure, mpyne
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
mardelle updated this revision to Diff 71081.
mardelle added a comment.
Update patch according to discussion.
extractManagedFilePath will be broken in case of long truncated path but that
has always been the case...
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabric
mardelle added a comment.
Oh no don't misunderstand me. I am very glad that someone else stepped up! I
have more than enough work on my plate with Kdenlive so please help :)
Hopefully David can give us some hints about the best way to move on!
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
mardelle added a comment.
The unittest is in another diff because it's a different author I guess. I
can process the comments but looking closer I found 2 other important issues in
this class:
1. When using KAutoSaveFile::staleFiles(filename) to check if there is an
existing stale file
mardelle added a reviewer: dfaure.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D24489
To: mardelle, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
mardelle created this revision.
mardelle added a reviewer: Frameworks.
mardelle added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mardelle requested review of this revision.
REVISION SUMMARY
There are 2 different issues in current code regarding maximum filename
leng
mardelle abandoned this revision.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D7954
To: mardelle, #frameworks, ilic, dfaure
Cc: michaelh
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:8ed107304694: Fix KAutoSave bug on file with white space
in it (authored by mardelle).
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8084?vs=21868&id=21898
RE
mardelle marked 2 inline comments as done.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D8084
To: mardelle, #frameworks, shaforostoff
Cc: dfaure, ngraham, cfeck, ltoscano
mardelle updated this revision to Diff 21868.
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8084?vs=20216&id=21868
REVISION DETAIL
https://phabricator.kde.org/D8084
AFFECTED FILES
autotests/kautosavefiletest.cpp
src/lib/io/kautosavefile.cpp
To: ma
mardelle added a comment.
Thanks I can confirm it is fixed with last commit.
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D8060
To: mart, dfaure, #frameworks, rikmills, davidedmundson
Cc: mardelle, davidedmundson, broulik, cfeck, #frameworks
mardelle added a comment.
Just to let you know, these last 2 commits to KIconThemes break the icon
coloring in existing apps like Kdenlive and KDevelop.
Previously, in a KXmlGuiWindow, doing:
QPalette plt = KColorScheme::createApplicationPalette(config);
setPalette(plt);
qApp->setPa
mardelle added a comment.
So did some more tests, and the loop is caused by the tb->settext() call. The
QAbstractButton setText method checks if :
d->text == text
But d->text contains the & accel marker and not text, so we end up comparing
'ren&der' with 'render' on paint, thus the loo
mardelle updated this revision to Diff 20216.
mardelle added a comment.
Added test to check stale file is correctly found
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8084?vs=20180&id=20216
REVISION DETAIL
https://phabricator.kde.org/D8084
AFFECTE
mardelle created this revision.
mardelle added reviewers: Frameworks, shaforostoff.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
KAutoSaveFile does not correctly handle simple characters like spaces in file
names!!!
When creating a stale file (backup file) , to determi
mardelle added a comment.
Not sure how to test this accelerator thing properly for a review but I would
really love to get rid of the ktoolbar hack . Can we get this patch in time for
frameworks 5.39 release, or should I commit my workaround
https://phabricator.kde.org/D7954 as a temporary f
mardelle created this revision.
mardelle added reviewers: Frameworks, ilic, dfaure.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Patch is based on https://git.reviewboard.kde.org/r/128421/
This issue - endless repaint loop when a QToolButton is embedded in a
KToolBar -
marked as submitted.
Review request for KDE Frameworks and David Faure.
Changes
---
Submitted with commit 143fbd2cd9d5698420ec246f03a4aea24d9d33b3 by Jean-Baptiste
Mardelle to branch master.
Bugs: 371685
https://bugs.kde.org/show_bug.cgi?id=371685
Repository: kio
Description
-
src/widgets/kurlrequester.h 51c1259
src/widgets/kurlrequester.cpp 62e1fea
Diff: https://git.reviewboard.kde.org/r/129986/diff/
Testing
---
Tested locally, the dialog opening from the KUrlRequester is now a proper
"save" dialog
Thanks,
Jean-Baptiste Mardelle
ard.kde.org/r/129986/diff/
Testing
---
Tested locally, the dialog opening from the KUrlRequester is now a proper
"save" dialog
Thanks,
Jean-Baptiste Mardelle
marked as submitted.
Review request for KDE Frameworks, KDE Usability and Sebastian Kügler.
Changes
---
Submitted with commit 3d28036b0ed33ef077c7df6ba30a6d4ceac61884 by Jean-Baptiste
Mardelle to branch master.
Repository: kxmlgui
Description
---
Last year, a change in
-a177d9a7b54a__about3.png
Thanks,
Jean-Baptiste Mardelle
-
About dialog with version
https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/c02f4767-2a74-4c25-8599-de410678867e__about.png
Updated patch
https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/ee13cb47-2162-4be7-8255-3dce7f470c2b__about2.png
Thanks,
Jean-Baptiste Mardelle
/2016/12/03/c02f4767-2a74-4c25-8599-de410678867e__about.png
Updated patch
https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/ee13cb47-2162-4be7-8255-3dce7f470c2b__about2.png
Thanks,
Jean-Baptiste Mardelle
ttachments
About dialog with version
https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/c02f4767-2a74-4c25-8599-de410678867e__about.png
Thanks,
Jean-Baptiste Mardelle
://git.reviewboard.kde.org/r/129607/diff/
Testing
---
Reverts a recent change, tested and works.
File Attachments
About dialog with version
https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/c02f4767-2a74-4c25-8599-de410678867e__about.png
Thanks,
Jean-Baptiste
toolbar_p.h 73152ef
Diff: https://git.reviewboard.kde.org/r/126184/diff/
Testing
---
Tested, fixes the reported problem.
Thanks,
Jean-Baptiste Mardelle
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
.kde.org/r/126184/diff/
Testing
---
Tested, fixes the reported problem.
Thanks,
Jean-Baptiste Mardelle
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
et->save triggers ui
rebuild), but signal is not emitted.
My solution is to rebuild ui only if something changed when clicking "ok".
Diffs
-
src/kedittoolbar.cpp ba4ba0f
Diff: https://git.reviewboard.kde.org/r/126184/diff/
Testing
---
Tested, fixes the reported problem.
with this patch.
I would really like to have it included in KDE Frameworks 5.15 because having
our apps randomly freeze is a really big problem.
- Jean-Baptiste Mardelle
On Sept. 13, 2015, 12:18 a.m., Xuetian Weng wrote:
>
> ---
at the code but
unless someone comes up quickly with a better fix, this workaround is really
needed by our users who are very frustrated by invisible open/save dialog
- Jean-Baptiste Mardelle
On Sept. 12, 2015, 9:40 p.m., Xuetian Weng wrote
> On Sept. 11, 2015, 10:02 a.m., Luca Beltrame wrote:
> > +1
>
> Jean-Baptiste Mardelle wrote:
> Kdenlive is also affected by this issue, as described in bug #346413
> Pressing "Esc" allows to dismiss the invisible file dialog and regain
> control of t
> On Sept. 11, 2015, 10:02 a.m., Luca Beltrame wrote:
> > +1
Kdenlive is also affected by this issue, as described in bug #346413
Pressing "Esc" allows to dismiss the invisible file dialog and regain control
of the app.
However I tested the proposed patch and it does not solve the problem for m
sted on my system, but maybe there is a better way
to fix it ?
Thanks,
Jean-Baptiste Mardelle
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
dmit I don't understand all the logic behind the original code.
However, your patch proposal fixes my bug, so it's perfect for me if you want
to commit it.
- Jean-Baptiste
---
This is an automatically generated e-mail. To reply,
g).
Updated patch attached.
- Jean-Baptiste
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125051/#review84856
---
On Sept. 4,
urns empty filename
Diffs (updated)
-
src/filewidgets/kfilewidget.cpp dc3c1f4
Diff: https://git.reviewboard.kde.org/r/125051/diff/
Testing
---
Patch fixes issue #350696, tested on my system, but maybe there is a better way
to fix it ?
Thanks,
Jean-Baptist
ilewidgets/kfilewidget.cpp dc3c1f4
Diff: https://git.reviewboard.kde.org/r/125051/diff/
Testing
---
Patch fixes issue #350696, tested on my system, but maybe there is a better way
to fix it ?
Thanks,
Jean-Baptiste Mardelle
___
Kde-frameworks-dev
iff: https://git.reviewboard.kde.org/r/125051/diff/
Testing
---
Patch fixes issue #350696, tested on my system, but maybe there is a better way
to fix it ?
Thanks,
Jean-Baptiste Mardelle
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde
44 matches
Mail list logo
