D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

intelfx added a comment. In D5802#349761 , @dhaumann wrote: > - just because we cannot match a theme 100% does not imply that we have to adapt our implementation (there will always be a color in theme xy that does not properly exist in KTextEdito

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

intelfx added a comment. @cullmann So, how do you propose to port Solarized to Kate/KDevelop then? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5802 To: intelfx, #kdevelop, #ktexteditor, #kate, mwolff Cc: cullmann, kde-frameworks-devel, brauch, dhaumann, mwolff

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

intelfx added a comment. @mwolff @dhaumann @brauch I'm sorry for my silence — I stopped using KDE/KDevelop some time ago and did not track this changeset properly. Could you please reiterate what was the conclusion and what were @mwolff's requested changes? > The idea is to have just on

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

intelfx added a comment. In https://phabricator.kde.org/D5802#109416, @mwolff wrote: > Then I can also apply the patch locally and try it out myself and maybe come up with a concrete idea to fix this all. So, do you have any ideas? REPOSITORY R39 KTextEditor REVISION DETAIL

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

intelfx added a comment. In https://phabricator.kde.org/D5802#109416, @mwolff wrote: > For solarized you showed the screenshots in your original mail. I'm more concerned about backwards compatibility with other schemes. I.e. yes - we do care about the status quo. Can you give an example

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

intelfx added a comment. In https://phabricator.kde.org/D5802#109403, @mwolff wrote: > Hey there, > > sorry for the long delay. In general this sounds like a good idea. But what do you mean by "However, just making that change will make Kate/KDevelop incompatible with all existing co

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

intelfx edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5802 To: intelfx, #kdevelop, #ktexteditor, #kate Cc: kwrite-devel, #frameworks

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

intelfx edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5802 To: intelfx, #kdevelop, #ktexteditor, #kate Cc: kwrite-devel, #frameworks

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

intelfx created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY This is not an actual pull-request but rather an RFC (request for comments) from the KTextEditor, Kate and KDevelop developer