Git commit f3b284f5654372adec44dbc6863b8434b6b4f3ce by Ivan Romanov.
Committed on 10/08/2014 at 10:38.
Pushed by iromanov into branch 'master'.
cmake: install export targets to lib dir
share/cmake is wrong place for generated cmake files. For such files
should be used lib/cmake di
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115540/#review49463
---
Ship it!
Ship It!
- Ivan Romanov
On Feb. 10, 2014, 11:35
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115540/#review49457
---
Add explanation for #define
- Ivan Romanov
On Feb. 10
> On Feb. 8, 2014, 6:42 p.m., Ivan Romanov wrote:
> > Use tabs (not spaces) for intendation. Also split very long lines.
*indentation
- Ivan
---
This is an automatically generated e-mail. To reply, vis
lines.
- Ivan Romanov
On Feb. 7, 2014, 10:54 p.m., Teo Mrnjavac wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115050/#review47554
---
Ship it!
I will commit this.
- Ivan Romanov
On Jan. 17
code should be
placed in if()...else()...endif() blocks
So move set(QCA_QT_PC_VERSION "QtCore") to else(Qt5Core_FOUND).
- Ivan Romanov
On Jan. 16, 2014, 7:04 p.m., Uwe L. Korn wrote:
>
> ---
> This is an automatically g
> On Oct. 13, 2013, 11:03 p.m., Ivan Romanov wrote:
> > Two issues.
> >
> > 1. all means all possible not all of them. If I haven't nss on my system
> > qca-nss plugin won't built but all others will be built.
> > 2. In INSTALL instructions.
>
efault: "")
must be
BUILD_PLUGINS - define which plugins should be built in a semicolon
separated list or "all" if you want to build all *possible* of
them (by default: "*all*")
- Ivan Romano
UGINS is a list not an option, use
set(BUILD_PLUGINS "all" CACHE STRING "..."). Correct INSTALL, BUILD_PLUGINS
must be 'all' by default.
Also cmake must be fail if BUILD_PLUGINS it not 'all' and some plugin can't be
built.
- Ivan R
please add description of -DBUILD_PLUGINS in INSTALL
instructions.
- Ivan Romanov
On Sept. 28, 2013, 7:15 p.m., Uwe L. Korn wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
var.
- Ivan Romanov
On Sept. 22, 2013, 12:54 a.m., Uwe L. Korn wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.
> On Sept. 1, 2013, 11:16 p.m., David Faure wrote:
> > Looks fine to me.
>
> Ivan Romanov wrote:
> I don't agree with this patch. I didn't get any notification about this.
> So I very ask you before do any changes in cmake rules talk with me. It is
>
> On Sept. 1, 2013, 11:16 p.m., David Faure wrote:
> > Looks fine to me.
>
> Ivan Romanov wrote:
> I don't agree with this patch. I didn't get any notification about this.
> So I very ask you before do any changes in cmake rules talk with me. It is
>
> On Sept. 1, 2013, 11:16 p.m., David Faure wrote:
> > Looks fine to me.
>
> Ivan Romanov wrote:
> I don't agree with this patch. I didn't get any notification about this.
> So I very ask you before do any changes in cmake rules talk with me. It is
>
> On Sept. 1, 2013, 11:16 p.m., David Faure wrote:
> > Looks fine to me.
>
> Ivan Romanov wrote:
> I don't agree with this patch. I didn't get any notification about this.
> So I very ask you before do any changes in cmake rules talk with me. It is
>
> On Sept. 1, 2013, 11:16 p.m., David Faure wrote:
> > Looks fine to me.
>
> Ivan Romanov wrote:
> I don't agree with this patch. I didn't get any notification about this.
> So I very ask you before do any changes in cmake rules talk with me. It is
>
> On Sept. 1, 2013, 11:16 p.m., David Faure wrote:
> > Looks fine to me.
>
> Ivan Romanov wrote:
> I don't agree with this patch. I didn't get any notification about this.
> So I very ask you before do any changes in cmake rules talk with me. It is
>
> On Sept. 1, 2013, 11:16 p.m., David Faure wrote:
> > Looks fine to me.
>
> Ivan Romanov wrote:
> I don't agree with this patch. I didn't get any notification about this.
> So I very ask you before do any changes in cmake rules talk with me. It is
>
> On Sept. 1, 2013, 5:16 p.m., David Faure wrote:
> > Looks fine to me.
>
> Ivan Romanov wrote:
> I don't agree with this patch. I didn't get any notification about this.
> So I very ask you before do any changes in cmake rules talk with me. It is
>
> On Sept. 1, 2013, 5:16 p.m., David Faure wrote:
> > Looks fine to me.
>
> Ivan Romanov wrote:
> I don't agree with this patch. I didn't get any notification about this.
> So I very ask you before do any changes in cmake rules talk with me. It is
>
er Richardson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111938/
> ---
>
> (Updated Sept. 3, 2013, 12:42 p.m.)
>
>
> R
22 matches
Mail list logo
