This revision was automatically updated to reflect the committed changes.
Closed by commit R320:4ec12a850e25: fix preview of plain text files when using
dark theme (authored by iliakats).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25891?vs=71295&id=7131
iliakats updated this revision to Diff 71295.
iliakats added a comment.
performance improvement: only do one round of highlighting (skip the one run
in the constructor of QSyntaxHighlighter)
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25891?vs=71288&
iliakats added a reviewer: Dolphin.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D25891
To: iliakats, #dolphin
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n,
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh,
spo
iliakats created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
iliakats requested review of this revision.
REVISION SUMMARY
When using a dark theme, plain text files without an associated highlighting
theme are rendered in
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 2ce45131cd42128628ed756605676f40a68a87ae by Ilia Kats to
branch master.
Repository: kio
Description
---
previously, two clicked() events were emitted upon middle click, one with
Qt
> On Oct. 26, 2015, 1:56 p.m., Martin Klapetek wrote:
> > Looks good to me
> >
> > Do you have commit access?
>
> Ilia Kats wrote:
> I think so, yes, although I have not used it for quite a while. Should I
> try to push and see what happens?
>
> M
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125779/#review87425
---
On Oct. 25, 2015, 8:23 a.m., Ilia Kats wrote:
>
> -
/125779/diff/
Testing
---
Opened Dolphin, tried left/right/middle click on the menu -> behaves as
expected.
Thanks,
Ilia Kats
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-framewo
as
expected.
Thanks,
Ilia Kats
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
