Re: Review Request 118362: handle the case of exact timeouts correctly

2014-05-31 Thread Ian Monroe
--- Thanks, Ian Monroe ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118362: handle the case of exact timeouts correctly

2014-05-27 Thread Ian Monroe
--- handle the case of exact timeouts correctly Diffs - src/widgetbasedpoller.cpp 81d352953d38f625885602c4bfcfbc2a9eee1874 Diff: https://git.reviewboard.kde.org/r/118362/diff/ Testing --- Thanks, Ian Monroe ___ Kde-frameworks-devel

Re: Review Request 110842: Add reviewboardrc file

2013-06-05 Thread Ian Monroe
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110842/#review33822 --- Ship it! Yes please. - Ian Monroe On June 5, 2013, 8:32

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

2013-05-21 Thread Ian Monroe
that's just legacy of some intrepid KDAB porting. - Ian Monroe On May 21, 2013, 12:45 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.

Fwd: please make it easier to hack on frameworks

2013-05-20 Thread Ian Monroe
On Mon, May 20, 2013 at 6:17 AM, Alexander Neundorf wrote: > > On Tuesday 14 May 2013, Alexander Neundorf wrote: > > On Tuesday 14 May 2013, Stephen Kelly wrote: > > > Alexander Neundorf wrote: > > > > Additionally we don't check in cmake that the Qt which has been found > > > > is good enough. >

Fwd: please make it easier to hack on frameworks

2013-05-20 Thread Ian Monroe
On Mon, May 20, 2013 at 8:28 AM, David Faure wrote: ... > qt5.git defines which sha1 of the submodules you should get. It hasn't been updated in a month. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/lis

Re: Review Request 110529: more error handling in KIdleTime

2013-05-19 Thread Ian Monroe
: http://git.reviewboard.kde.org/r/110529/diff/ Testing --- Thanks, Ian Monroe ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request: Always use cmake's internal automoc support.

2012-10-20 Thread Ian Monroe
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106958/#review20602 --- Ship it! Ship It! - Ian Monroe On Oct. 20, 2012, 6:32 p.m