Re: KDE Frameworks with failing CI (master) (5 January 2024)

On Sun, Jan 5, 2025 at 12:11 PM Albert Astals Cid wrote: > knewstuff - 2nd week > * https://invent.kde.org/frameworks/knewstuff/-/pipelines/856702 > * knewstuff-atticaprovidertest is failing > Something changed server side? Although our code is also meh. https://invent.kde.org/frameworks/kne

Re: Unexpected behavior in KIO::MimeTypeFinderJob

On Wed, Aug 7, 2024 at 6:24 PM David Faure wrote: > > On mercredi 7 août 2024 15:53:37 heure d’été d’Europe centrale Harald Sitter > wrote: > > On Wed, Aug 7, 2024 at 12:10 PM David Faure wrote: > > > On mercredi 7 août 2024 11:54:20 heure d’été d’Europe centrale David

Re: Unexpected behavior in KIO::MimeTypeFinderJob

On Wed, Aug 7, 2024 at 12:10 PM David Faure wrote: > > On mercredi 7 août 2024 11:54:20 heure d’été d’Europe centrale David Faure > wrote: > > On mercredi 7 août 2024 08:30:43 heure d’été d’Europe centrale Stefano > > Crocco > > wrote: > > > Hello to everyone, > > > while investigating a bug in Ko

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

On Mon, Nov 13, 2023 at 4:45 PM wrote: > Baloo is under-maintained and it was never in any good state as the > initial author left it in an state of limbo and vanished. A bit off topic but maybe it'd be a good idea to talk to the tracker developers about pooling resources and join their efforts.

Re: Breeze and ECM are incompatible for installing icons

https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html > Each directory contains icons designed for a certain nominal icon size and > scale, as described by the index.theme file ... > list of subdirectories for this theme. For every subdirectory there must be a > sect

Re: kio-extras and the KF5/KF6 period

On Tue, Jun 20, 2023 at 11:23 PM Sune Vuorela wrote: > > On 2023-06-20, David Redondo wrote: > > Harald and I prototyped another solution to build a Qt > > 5 and Qt 6 version out of the same repo and employed it on > > plasma-integration: https://invent.kde.org/plasma/plasma-integration/-/ > > m

Re: kio-extras and the KF5/KF6 period

On Tue, Jun 20, 2023 at 3:46 PM Luigi Toscano wrote: > > Harald Sitter ha scritto: > > On Tue, Jun 20, 2023 at 2:58 PM Luigi Toscano > > wrote: > >> > >> David Redondo ha scritto: > >>> Am Mittwoch, 17. Mai 2023, 00:02:18 CEST schrieb Albert As

Re: kio-extras and the KF5/KF6 period

On Tue, Jun 20, 2023 at 2:58 PM Luigi Toscano wrote: > > David Redondo ha scritto: > > Am Mittwoch, 17. Mai 2023, 00:02:18 CEST schrieb Albert Astals Cid: > >> kio-extras provides plugins for kio. > >> > >> So KF5 applications want a KF5 kio-extras and KF6 applications want a KF6 > >> kio- extras.

Re: kf6 vs. kf5 conflict report

On Mon, Mar 20, 2023 at 6:21 PM Luigi Toscano wrote: > > Harald Sitter ha scritto: > > Salut, > > > > Conflict reports are now available form neon ci and can be triggered > > by yourself. They are usually lagging a day behind as automatic binary > > builds on

Re: kf6 vs. kf5 conflict report

Salut, Conflict reports are now available form neon ci and can be triggered by yourself. They are usually lagging a day behind as automatic binary builds only occur once a day. Notable changes from last time are that ECM is skipped as a whole and locale conflicts have been resolved. Much smaller

kf6 vs. kf5 conflict report

with kf6 progressing nicely here's a first conflict report of files that appear in both kf6 and kf5 under the same name. this largely affects translations and docs it seems. this list may not be entirely comprehensive, I've only thrown together a script in a couple minutes. one question is whether

Re: flag icon replacement

I've started https://invent.kde.org/frameworks/kguiaddons/-/merge_requests/95 On Tue, Feb 21, 2023 at 4:38 PM Volker Krause wrote: > > On Dienstag, 21. Februar 2023 14:08:27 CET Harald Sitter wrote: > > Our keyboard indicator thingy in plasma is implicitly depending on &g

flag icon replacement

Yo Our keyboard indicator thingy in plasma is implicitly depending on flag icons from kdelibs4support. We kinda need a replacement. I've done some prototyping on using emojis instead. Should we pursue that approach? and if so where should we put the engine https://phabricator.kde.org/T13722#286177

Re: portal drag and drop helpers and where to put them

On Tue, Apr 12, 2022 at 10:09 PM Volker Krause wrote: > > On Mittwoch, 6. April 2022 13:28:50 CEST Harald Sitter wrote: > > https://invent.kde.org/frameworks/kcoreaddons/-/merge_requests/212 > > > > To get sandboxed apps to work with drag and drop we need to have dr

Re: portal drag and drop helpers and where to put them

On Tue, Apr 12, 2022 at 2:12 AM Aleix Pol wrote: > > Maybe the alternative would be to use the kdbusaddons for this? It > seems to me like there's no kcoreaddons things being done. I've thought about that but ultimately concluded kdbusaddons actually doesn't work for us. The way the technology wo

portal drag and drop helpers and where to put them

https://invent.kde.org/frameworks/kcoreaddons/-/merge_requests/212 To get sandboxed apps to work with drag and drop we need to have drags take a roundtrip through xdg-desktop-portal and unfortunately enough that needs to happen by passing an open fd into the relevant API, presumably to demonstrate

Re: Critical Denial of Service bugs in Discover

On Mon, Feb 21, 2022 at 11:05 AM Ben Cooksley wrote: > > On Mon, Feb 21, 2022 at 10:01 PM Harald Sitter wrote: >> >> On Thu, Feb 10, 2022 at 1:11 PM Aleix Pol wrote: >> > >> > On Thu, Feb 10, 2022 at 11:05 AM Ben Cooksley wrote: >> > > >> &

Re: Critical Denial of Service bugs in Discover

On Thu, Feb 10, 2022 at 1:11 PM Aleix Pol wrote: > > On Thu, Feb 10, 2022 at 11:05 AM Ben Cooksley wrote: > > > > > > > > On Thu, Feb 10, 2022 at 8:20 AM Aleix Pol wrote: > >> > >> [Snip] > >> > >> We still haven't discussed here is how to prevent this problem from > >> happening again. > >> > >

FYI neon unstable's kio is now building polkit branch

ahoy to enable easier testing of https://invent.kde.org/frameworks/kio/-/merge_requests/143 KIO in the neon **unstable** edition is now building work/privilegeexecution instead of master. this is particularly of note for bug reports! HS

Re: Extending the license policy to include ODbL-1.0

+1 On Wed, Sep 15, 2021 at 5:27 PM Volker Krause wrote: > > Hi, > > there's a MR [1] for ki18n containing data tables generated from OSM data, > which implies the ODbL-1.0 license [2]. We also already have other places > ([3], [4]) actually doing this. > > However that's a license not yet covered

Re: KDE CI: Administration » Dependency Build Extragear stable-kf5-qt5 WindowsMSVCQt5.15 - Build # 53 - Still Failing!

comparing the failing build to the last successful one it appears kdewin no longer installs arpa/inet.h which lead me to this commit https://invent.kde.org/packaging/kdewin/-/commit/25a254ab3ab0369e235db7418ac9b95226445a38 which seems a bit folly because it makes the installation conditional on ine

Re: Including instead of , does it upset POSIX?

header, but are all > * contained in the namespace @c std (except for names which are defined > * as macros in C). > */ > > > And then I made similar commits to a lot of the other Frameworks (not all, > since the build failed > for some of them, so I left them alone)

Re: Including instead of , does it upset POSIX?

FWIW this goes beyond errno. See clang-tidy's modernize-deprecated-headers for a comprehensive list HS

Re: Merge tags in master branch?

Hej On 23.11.20 16:11, Bhushan Shah wrote: > Hello, > > So I have one question regarding the how we do the framework versioning. > Namely the tags, > > So currently some packages have a versioned tags on their master branch, > > i.e > > karchive: > > ➜ git describe > v5.76.0-1-g7304c28 > > W

D28745: Skip caching thumbnails on encrypted filesystems

sitter added a comment. > Could this be delegated onto someone who knows Solid or should I try figuring it out by myself? Alas, I'm not sure there is anyone who feels responsible enough for solid, so you'll probably have to give it a go yourself. REPOSITORY R320 KIO Extras REVISION D

D28745: Skip caching thumbnails on encrypted filesystems

sitter added a comment. In D28745#676452 , @marcingu wrote: > !PING. > I need help from someone with good understanding of Solid to continue. > > I'm don't know how to determinate if StorageAccess device is encrypted or not. I wanted to us

D28855: put minimumkeepsize actually in the netpref KCM

sitter abandoned this revision. sitter added a comment. moved to https://invent.kde.org/frameworks/kio/-/merge_requests/123 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28855 To: sitter, ngraham, dfaure Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh

Re: Extend metainfo.yaml files with License Information

On Mon, Aug 17, 2020 at 8:24 PM Andreas Cord-Landwehr wrote: > > Thanks! I will answer inline: > > On Montag, 17. August 2020 17:47:40 CEST Harald Sitter wrote: > [...] > > > **First question:** Shall we only list ONE or ALL licenses, same for the > > > license in

Re: Extend metainfo.yaml files with License Information

On Mon, Aug 17, 2020 at 2:16 PM Andreas Cord-Landwehr wrote: > > Hi, I am currently looking into extending our metainfo.yaml files to provide > information about the outbound licenses of the artefacts that are provided by > a framework. Here a few examples: > > Attica: Provides libattica, which is

D7563: Add privilegeExecution field to file protocol description

sitter added a comment. In D7563#676151 , @cblack wrote: > In D7563#674682 , @sitter wrote: > > > This really cannot land right now IMHO. Dolphin can actually deadlock itself because it uses way too mu

D7563: Add privilegeExecution field to file protocol description

sitter added inline comments. INLINE COMMENTS > file_unix.cpp:1372 > +break; > +default: > +Q_UNREACHABLE(); I'd advise handling default cases. The compiler can no longer warn of unhandled enum values when default is used. Instead I'd convert the entire switch into a helper

Re: Policy on forward declarations for things from external libraries

On Fri, Jul 31, 2020 at 5:56 PM Vlad Zahorodnii wrote: > > Howdy, > > From time to time, I find myself in a situation where a code reviewer > suggests to replace #include with the corresponding class > forward declaration. Such discussions usually get us nowhere because > neither the code review

Re: xml_mimetypes5 and kcoreaddons

On Sun, Jul 19, 2020 at 1:56 PM David Faure wrote: > > On mercredi 15 juillet 2020 12:24:34 CEST Harald Sitter wrote: > > On Wed, Jul 15, 2020 at 12:39 AM David Faure wrote: > > > On mardi 14 juillet 2020 19:35:41 CEST Albert Astals Cid wrote: > > > > El dimart

Re: xml_mimetypes5 and kcoreaddons

On Wed, Jul 15, 2020 at 12:39 AM David Faure wrote: > > On mardi 14 juillet 2020 19:35:41 CEST Albert Astals Cid wrote: > > El dimarts, 14 de juliol de 2020, a les 15:14:38 CEST, Jonathan Riddell va > escriure: > > > We're playing with translations in neon packages and looking at > > > kcoreaddons

D7563: Add privilegeExecution field to file protocol description

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. This really cannot land right now IMHO. Dolphin can actually deadlock itself because it uses way too much nested event looping and will be entirely unresponsive to mouse inputs wh

D29745: look for kded as runtime dep

This revision was automatically updated to reflect the committed changes. Closed by commit R241:15869b83200f: look for kded as runtime dep (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29745?vs=82839&id=83201 REVISION DETAIL https://phabr

Re: Recent breakage in kwallet

here's my understanding of the problem: firstly, this is likely only a problem on debian-derived systems. and also only with blowfish debian has this patch [1] which on *actual* little endian systems (x86,arm64...) would run the conditional branches. the thing to note is that not only QBO is defi

D29381: Thumbnail text: use libmagic to detect encoding

sitter added a comment. Browsing the code it looks like it mmaps the file though? And when I add some strategic sleeping I can verify that file goes towards shared memory. Oh, I suppose the trouble is that load gets called each ::create? Simply wrap it in a cpp class and static scope it

D29381: Thumbnail text: use libmagic to detect encoding

sitter added a comment. LGTM. Seeing as I don't have much background knowledge I'm not comfortable accepting though. I guess if nobody comes up with better options by next week feel free to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29381 To: meven, #

D29743: sftp: map sftp_open error to kio error

This revision was automatically updated to reflect the committed changes. Closed by commit R320:07e44cb1b536: sftp: map sftp_open error to kio error (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29743?vs=82835&id=82903 REVISION DETAI

D29745: look for kded as runtime dep

sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY kded is called over dbus to talk to the proxyscout, and also to track uidelegate window

D29743: sftp: map sftp_open error to kio error

sitter created this revision. sitter added a reviewer: feverfew. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY sftp gives out more relevant errors such as SSH_FX_PERMISSION_DENIED,

D29634: sftp: break large writes into multiple requests

This revision was automatically updated to reflect the committed changes. Closed by commit R320:1df6174834bb: sftp: break large writes into multiple requests (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29634?vs=82723&id=82834 REVIS

D29526: Thumbnails: make thumbnail generation dpr-aware

sitter added a comment. You do seem to calculate the deviceWidth and height an awful lot, it makes reading a bit clunky. I'd much rather have the multiplication done once and then always use the var instead. In fact, perhaps it'd make sense to have createV3 feed the values into the implement

D29634: sftp: break large writes into multiple requests

sitter edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29634 To: sitter, ngraham, meven Cc: meven, feverfew, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack,

D29634: sftp: break large writes into multiple requests

sitter updated this revision to Diff 82723. sitter added a comment. - rejigger write segmentation into new sftpWrite function used by both the put() and write() - fix length calculation - refine buf size comment REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator

D29634: sftp: break large writes into multiple requests

sitter added inline comments. INLINE COMMENTS > meven wrote in kio_sftp.cpp:58 > Why not change it now to 32 * 1024 then ? > I guess you tested this value works at least with openssh. > > I guess the best solution would be to ask/figure out the server buffer size. > > What does gvfs, or other

D29634: sftp: break large writes into multiple requests

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY servers have arbitrary limits that we should stay below. to ensure thi

D29461: Fix kio-extras build on Windows

sitter added a comment. Pid changes look fine, though perhaps we should just throw those two lines away? With Qt5 logging the pid is fairly pointless because one can simply set QT_MESSAGE_PATTERN to include the pid when necessary https://doc.qt.io/qt-5/qtglobal.html#qSetMessagePattern INLIN

D29381: Thumbnail text: use libmagic to detect encoding

sitter added inline comments. INLINE COMMENTS > meven wrote in textcreator.cpp:38 > Without libmagic, it is current state basically UTF-8 with bom detection > otherwise local codec. > > I did not test exhaustive encodings so I wanted to let the door open for > users to not rely on libmagic. >

D29381: Thumbnail text: use libmagic to detect encoding

sitter added a comment. I have zero background knowledge here, but it really feels like there must be an existing solution to this problem other than libmagic. Like how does kate figure out the encoding of a text file. INLINE COMMENTS > Findlibmagic.cmake:1 > +# - Try to find libssh > +# On

D29149: Fix kio-extras compilation with -DQT_NO_CAST_TO_ASCII

sitter added inline comments. INLINE COMMENTS > dfaure wrote in CMakeLists.txt:60 > Isn't that what I did here? Now all of kio-extras gets that flag. > > And BTW everything built by kdesrc-build actually builds with this flag > (since I have it in my kdesrc-buildrc). But that doesn't allow sett

D29149: Fix kio-extras compilation with -DQT_NO_CAST_TO_ASCII

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Sure, I was referring to the smb module, not even kio-extras as a whole. ^^ Anyway, diff looks reasonable. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabr

D29149: Fix kio-extras compilation with -DQT_NO_CAST_TO_ASCII

sitter added a comment. Shouldn't we just make the entire thing QT_NO_CAST_TO_ASCII by default? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29149 To: dfaure, thiago, sitter Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fpr

D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

sitter added a comment. Looks reasonable. @apol thoughts? REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D29063 To: kossebau, #frameworks, mart, apol, sitter, bcooksley Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28909: smb: port to Result system to force serialization of error/finish condition

sitter added inline comments. INLINE COMMENTS > dfaure wrote in kio_smb.h:96 > Whenever we port a 3rd slave to it ;-) Sure, if you think it's solid enough from an API POV. I was thinking that we should amend the slavebase API for KF6 in general. Instead of having error/finished/opened all func

D6794: assert the testpackage appstream data validates

sitter added a comment. @bcooksley I would think the CI image needs to ship some general purpose schemas. install https://software.opensuse.org/package/gsettings-desktop-schemas I guess. If it's still not working right with that installed I can take a look at what's missing. The warning

D28909: smb: port to Result system to force serialization of error/finish condition

sitter created this revision. sitter added a reviewer: dfaure. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the Result system was originally introduced to the FTP slave and now al

D28855: put minimumkeepsize actually in the netpref KCM

sitter added a comment. Coding style is actually wildly inconsistent in that file, so I've stuck to what similar other lines have. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28855 To: sitter, ngraham, dfaure Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack,

D28855: put minimumkeepsize actually in the netpref KCM

sitter added a comment. And didn't we have a better spinny box for byte units somewhere? Where the user can put `1 byte` or `1 kib` or `1 gib` and the box knows what to do? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28855 To: sitter, ngraham, dfaure Cc: kde-framewo

D28855: put minimumkeepsize actually in the netpref KCM

sitter added a comment. F8240046: Screenshot_20200415_164836.png I'm very open for better labels, it's a horrible concept to explain in a few words. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28855 To: sitter, ngraham, d

D28855: put minimumkeepsize actually in the netpref KCM

sitter updated this revision to Diff 80204. sitter added a comment. improve label a tad REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28855?vs=80203&id=80204 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28855 AFFECTED FILES src/kcms/kio/

D28855: put minimumkeepsize actually in the netpref KCM

sitter created this revision. sitter added reviewers: ngraham, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY I didn't even know it was a thing! by the looks of it the setting only applies

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

sitter added a comment. Hm. So, this is a bit complicated I've noticed. Let's consider the following cases: - `desktop:` is not a local file but can set and read dir icons without penalty - `camera:` is not a local file AND `Class=:local` BUT (I think?) cannot set dir icons as it

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

sitter added a comment. Looks reasonable. Though... Shouldn't that rather be any protocol that isn't `file`? Or at least all that are remote? (assuming we have a way of telling which slaves are remote) If I open sftp it also shows no dir icons yet lets me set one. REPOSITORY R241 KIO

D28336: Drop klauncher usage from KCrash

sitter accepted this revision. sitter added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kcrash.cpp:627 > > void KCrash::startProcess(int argc, const char *argv[], bool waitAndExit) > { This seems to serve no purpose anymore. startProcessInternal could

D28463: do not install testengine

This revision was automatically updated to reflect the committed changes. Closed by commit R242:6e39c1de5bb3: do not install testengine (authored by sitter). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28463?vs=78974&id=79464 REVISION DE

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

This revision was automatically updated to reflect the committed changes. Closed by commit R320:daec307b59e9: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28513?vs=7

D27804: smb: add hack to support spaces in workgroup names

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R320:f40191a147c9: smb: add hack to support spaces in workgroup names (authored by sitter). CHANGED PRIOR TO COMMIT https

D27902: smb: figure out the best host to use for the UDS_URL

sitter abandoned this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27902 To: sitter, ngraham, dfaure Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverf

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

sitter updated this revision to Diff 79234. sitter added a comment. chop instead of convoluted remove REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28513?vs=79220&id=79234 BRANCH smb-lazy-resolve REVISION DETAIL https://phabricator.kde.org/D28513

D27504: smb faster copy to local

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R320:46b5fb425c14: smb: fast copy (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://ph

D27504: smb faster copy to local

sitter edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To: sitter, ngraham, cfeck, #frameworks, #dolphin Cc: mmustac, meven, hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasens

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

sitter added inline comments. INLINE COMMENTS > kossebau wrote in kio_smb_browse.cpp:239 > `QString::remove()` operates on the object itself, no need to assign back to > host. > > Besides, why not use `QString::chop(wsdSuffix.size())` ? Mh. Good point indeed, I'll move to chop. Thanks! REPOSI

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

sitter updated this revision to Diff 79220. sitter added a comment. reshuffle: instead of using .local directly use a fake .kio-disocvery-wsd suffix. look for that at listing time and redirect to name.local or name as appropriate this prevents dnssd results form incorrectly getting run t

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

sitter retitled this revision from "smb: use prettyname.local for hostname of wsdiscoveries" to "smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries". sitter edited the summary of this revision. REPOSITORY R320 KIO Extras BRANCH smb-lazy-resolve REVISION DETAIL https://ph

D28513: smb: use prettyname.local for hostname of wsdiscoveries

sitter added a comment. Stable was the plan, yes. I've thought of some complications with this approach though. Actually a combination of two 1. the .local match also applies to dnssd 2. all linux VMs I've checked wouldn't be able to resolve netbios names natively as the relevant

D28513: smb: use prettyname.local for hostname of wsdiscoveries

sitter added a comment. Competes with D27902 While this diff runs the risk of not being able to resolve 100% of the time (sans ip address fallback in listDir) it has the huge advantage that discovery isn't getting super slow when multiple wsd hosts are f

D28513: smb: use prettyname.local for hostname of wsdiscoveries

sitter created this revision. sitter added reviewers: ngraham, meven. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY previously we simply used the ip address. this is fairly awkward

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:131 > I got the impression you liked being lax. Guess only when the shoe is on the > other foot. I do like being lax! I literally gave you a ship it despite your comment being literally wrong. Picking on useless c

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:131 > You let the old comment pass without any further remarks, but now you start > nitpicking? > > From the acessibility viewpoint of the mount, it is unique. The previous comment was factually correct, it never

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH fix_comment REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven, broulik, sitter Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:131 > The first mount is no longer visible, it is shadowed by the first one. You > can not read any files from it or write to it. You can not unmount it. The comment is still wrong. REPOSITORY R245 Solid REVIS

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:131 > Of course they are - you can just mount one fs at a path at any time. λ ajax ~ → sudo mount -t cifs //bear.local/foo /mnt -o user=me λ ajax ~ → sudo mount -t cifs //bear.local/foo /mnt -o user=

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter requested changes to this revision. sitter added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fstabhandling.cpp:131 > +// for different users. Make sure it is unique by appending the > +// mountpoint (which is unique). > +return source + QLa

D28476: Samba: Ensure to differenciate mounts sharing the same source

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. You know, I may have noticed this when working on kinfocenter and then quickly forgotten about it again 😂 Good stuff! REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://

D28463: do not install testengine

sitter created this revision. sitter added a reviewer: mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY by default users have to opt out of BUILD_TESTING meaning everyone would by default build

D28129: Read the new message string after rather than before

sitter accepted this revision. sitter added a comment. Mind the comment about the +2 please. Other than that looks reasonable. INLINE COMMENTS > backtraceparsergdb.cpp:215 > +case BacktraceLine::Info: > +d->m_infoLines << line.toString().mid(KCRASH_INFO_MESSAGE.size() + > 2)

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

sitter added a comment. In D28161#634951 , @ahmadsamir wrote: > > Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client > > That's confusing; but OK, I'll

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

sitter added a comment. Looks good to me, not that this means much with regular expressions. The lack of tests on this stuff makes me sad :(( Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client REPOS

D27902: smb: figure out the best host to use for the UDS_URL

sitter added a comment. I've actually had a better idea! Well kinda and it may be trickier to do. We could move the resolution dance to actual resolution time so it stops having impact on discovery. i.e. we just always use `"smb://" + m_prettyName + ".local"` as UDS_URL for discovery.

D27872: sftp: fix partial transfer resuming when copying to local

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R320:8a04e1009130: sftp: fix partial transfer resuming when copying to local (authored by sitter). CHANGED PRIOR TO COMMI

D27873: sftp: do not show creation time when we do not know it

This revision was automatically updated to reflect the committed changes. Closed by commit R320:b13449a13b00: sftp: do not show creation time when we do not know it (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27873?vs=78352&id=78444

D27873: sftp: do not show creation time when we do not know it

sitter updated this revision to Diff 78352. sitter added a comment. . REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27873?vs=77080&id=78352 BRANCH sftp-ctime REVISION DETAIL https://phabricator.kde.org/D27873 AFFECTED FILES sftp/kio_sftp.cpp T

D27504: smb faster copy to local

sitter added a comment. Any opinions on landing this for 20.04 still? It is technically a bugfix. It is also practically a whole lot of risky code, making me rather uneasy about putting it in past beta. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To: s

D28129: Read the new message string after rather than before

sitter added a comment. Mh. Not quite what I had in mind but I suppose it makes sense this way. I think we need a test case for the highlighter though :| It totally blows up in my face when I trace a running dolphin because toskip isn't quite right. INLINE COMMENTS > backtracegenerator.cp

D28188: breeze-icons autotests: skip symlinks in the builddir

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D28188 To: dfaure, sitter, bshah, lbeltrame Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27927: Use more flexible shebang

This revision was automatically updated to reflect the committed changes. Closed by commit R266:485e7be3b7ef: Use more flexible shebang (authored by tcberner, committed by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27927?vs=77198&id=78011 RE

D28129: Read the new message string after rather than before

sitter added a comment. Quick recap from what we talked about on telegram: putting the print after the bt is most definitely going to throw off the backtrace parsing logic, so doing it this way would require extensive changes there, which is a dangerous place to make extensive changes. Or

D18878: Force NT1 protocol when listing smb:// network [work in progress]

sitter removed a reviewer: sitter. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18878 To: mikhailnov, #dolphin, #frameworks, broulik Cc: sitter, ngraham, acrouthamel, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, al

  1   2   3   4   5   6   7   8   9   10   >