marked as submitted.
Review request for KDE Frameworks, Garret Wassermann, John Layt, and Petri
Damstén.
Changes
---
Submitted with commit 20345cf15fd31827d0d80ec58affb07e0a34dc30 by Albert Astals
Cid on behalf of Garret Wassermann to branch master.
Repository: kunitconversion
, Garret Wassermann, John Layt, and Petri
Damstén.
Changes
---
Updated to @since 5.27. I saw that 5.26 was released yesterday without this
patch.
Repository: kunitconversion
Description
---
New Thermal and Electrical Units and Convienience Function for KUnitConversion
Diffs
, Garret Wassermann, John Layt, and Petri
Damstén.
Changes
---
Used correct @since syntax, used full word "Square" for unit name to be in line
with other units, and added a missing space, to address review comments.
Repository: kunitconversion
Description
---
New Thermal and
, Garret Wassermann, John Layt, and Petri
Damstén.
Changes
---
Added @since KF 5.26 tags to all added enum values. I couldn't find good
documentation on KDE website for how to do this, so I followed doxygen style.
Hope that's ok, let me know and I can change if needed. I also add
, Garret Wassermann, John Layt, and Petri
Damstén.
Changes
---
Removed unneeded unitAsString() function from the diff. I originally remember
some difficulty getting my testing program to compile without this function,
not sure if it was a bug in my program or KUnitConversion back in the day
ttps://git.reviewboard.kde.org/r/12/#review97778
-----------
On July 24, 2016, 6:43 p.m., Garret Wassermann wrote:
>
> ---
> This is an automatically generated e-mail
et me know if there is something else
I should do better next time, thank you.
Thanks,
Garret Wassermann
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
itting review, so please let me know if there is something else
I should do better next time, thank you.
Thanks,
Garret Wassermann
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
ng up by hand!).
First time submitting review, so please let me know if there is something else
I should do better next time, thank you.
Thanks,
Garret Wassermann
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mai
> I'm the maintainer for KUnitConversion, you can find the maintainer in
> the metainfo.yaml file in each Framework repo [aside: perhaps we need
> to generate a page with this listed?]. I'm also the person looking at
> KStandards, or KCodes as I'm now calling it. For now KCodes will be
> sticking
to contact the person listed on KUC source code
too but maybe it is more appropriate to post to the mailing list for
feedback from everyone.
I am a long time user of KDE, and I am looking forward to learning
how to get involved and give back.
Thank you,
Garret Wasserm
11 matches
Mail list logo
