D26749: WIP: Support NDK r20 and Qt 5.14

flherne added a comment. I got my Kirigami app to load by patching kirigami.{cpp,h}: Altered `resolveFilePath()` to `return QStringLiteral("qrc:/android_rcc_bundle/qml/org/kde/kirigami.2/") + path;` and similarly for `resolveFileUrl()`. Added `QResource::registerResource(QStringLit

D26749: WIP: Support NDK r20 and Qt 5.14

flherne added a comment. Thanks for this. ADB log of the Kirigami problem, which results in a blank screen ['gredit' is the name of the app]: libgredit_arm64-v8a.so: QQmlApplicationEngine failed to load component libgredit_arm64-v8a.so: qrc:/main.qml:5:1: Type Kg.ApplicationWin

D22069: Localize long number strings

flherne added a comment. on IRC pointed out that this could affect telephone numbers. Also: numeric IDs [I bet at least something prints PIDs this way]. I don't think it makes sense to try and enumerate specific cases -- this needs a flag to determine whether localization is done, a

D22069: Localize long number strings

flherne added a comment. I'm afraid this was a breaking API change -- it changes the behaviour, and not all numbers are intended to have separators added in this way. See https://bugs.kde.org/show_bug.cgi?id=413390 A similar pattern occurs three different times just in KDevelop, and

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

flherne added a comment. Please no. `File -> Save` is one of the most universal menu entries, found in nearly every program that *has* a set of menus. Print is nearly as common. This breaks a user assumption that's been ingrained across virtually all GUI software for decades, and ma

[Differential] [Closed] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

This revision was automatically updated to reflect the committed changes. Closed by commit R265:a3355b22954b: KColorScheme: default to application scheme if set by KColorSchemeManager (authored by flherne). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

[Differential] [Updated] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

flherne marked an inline comment as done. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D4637 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: flherne, #frameworks Cc: graesslin

[Differential] [Updated, 43 lines] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

flherne updated the test plan for this revision. flherne updated this revision to Diff 11471. flherne added a comment. Update the commits / docstrings REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4637?vs=11439&id=11471 REVISION DETAIL https://ph

[Differential] [Commented On] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

flherne added a comment. In https://phabricator.kde.org/D4637#87022, @graesslin wrote: > This is a sensible idea, though I wonder whether we should put it into something more concrete than a QProperty on the qApp. That's not new, the property's been set here

[Differential] [Updated, 26 lines] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

flherne updated this revision to Diff 11439. flherne added a comment. Tweak a comment. REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4637?vs=11438&id=11439 REVISION DETAIL https://phabricator.kde.org/D4637 AFFECTED FILES src/kcolorscheme.cpp

[Differential] [Updated, 25 lines] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

flherne updated this revision to Diff 11438. flherne added a comment. Moved defaultConfig() out of the header in case someone includes it. REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4637?vs=11417&id=11438 REVISION DETAIL https://phabricator.kd

[Differential] [Request, 25 lines] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

flherne created this revision. flherne added a reviewer: Frameworks. flherne set the repository for this revision to R265 KConfigWidgets. Restricted Application added a project: Frameworks. REVISION SUMMARY [RFC] KColorSchemeManager::activateScheme() sets a custom path for the application

[Differential] [Closed] D4421: Reverse meaning of :split, :vsplit to match vi and Kate actions.

flherne closed this revision. flherne added a comment. https://cgit.kde.org/ktexteditor.git/commit/?id=b4006363eaf1d9d26f037bcdbc5f1a283b9d109e REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4421 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/ema

[Differential] [Request, 6 lines] D4421: Reverse meaning of :split, :vsplit to match vi and Kate actions.

flherne created this revision. flherne added a reviewer: KTextEditor. flherne set the repository for this revision to R39 KTextEditor. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY Reverse meaning of :spli

Re: Phabricator: All repositories registered - upcoming workflow changes

On Thu, 2 Feb 2017 07:45:15 +1300 Ben Cooksley wrote: [snip] > > I think that we need some cleanup on the old reviews (Albert Astal Cid > started > some time ago) and more important strongly tell new users (and old > users) to use Phabricator. I don't think that anyone wants to lose > the work, b

Re: Phabricator: All repositories registered - upcoming workflow changes

Sorry, forgot to reply-all and only sent to kdevelop-devel... - Hi, First off, there's a lot of postponed, or at least possibly-useful, work on ReviewBoard which would be lost. Some of this is from newish contributors who might be discouraged - e.g. the author of https://git.reviewbo