D22609: Add expanding spacers as a customization option for toolbars

felixernst added a comment. I kept the names lowercase because I like the visible difference between lowercase separator/spacer and title case actions. I don't mind changing the names to title case though. Judge for yourself: F7109858: Screenshot_20190728_185837.png

D22609: Add expanding spacers as a customization option for toolbars

felixernst updated this revision to Diff 62687. felixernst marked an inline comment as done. felixernst added a comment. Rename to "expanding spacer", Cast to QToolBar instead Remove unrelated comments and documentation REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabri

D22609: Add expanding spacers as a customization option for toolbars

felixernst retitled this revision from "Add spacers as a customization option for toolbars" to "Add expanding spacers as a customization option for toolbars". REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D22609 To: felixernst, dfaure Cc: ngraham, #vdg

D22609: Add spacers as a customization option for toolbars

felixernst added a comment. You all are too kind! > Code looks fine. First try \o/ I'll put the comments that aren't directly related into another revision. I'll rename it to "--- expanding spacer ---" then. So I'll keep it lowercase and in the same style as "--- seperator ---

D22609: Add spacers as a customization option for toolbars

felixernst edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D22609 To: felixernst Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add spacers as a customization option for toolbars

felixernst updated this revision to Diff 62188. felixernst added a comment. Use insertWidget(before, spacer) instead of addWidget(spacer) REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22609?vs=62185&id=62188 BRANCH master REVISION DETAIL https://phab

D22609: Add spacers as a customization option for toolbars

felixernst planned changes to this revision. felixernst added a comment. Need to fix wrong return type in KXMLGUIBuilder::createCustomElement REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D22609 To: felixernst Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh

D22609: Add spacers as a customization option for toolbars

felixernst edited the test plan for this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D22609 To: felixernst Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add spacers as a customization option for toolbars

felixernst edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D22609 To: felixernst Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add spacers as a customization option for toolbars

felixernst edited the test plan for this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D22609 To: felixernst Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add spacers as a customization option for toolbars

felixernst created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. felixernst requested review of this revision. REVISION SUMMARY This commit adds spacers to the kxmlgui framework so all applications using it will be able to use any amount of