Re: LibKF6Breeze Icons and KIconLoader

Hi, Am Freitag, 24. Mai 2024, 00:13:11 MESZ schrieb Bernhard Rosenkränzer: > On Thursday, May 23, 2024 22:20 CEST, Jonathan Riddell > wrote: > > > Has anyone had issues with Breeze loading using Frameworks 6.2 or > > master building the libKF6BreezeIcons.so.6 library in breeze-icons. > > Yes,

Re: LibKF6Breeze Icons and KIconLoader

Hi, Am Freitag, 24. Mai 2024, 00:13:11 MESZ schrieb Bernhard Rosenkränzer: > On Thursday, May 23, 2024 22:20 CEST, Jonathan Riddell > wrote: > > > Has anyone had issues with Breeze loading using Frameworks 6.2 or > > master building the libKF6BreezeIcons.so.6 library in breeze-icons. > > Yes,

Re: Critical Denial of Service bugs in Discover

Moin, Am Sonntag, 6. Februar 2022, 21:54:13 CET schrieb Fabian Vogt: > Am Sonntag, 6. Februar 2022, 19:27:11 CET schrieb Ben Cooksley: > > On Sun, Feb 6, 2022 at 1:07 PM Fabian Vogt wrote: > > > The first URL is used by kfontinst.knsrc from plasma-workspace: > &

Re: Critical Denial of Service bugs in Discover

Moin, Am Sonntag, 6. Februar 2022, 19:27:11 CET schrieb Ben Cooksley: > On Sun, Feb 6, 2022 at 1:07 PM Fabian Vogt wrote: > > The first URL is used by kfontinst.knsrc from plasma-workspace: > > ProvidersUrl=https://distribute.kde.org/khotnewstuff/fonts-providers.xml > >

Re: Critical Denial of Service bugs in Discover

Hi, Am Samstag, 5. Februar 2022, 22:16:28 CET schrieb Ben Cooksley: > Hi all, > > Over the past week or so Sysadmin has been dealing with an extremely high > volume of traffic directed towards both download.kde.org and > distribute.kde.org. > > This traffic volume is curious in so far that it is

Re: Requiring Qt 5.15 for KDE Frameworks 5?

Moin, Am Samstag, 27. M?rz 2021, 14:11:38 CET schrieb David Faure: > On samedi 27 mars 2021 12:51:37 CET Kai Uwe Broulik wrote: > > Hi everyone, > > > > during the ongoing KDE Frameworks 6 sprint we were just contemplating > > whether we can bump the required Qt dependency for Frameworks 5 to Qt

Re: Need xcb/xkb help for severe kglobalaccel_x11 issue

Moin, Am Samstag, 6. Februar 2021, 10:08:43 CET schrieb David Faure: > Problem mostly fixed by > https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/339 > but still seeing 15 notifications instead of 1 (already better than 145...). > > Indeed a single call to > /usr/bin/setxkbmap -layo

Re: Need xcb/xkb help for severe kglobalaccel_x11 issue

Hi, Am Samstag, 30. Januar 2021, 18:32:32 CET schrieb David Faure: > For years, I've noticed that when resuming a laptop from sleep, kglobalaccel > and X11 > use 100% CPU for a few minutes, making everything crawl for a while. > > I finally debugged why: kglobalaccel grabs and ungrabs all globa

D29800: Fix URL being passed as argument when launching a .desktop file

fvogt marked an inline comment as done. fvogt added a comment. Landed to invent - hopefully correctly: https://invent.kde.org/frameworks/kio/commit/84e9372f4fa2636f57dc456ac2fa2be271d6a7ec REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29800 To: fvogt, dfaure, marten C

D29800: Fix URL being passed as argument when launching a .desktop file

fvogt closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29800 To: fvogt, dfaure, marten Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29800: Fix URL being passed as argument when launching a .desktop file

fvogt created this revision. fvogt added reviewers: dfaure, marten. Herald added a project: Frameworks. fvogt requested review of this revision. REVISION SUMMARY When a .desktop file is executed directly, it doesn't receive a parameter. BUG: 421364 TEST PLAN Test passes, applications open n

D29503: Pixel align children of GridViewInternal

fvogt added a comment. In D29503#665612 , @ngraham wrote: > I can't reproduce it, but I wonder if this could fix or help https://bugs.kde.org/show_bug.cgi?id=417488? Yup, that's exactly what I was seeing before this change: F8293538: 8sM

D29503: Pixel align children of GridViewInternal

This revision was automatically updated to reflect the committed changes. Closed by commit R296:9725a21bcd0e: Pixel align children of GridViewInternal (authored by fvogt). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29503?vs=82183&id=82184 REVISION DE

D29503: Pixel align children of GridViewInternal

fvogt created this revision. fvogt added reviewers: Frameworks, broulik, mart. Herald added a project: Frameworks. fvogt requested review of this revision. REVISION SUMMARY The scroll bar size can be odd (for breeze it's 21), which causes leftMargin to be 12.5. This causes every delegate insid

D28856: Save disabling of desktop file components in kglobalshortcutsrc

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > globalshortcutsregistry.cpp:274 > +auto disabledComponents = KConfigGroup(&_config, > "disabledComponents").readEntry("disabled", QStringList()); > for

D24956: Consider desktop files with NoDisplay attribute

fvogt added a comment. In D24956#648968 , @davidedmundson wrote: > > [14:12] DavidRedondo1: my understanding is that a system might ship "konsole opens with control+t". The UI allows you to remove that. This would remove the entry in kglob

D24956: Consider desktop files with NoDisplay attribute

fvogt added a comment. In D24956#648905 , @davidedmundson wrote: > kglobalshortcutseditor.cpp > needs updating to match > > I think you're right with your reasoning about NoDisplay, but we do want something to be able to mask system files

D28535: [KIO-MTP] Fix null pointer dereference

fvogt added a comment. I assume there is a reason why `MTPDevice::getDevice()` has code for handling this very specific case, so I wouldn't just remove it without figuring out why: ../https://i.redd.it/hfnl7xo8yovy.gif If not, that would indeed be the best option. REPOSITORY R320 KIO

D28535: [KIO-MTP] Fix null pointer dereference

fvogt added a comment. In D28535#640682 , @feverfew wrote: > In D28535#640674 , @fvogt wrote: > > > What you're suggesting is to change `MTPDevice::getDevice` to return the old device if reopening fa

D28535: [KIO-MTP] Fix null pointer dereference

fvogt added a comment. In D28535#640680 , @anthonyfieroni wrote: > I see we don't speak in same language :) > `LIBMTP_Open_Raw_Device_Uncached(&m_rawdevice);` > returns nullptr that's normal since device is inaccessible, i mean it does not

D28535: [KIO-MTP] Fix null pointer dereference

fvogt added a comment. There is no such thing as an "invalid device" at that point anymore. There's only nullptr. LIBMTP_mtpdevice_t *MTPDevice::getDevice() { if (!m_mtpdevice->storage) { qCDebug(LOG_KIOD_KMTPD) << "no storage found: reopen mtpdevice";

D28535: [KIO-MTP] Fix null pointer dereference

fvogt added a comment. In D28535#640656 , @anthonyfieroni wrote: > You're right about bug report, but it can fail in any other place, just in particular version it happen in `updateStorageInfo` Can we cache `getDevice` in m_device (in construc

D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

This revision was automatically updated to reflect the committed changes. Closed by commit R268:8e14750977c6: Fix "Make it compile against last qt5.15 without deprecated method. QProcess… (authored by fvogt). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

fvogt marked an inline comment as done. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D27863 To: fvogt, #frameworks, mlaurent Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

fvogt edited the test plan for this revision. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D27863 To: fvogt, #frameworks, mlaurent Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

fvogt updated this revision to Diff 77022. fvogt added a comment. Do it differently, just like it's done below REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27863?vs=77009&id=77022 BRANCH somefix REVISION DETAIL https://phabricator.kde.org/D2786

D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

fvogt retitled this revision from "Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"" to "Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"". REPOSITORY R268 KGlobalAccel

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

fvogt added a comment. In D27863#622655 , @mlaurent wrote: > if splitting is already done why this code re-call "m_desktopFile.desktopGroup().readEntry(QStringLiteral("Exec"), QString())" ? > => QProcess::startDetached(commands, parts) no ?

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

fvogt added a comment. The split arguments are already available as `parts` above, as used in the klauncher call AFAICT. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D27863 To: fvogt, #frameworks, mlaurent Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cbla

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

fvogt added a reviewer: mlaurent. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D27863 To: fvogt, #frameworks, mlaurent Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

fvogt created this revision. fvogt added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY This port is broken AFAICT - it tries to run the full Exec= line as binary, without s

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

fvogt added a comment. In D27002#605999 , @ngraham wrote: > Could this be the fix for https://bugs.kde.org/show_bug.cgi?id=398908, or part of it? This leak presented itself by steadily growing memory use while something still unknown tri

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

This revision was automatically updated to reflect the committed changes. Closed by commit R241:213ed50634c0: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu (authored by fvogt). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27002?vs=74645&id=74989 RE

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

fvogt added a comment. In D27002#605860 , @meven wrote: > User feedback: "so far so good, 160 MB Memory usage" > Does not sound reassuring, I guess the user meant 160 MB compared to 200MB or similar prior to patch. Updated - should be

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

fvogt edited the test plan for this revision. REPOSITORY R241 KIO BRANCH noleak REVISION DETAIL https://phabricator.kde.org/D27002 To: fvogt, #frameworks, davidedmundson, meven Cc: anthonyfieroni, meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

fvogt added a comment. I'll land tomorrow if no objections. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27002 To: fvogt, #frameworks Cc: anthonyfieroni, meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

fvogt marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27002 To: fvogt, #frameworks Cc: anthonyfieroni, meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

fvogt edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27002 To: fvogt, #frameworks Cc: anthonyfieroni, meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

fvogt added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kurlnavigatorplacesselector.cpp:76 > Why cast? To only delete submenus, not anything else. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27002 To: fvogt, #frameworks Cc: anthonyfieroni, meven, kde-fr

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

fvogt added inline comments. INLINE COMMENTS > meven wrote in kurlnavigatorplacesselector.cpp:75 > Shouldn't it be done before the call to `m_placesMenu->clear();` How would that make a difference? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27002 To: fvogt, #framewor

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

fvogt updated this revision to Diff 74645. fvogt added a comment. Make a copy, QObject::children returns const & for some reason, so gets modified during iteration. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27002?vs=74611&id=74645 BRANCH noleak REVISI

D21606: RFC: ThreadWeaver Job Decorators not used properly and have no effect

fvogt abandoned this revision. fvogt added a comment. D22758 got merged REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D21606 To: fvogt Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

fvogt created this revision. fvogt added a reviewer: Frameworks. Herald added a project: Frameworks. fvogt requested review of this revision. REVISION SUMMARY This method gets called each time solid notices a change, which can in some setups be very frequent. It leaked memory as the submenus a

D25856: Show IOSlaves that return local files when in local file mode

fvogt added a comment. In D25856#594088 , @meven wrote: > In D25856#575125 , @fvogt wrote: > > > In D25856#575083 , @ngraham wrote: > > > > > In D25856#

D26191: Add support for FileJob->truncate() in smb/sftp slaves

fvogt accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH arcpatch-D26191 REVISION DETAIL https://phabricator.kde.org/D26191 To: feverfew, sitter, dfaure, fvogt Cc: kde-frameworks-devel, kfm-devel, ngraham, pberestov, iasensio, fprice

D26191: Add support for FileJob->truncate() in smb/sftp slaves

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kio_sftp.cpp:1480 > +if (!attr) { > +sftp_attributes_free(attr); > +int errorCode = toKIOError(sftp_get_error(mSftp)); This entire block is

D26157: Port QRegExp to QRegularExpression

fvogt accepted this revision. This revision is now accepted and ready to land. REPOSITORY R299 KDESu BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26157 To: ahmadsamir, sitter, fvogt, jriddell Cc: kde-frameworks-devel, LeGast00n, GB_2, mic

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

fvogt added a comment. This fixed the button label, but the menu itself is unsuable due to a black text on dark background: https://openqa.opensuse.org/tests/1110939#step/start_wayland_plasma5/21 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D256

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

fvogt added a comment. In D25699#575278 , @davidedmundson wrote: > Please don't link external sites (GitHub) in the committed message. > > RE: Menu > There is nothing in QQC2::Button to add a menu > > If we want that it would have to b

D25856: Show IOSlaves that return local files when in local file mode

fvogt added a comment. In D25856#575083 , @ngraham wrote: > In D25856#575044 , @fvogt wrote: > > > IMO this should be done in KIO, so that all users benefit. > > > How would you do it in KIO?

D25856: Show IOSlaves that return local files when in local file mode

fvogt added a comment. IMO this should be done in KIO, so that all users benefit. In D25856#575011 , @broulik wrote: > Isn't that what `KProtocolInfo::protocolClass() == ":local"` is for? Almost, but not quite - it just means that the

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

fvogt added a comment. The check for the prefix was added in `bf1d1cc6b2ad37cb586f44b56fa2438ed3a5dbfc`, while the `control.flat` one got added much earlier. The labels are visible again with just the `control.flat` condition, but the prefix one might be needed as well for non-breeze th

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. In D23384#572198 , @ngraham wrote: > I just tested writing today, for files opened in 3rd-party apps that get the FUSE mount path. Results: > ... Was that with or without the KIO::open merge request? REPOSITORY

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. In D23384#571276 , @ngraham wrote: > I'm afraid that even with that change, the issue is still present. I honestly don't think it would be the worst thing in the world if we always handed the kio-fuse paths to apps that do

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. In D23384#570830 , @ngraham wrote: > In D23384#570735 , @fvogt wrote: > > > > Clicking a http link in my chat app now kiofuses it and then has the browser desperately try to op

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. In D23384#570331 , @ngraham wrote: > In D23384#570118 , @fvogt wrote: > > > Please try both of the following: > > > Done. Here are the log files: > > F7793378: kio-fus

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. > Clicking a http link in my chat app now kiofuses it and then has the browser desperately try to open /run/user/1000/kio-fuse-bla/http/kde.org/ - it only gets the first character in the file, so I usually just see < for a HTML page Ignoring the elephant in the ro

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. Unfortunately the `kio-fuse -d` output is incomplete, probably because Qt was too smart and logged to the journal instead... It's visible that there are multiple processes reading the file, maybe thumbnailing is in progress? Can you try with thumbnails in dolphin di

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. **Issue #1:** That happens because the .desktop file sets `X-KDE-Protocols=ftp,http,https,mms,rtmp,rtsp,sftp,smb`: https://code.videolan.org/videolan/vlc/blob/master/share/vlc.desktop.in#L124 **Issue #2:** The only explanation I have for that is that tot

D25107: Add install dir for systemd units

fvogt accepted this revision. fvogt added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > KDEInstallDirs.cmake:245 > set(_LIBDIR_DEFAULT "lib") > -# Override this default 'lib' with 'lib64' iff: > +# Override this default 'lib' with 'lib64' if: > # - we are

D25107: Add install dir for systemd units

fvogt reopened this revision. fvogt added a comment. This revision is now accepted and ready to land. AFAICT this breaks if `LIBDIR` != "lib". `systemd` only looks in `/usr/lib` AFAICT, so hardcoding to `$prefix/lib/systemd` might be better. REPOSITORY R240 Extra CMake Modules REVISION DET

D25107: Add install dir for systemd units

fvogt requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25107 To: davidedmundson, apol, fvogt Cc: fvogt, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, micha

D25159: Fix linking to libssh 0.9.1

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. The libssh maintainer is likely reverting the change, so this should not be necessary. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25159 To: arojas

D24245: Add support for passing Unix file descriptors

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. Unfortunately, this breaks public API and ABI by modifying KAuth::ActionReply. I'm not sure whether there has to be any compatibility for the DBus API, but I guess not (logging

D23692: kdesu: set kernel flags to prevent ptrace instead of relying on setgid

fvogt added a reviewer: Frameworks. REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D23692 To: maltek, adridg, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23694: Add support for sshfs to the fstab backend

fvogt added a comment. `fuse.sshfs` is used by kdeconnect as well, does that cause some kind of conflict? If not, LGTM. Could be improved by adding other filesystems (curlftpfs?) as well and using something like `QStringList{"nfs", "nfs4", "smbfs", "cifs", "fuse.sshfs"}.contain

D23454: Fixing bug where MTP slave does not return error in stat()/mimetype()

This revision was automatically updated to reflect the committed changes. Closed by commit R320:8c42ec63200f: Fixing bug where MTP slave does not return error in stat()/mimetype() (authored by feverfew, committed by fvogt). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabric

D22758: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R308:54e18b0d9b0d: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly (authored by fvogt). REP

D23029: Fix the attica pkgconfig file.

fvogt added inline comments. INLINE COMMENTS > libKF5Attica.pc.cmake:3 > +exec_prefix=${BIN_INSTALL_DIR} > libdir=${LIB_INSTALL_DIR} > +includedir=${KF5_INCLUDE_INSTALL_DIR} In ECM and Qt this is absolute, `${prefix}/lib64`, same for `exec_prefix`. REPOSITORY R235 Attica REVISION DETAIL h

D22979: Security: remove support for $(...) in config keys with [$e] marker.

fvogt added a comment. In D22979#508493 , @kives wrote: > Does anyone think this can be easily backported to previous versions of KDE in upstream distros such as Kubuntu, etc.? I backported this down to KConfig 5.20 and KDELibs 4.14.18, d

D22723: Fix RunnerManager::queryFinished()

fvogt added a comment. > QObjects live in their own thread and shouldn't be used outside. > https://doc.qt.io/qt-5/qobject.html#thread > > In your patch we are emitting the signal from the run thread instead of the actual object's thread. This is wrong. Needs a `Qt::QueuedConnecti

D22723: Fix RunnerManager::queryFinished()

fvogt added a comment. In D22723#502365 , @aacid wrote: > I honestly don't see the problem with this patch, one may argue that the ThreadWeaver API is awkward, ok, but this is using it correctly AFAICS, i.e. have a ThreadWeaver::QObjectDecorator

D22758: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly

fvogt created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY Currently KRunner uses QObjectDecorator wrongly and changing the design to fix that would not only be a lot of work, but a

D22723: Fix RunnerManager::queryFinished()

fvogt added a comment. In D22723#501907 , @apol wrote: > In D22723#501690 , @fvogt wrote: > > > Looks like a hack still, with two Job objects for each job... > > > > What about just merging `QObje

D22723: Fix RunnerManager::queryFinished()

fvogt added a reviewer: davidedmundson. fvogt added a comment. Looks like a hack still, with two Job objects for each job... What about just merging `QObjectDecorator` into `FindMatchesJobInternal` by basically just adding a custom `done` signal and ignoring the entire "decorators which

D22555: [RFC] Add a kded module to manage various available fuse mount services

fvogt added inline comments. INLINE COMMENTS > mountservicemanager.cpp:42 > +{ > +KConfigGroup cfg = > KConfigGroup(KSharedConfig::openConfig(QStringLiteral("fusemanagerrc")), > QStringLiteral("Fuse Services")); > +return cfg.readEntry(url.scheme(), QString()); This line is the only pl

D22147: Better use of Qt APIs in Plasma::Theme

fvogt resigned from this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22147 To: apol, #plasma, #frameworks Cc: bruns, tcanabrava, fvogt, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D22147: Better use of Qt APIs in Plasma::Theme

fvogt added inline comments. INLINE COMMENTS > apol wrote in svg.cpp:317 > Please note this is only to make sure the regex was properly compiled. It > isn't matching there yet. It really does not look that way as you're immediately using captures after that. If that's really what you want (wh

D22147: Better use of Qt APIs in Plasma::Theme

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > svg.cpp:317 > +const auto match = sizeHintedKeyExpr.match(key); > +if (match.isValid()) { > +QString baseElementId = matc

D22080: [Fstab] Show mounted "overlay" filesystems

fvogt accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH submit REVISION DETAIL https://phabricator.kde.org/D22080 To: bruns, ngraham, fvogt, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22081: [Fstab] Select appropriate icon for home or root directory

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. With this and D22080 applied, there's an entry for / now: F6932935: Screenshot_20190625_092256.png On a r

D15739: [Places panel] Don't show Root by default

fvogt added a comment. In D15739#486043 , @bruns wrote: > In D15739#486020 , @fvogt wrote: > > > In D15739#486009 , @bruns wrote: > > > > > It actually

D15739: [Places panel] Don't show Root by default

fvogt added a comment. In D15739#486009 , @bruns wrote: > In D15739#485983 , @fvogt wrote: > > > Even if all (block) devices and their mountpoints were shown in the devices view, there would be no eq

D15739: [Places panel] Don't show Root by default

fvogt added a comment. In D15739#485979 , @ngraham wrote: > In D15739#485978 , @fvogt wrote: > > > Well, the only mount of interest is the overlay mount of /, which is not backed by any (block) devic

D15739: [Places panel] Don't show Root by default

fvogt added a comment. In D15739#485976 , @ngraham wrote: > In D15739#485975 , @fvogt wrote: > > > No, there's in fact no devices section at all as it would be empty. The live cd itself is marked as

D15739: [Places panel] Don't show Root by default

fvogt added a comment. In D15739#485960 , @ngraham wrote: > In D15739#485949 , @fvogt wrote: > > > I just noticed this in openQA runs from a live medium. There is no single-click way to get to the ro

D15739: [Places panel] Don't show Root by default

fvogt added a comment. I just noticed this in openQA runs from a live medium. There is no single-click way to get to the root directory anymore, as / is mounted as an overlayfs of a tmpfs and a squashfs container. Not sure what the best way to improve this is, any idea? REPOSITORY R24

D21607: Don't delay emission of matchesChanged indefinitely

This revision was automatically updated to reflect the committed changes. Closed by commit R308:a07027cd4f22: Don't delay emission of matchesChanged indefinitely (authored by fvogt). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21607?vs=59252&id=60049 REVIS

D21607: Don't delay emission of matchesChanged indefinitely

fvogt added a comment. Before I land this, I'd like if someone other than me tries krunner with this patch applied and judges the result with several runners. The difference is very noticable with the appstream runner as it does not batch results. REPOSITORY R308 KRunner REVISION DETAIL

D8532: [WIP] Restrict file extractor with Seccomp

fvogt added a comment. In D8532#478224 , @bruns wrote: > I totally agree with fvogt here - the extractors should just receive a readonly file descriptor. > > For this, there are several steps required: > > 1. let the extractors work with f

D21607: Don't delay emission of matchesChanged indefinitely

fvogt updated this revision to Diff 59252. fvogt added a comment. New algorithm with no delay if not necessary. REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21607?vs=59203&id=59252 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21607 AF

D21607: Don't delay emission of matchesChanged indefinitely

fvogt added a comment. In D21607#474772 , @fvogt wrote: > So for the stable branches I'd like to keep the current version of the diff with a latency of [100,599] while for master something like the above with a latency of [0,500] can be tried.

D21607: Don't delay emission of matchesChanged indefinitely

fvogt added a comment. In D21607#474771 , @fvogt wrote: > I'm thinking about doing it completely differently now though, with a 0 latency case (untested): > > if(lastMatchChangeSignalled.hasExpired(250)) { > matchChangeTimer.stop();

D21607: Don't delay emission of matchesChanged indefinitely

fvogt added a comment. In D21607#474763 , @bruns wrote: > This would emit the signal more often, but wouldn't > > if (!matchChangeTimer.isActive()) > matchChangeTimer.start(100) > > > achieve essentially the same? That wo

D21607: Don't delay emission of matchesChanged indefinitely

fvogt created this revision. fvogt added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY Currently the signal is only emitted if there was no change to the matches in

D21606: RFC: ThreadWeaver Job Decorators not used properly and have no effect

fvogt created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY ThreadWeaver Job Decorators don't actually hook into an existing job. Instead, they provide the same interface as the job

D20659: Copy container in Component::cleanUp before interating

fvogt added a comment. In D20659#452642 , @ngraham wrote: > Did this fix https://bugs.kde.org/show_bug.cgi?id=406642? No, that particular crash (bug 406426) is already fixed. I marked it as dup. REPOSITORY R268 KGlobalAccel REVISION DE

D20659: Copy container in Component::cleanUp before interating

This revision was automatically updated to reflect the committed changes. Closed by commit R268:78a711361db3: Copy container in Component::cleanUp before interating (authored by fvogt). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20659?vs=56517&id=5652

D20659: Copy container in Component::cleanUp before interating

fvogt retitled this revision from "Detach container in Component::cleanUp before interating" to "Copy container in Component::cleanUp before interating". REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D20659 To: fvogt, #frameworks Cc: lbeltrame, kde-frameworks-deve

D20659: Detach container in Component::cleanUp before interating

fvogt edited the summary of this revision. fvogt edited the test plan for this revision. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D20659 To: fvogt, #frameworks Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

  1   2   3   4   >