Re: Review Request 112880: Added KColorSchemeToken class.

2013-12-04 Thread Denis Kuplyakov
I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-29 Thread Denis Kuplyakov
> On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: > > To get in this patch would benefit from being based on the frameworks > > branch and go into kdeclarative. > > Kevin Ottens wrote: > Any chance for an update? > > Denis Kuplyakov wrote: > Yes

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-28 Thread Denis Kuplyakov
> On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: > > To get in this patch would benefit from being based on the frameworks > > branch and go into kdeclarative. > > Kevin Ottens wrote: > Any chance for an update? > > Denis Kuplyakov wrote: > Yes

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-10 Thread Denis Kuplyakov
re are many pre-exams in university. - Denis --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review42069 --- On Oct. 6, 2013, 7:24 p.m

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-09 Thread Denis Kuplyakov
> > enums? It would also make the code more readable. > > > > (Same issue for all the other methods.) > > Denis Kuplyakov wrote: > I have tried it, but have such errors: > Error: Unknown method parameter type: QPalette::ColorGroup > >

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-09 Thread Denis Kuplyakov
> > enums? It would also make the code more readable. > > > > (Same issue for all the other methods.) > > Denis Kuplyakov wrote: > I have tried it, but have such errors: > Error: Unknown method parameter type: QPalette::ColorGroup > >

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-08 Thread Denis Kuplyakov
; Maybe the registration could be done in a static method, rather than > > letting the apps do it on their own? > > > > The "NEED TO FIX" in the description can be removed, right? > > > > About the branch: I see that the request is correctly for 5.0 - which m

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-06 Thread Denis Kuplyakov
;s deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-06 Thread Denis Kuplyakov
that the int is only way to make it works correct. - Denis --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review41068 -------

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-29 Thread Denis Kuplyakov
- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review41002 --- On Sept. 29, 2013, 4:27 p.m., Denis Kuplyakov wrote: > >

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-29 Thread Denis Kuplyakov
013/newdesign branch. Thanks, Denis Kuplyakov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-24 Thread Denis Kuplyakov
ION kdeui/colors/kcolorschemetoken.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112880/diff/ Testing --- I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov ___ Kde-framework

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-23 Thread Denis Kuplyakov
olorschemetoken.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112880/diff/ Testing --- I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.o