davschul added a comment.
cool thanks :)
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D19286
To: dhaumann, cullmann, davschul, vkrause
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns,
demsking, cullmann, sars, dhaumann
davschul created this revision.
davschul added reviewers: cullmann, vkrause.
davschul added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
davschul requested review of this revision.
REVISION SUMMARY
davschul updated this revision to Diff 52268.
davschul added a comment.
Yeah, I just missed to recheck the sorting logic. Before the change we just
needed the best match so the partial sort was completely sufficient. Now we
need a complete sorted vector, so stable sort is the way to go ;)
CH
davschul added a comment.
Ah sorry completely missed that part. Unfortunately I'm out of office
already, I'll take a look as soon as I'm back tomorrow.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D19200
To: davschul, cullmann, vkrause
Cc: kwrite-devel
davschul added a comment.
Created https://phabricator.kde.org/D19200
That should implement all the latest suggestions/comments
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D18997
To: davschul, vkrause, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kd
davschul created this revision.
davschul added reviewers: cullmann, vkrause.
davschul added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
davschul requested review of this revision.
REVISION SUMMARY
davschul added a comment.
Okay I've tested it with 3.12.2 and there were no issues.
I'm not familiar enough with cmake to tell whether there is a simpler version
for what I try to achieve here. I just need the -D QT_NAMESPACE compiler
options. Is there someone in the community who might kno
davschul added a comment.
Nice respond times here, and thanks for the reviews :)
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D18997
To: davschul, vkrause, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, michaelh,
genethom
davschul updated this revision to Diff 51649.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18997?vs=51645&id=51649
REVISION DETAIL
https://phabricator.kde.org/D18997
AFFECTED FILES
src/lib/repository.cpp
src/lib/repository.h
To: davschul, vkrause, cullmann
Cc: cullmann, kwrite
davschul added a comment.
see
https://cgit.freedesktop.org/xdg/shared-mime-info/tree/freedesktop.org.xml.in?h=Release-1-12#n6074
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D18998
To: davschul, vkrause, cullmann
Cc: kwrite-devel, kde-frameworks-devel,
davschul created this revision.
davschul added reviewers: vkrause, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
davschul requested review of this revision.
REVISION SUMMARY
According to the freedesktop mimetypes literate haskell
davschul created this revision.
davschul added a reviewer: vkrause.
davschul added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
davschul requested review of this revision.
REVISION SUMMARY
This c
davschul added a comment.
David Schulz david.sch...@qt.io
REVISION DETAIL
https://phabricator.kde.org/D18982
To: davschul, vkrause, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, michaelh,
ngraham, bruns, demsking, sars
davschul added inline comments.
INLINE COMMENTS
> CMakeLists.txt:62
> set_property(TARGET SyntaxHighlightingData PROPERTY
> POSITION_INDEPENDENT_CODE 1)
> +target_link_libraries(SyntaxHighlightingData PRIVATE Qt5::Core)
This seems like an overkill, but I'm new to CMAKE and it seems that this w
davschul created this revision.
davschul added a reviewer: vkrause.
davschul added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
davschul requested review of this revision.
REVISION SUMMARY
Add QT
davschul updated this revision to Diff 51643.
davschul added a comment.
added additional context to the diff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18982?vs=51588&id=51643
REVISION DETAIL
https://phabricator.kde.org/D18982
AFFECTED FILES
src/lib/rule.cpp
To: davschul,
davschul added inline comments.
INLINE COMMENTS
> dhaumann wrote in rule.cpp:579-582
> I even wonder whether this should be always printed, i.e.:
>
> const bool isValid = m_regexp.isValid();
> if (!isValid)
> qCWarning(...) << "Invalid regexp:" << m_regexp.pattern();
> }
> return i
davschul created this revision.
davschul added a reviewer: vkrause.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
davschul requested review of this revision.
REVISION SUMMARY
Instead of crashing the complete application with an assert on a
18 matches
Mail list logo
