D19090: Hardcoding the Remaining Time Update Interval

narvaez added a comment. In D19090#413998 , @bruns wrote: > Nitpick - "Hardcoding ..." -> "Hardcode" or better "Use a fixed interval for updating the Remaining Time" Huh, I updated my local commit to use that recommendation but arc still

D19090: Hardcoding the Remaining Time Update Interval

narvaez closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19090 To: narvaez, #baloo, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19090: Hardcoding the Remaining Time Update Interval

narvaez added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19090 To: narvaez, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19090: Hardcoding the Remaining Time Update Interval

narvaez created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. narvaez requested review of this revision. REVISION SUMMARY There is no relation between this number and the batch size of the scheduler. REPOSITORY R293 Baloo BR

D19007: Wait for DBus Reply Before Performing Computations

narvaez abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19007 To: narvaez, #baloo, bruns, astippich, poboiko Cc: davidedmundson, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19007: Wait for DBus Reply Before Performing Computations

narvaez added inline comments. INLINE COMMENTS > bruns wrote in monitor.cpp:90 > The batchsize 40 by default, so currently the update interval is 200 files. > 100 or 200 does not matter to much, it is just a crude limiter anyway. > > A better fix would be emit the remaining time directly from t

D19007: Wait for DBus Reply Before Performing Computations

narvaez added inline comments. INLINE COMMENTS > davidedmundson wrote in monitor.cpp:90 > That won't fix the issue. > > getBatchSize is still returning a QDBusPendingReply, using the value before > it's loaded will always be zero. It does fix the issue because if getBatchSize returns 0 then up

D19007: Wait for DBus Reply Before Performing Computations

narvaez edited the test plan for this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19007 To: narvaez, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19007: Wait for DBus Reply Before Performing Computations

narvaez added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19007 To: narvaez, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19007: Wait for DBus Reply Before Performing Computations

narvaez created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. narvaez requested review of this revision. REVISION SUMMARY If the scheduler has not replied by the time the batch size is used, the default value is 0 and the mod op

Re: Review Request 124147: Create Data Dir If it Does Not Exist

happens only on my computer or if this is something wrong with the code, can somebody confirm? Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124134: Fixing KDED string references

jarrc. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124147: Create Data Dir If it Does Not Exist

? Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124147: Create Data Dir If it Does Not Exist

kcookiejar inside ~/.local/share and with a regular file named kcookiejar in that location. In my setup, the message box is not showing properly but I am not sure if this is somethign that happens only on my computer or if this is something wrong with the code, can somebody confirm? Thanks, David

Re: Review Request 124147: Create Data Dir If it Does Not Exist

named kcookiejar in that location. In my setup, the message box is not showing properly but I am not sure if this is somethign that happens only on my computer or if this is something wrong with the code, can somebody confirm? Thanks, David Narváez

Re: Review Request 124147: Create Data Dir If it Does Not Exist

named kcookiejar inside ~/.local/share and with a regular file named kcookiejar in that location. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124147: Create Data Dir If it Does Not Exist

kded5 with no file named kcookiejar inside ~/.local/share and with a regular file named kcookiejar in that location. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 124147: Create Data Dir If it Does Not Exist

hs is > > looking) :-) Will make a separate patch for this. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124147/#review81981

Re: Review Request 124147: Create Data Dir If it Does Not Exist

/ Testing --- Restarted kded5 with no file named kcookiejar inside ~/.local/share and with a regular file named kcookiejar in that location. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Review Request 124147: Create Data Dir If it Does Not Exist

/ioslaves/http/kcookiejar/kcookieserver.cpp ac585a0b04637c485647564d18a89a75d6c11d97 Diff: https://git.reviewboard.kde.org/r/124147/diff/ Testing --- Restarted kded5 with no file named kcookiejar inside ~/.local/share and with a regular file named kcookiejar in that location. Thanks, David

Review Request 124134: Fixing KDED string references

tried $ kcmshell5 cookies a message would pop up saying the cookies service was not available. After this patch you are able to view and edit your cookies. After this patch I also have ~/.config/kcookiejarrc. Thanks, David Narváez ___ Kde-frame

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

ebapp window (simple window). Step 7 opens the current working directory because local URL handling is broken. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

. > > Can you please argument this? > > David Narváez wrote: > It would be equivalent to process() because the --help and --version > arguments were already handled by the original application if they were > present (i.e., the application would have died before requestin

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

before requesting our activation). - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120794/#review69318 ------- On Oct. 29, 2014, 1:57 p.m., David Narváez wrote: > > --

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

indow properly, step 5 opens an incognito window and step 6 opens a webapp window (simple window). Step 7 opens the current working directory because local URL handling is broken. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-fram

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

new window properly, step 5 opens an incognito window and step 6 opens a webapp window (simple window). Step 7 opens the current working directory because local URL handling is broken. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-fram

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

reply, visit: https://git.reviewboard.kde.org/r/120794/#review69243 ------- On Oct. 28, 2014, 2 p.m., David Narváez wrote: > > --- > This is an automatically g

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

it: https://git.reviewboard.kde.org/r/120794/#review69243 --- On Oct. 28, 2014, 5:44 a.m., David Narváez wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

and step 6 opens a webapp window (simple window). Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120794: Implement Unique Mode Properly in Rekonq

rser if the argument list is not empty, the window opened at 1 crashes because the activateRequested signal passes an empty list of arguments - not even the binary name - so QCommandLine parser dies. With this patch, every step opens a new window properly. Th

Re: Review Request 119457: Script to Fix ecm_install_icons Deprecation Warnings

ile using this script 4) Reconfigure the repository using cmake - warnings should be gone File Attachments Test Repository https://git.reviewboard.kde.org/media/uploaded/files/2014/07/25/f598db77-95a6-4505-b02d-72304b79d65b__iconstest.tgz Thanks, David Narv

Review Request 119457: Script to Fix ecm_install_icons Deprecation Warnings

ile Attachments Test Repository https://git.reviewboard.kde.org/media/uploaded/files/2014/07/25/f598db77-95a6-4505-b02d-72304b79d65b__iconstest.tgz Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.

Re: Review Request 119444: Replacing also kicon.h header include

rters.size(); ++i ) m->addAction( new ExporterAction( doc, w, coll, mexporters[i] ) ); if(coll) Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119435: Replacing also kaction.h header include

@@ -41,7 +41,7 @@ public: }; class ExporterAction - : public KAction + : public QAction { Q_OBJECT Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 119444: Replacing also kicon.h header include

ment-export", const_cast( doc )->iconLoader() ) ); + m->setIcon( QIcon::fromTheme( "document-export", const_cast( doc )->iconLoader() ) ); for ( uint i = 0; i < mexporters.size(); ++i ) m->addAction( new ExporterAct

Review Request 119435: Replacing also kaction.h header include

{ Q_OBJECT Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

/ Testing --- Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115440: Rename KDE4_SERIALIZE_TOOL to KDOCTOOLS_SERIALIZE_TOOL And Add Setter

marked as submitted. Review request for KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- As described in Review Request 115077 Diffs - KF5DocToolsMacros.cmake 998c200 Diff: https://git.reviewboard.kde.org/r/115440/diff/ Testing --- Thanks, David

Review Request 115440: Rename KDE4_SERIALIZE_TOOL to KDOCTOOLS_SERIALIZE_TOOL And Add Setter

: kdoctools Description --- As described in Review Request 115077 Diffs - KF5DocToolsMacros.cmake 998c200 Diff: https://git.reviewboard.kde.org/r/115440/diff/ Testing --- Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 115292: Do Configure Checks in the Correct Language

-network.h #define HAVE_GETADDRINFO 1 Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115417: Remove the Check for freeaddrinfo

change, all tests pass. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115417: Remove the Check for freeaddrinfo

and Alex Merry. Repository: kde4support Description (updated) --- It is no longer used, see #115292 Diffs - src/ConfigureChecks.cmake 5f7f485 Diff: https://git.reviewboard.kde.org/r/115417/diff/ Testing --- Builds OK after this change, all tests pass. Thanks, David

Review Request 115417: Remove the Check for freeaddrinfo

: kde4support Description --- It is no longer used, see 115292 Diffs - src/ConfigureChecks.cmake 5f7f485 Diff: https://git.reviewboard.kde.org/r/115417/diff/ Testing --- Builds OK after this change, all tests pass. Thanks, David Narváez

Re: Review Request 115292: Do Configure Checks in the Correct Language

utomatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/#review48694 ------- On Jan. 24, 2014, 1:55 p.m., David Narváez wrote: > > --- > This

Re: Review Request 115292: Do Configure Checks in the Correct Language

hen I noticed this one didn't need it but erased just the second argument, my bad. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/#review48694 ----

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

, visit: https://git.reviewboard.kde.org/r/115077/#review48693 --- On Jan. 18, 2014, 1:16 p.m., David Narváez wrote: > > --- > This is an automatically generated e-mail. T

Review Request 115292: Do Configure Checks in the Correct Language

/ConfigureChecks.cmake 7c8951f Diff: https://git.reviewboard.kde.org/r/115292/diff/ Testing --- 1. Refreshed builds for ECM and KDE4Support, both building OK 2. $ grep HAVE_GETADDRINFO src/config-network.h #define HAVE_GETADDRINFO 1 Thanks, David Narváez

Re: Review Request 115239: Relocate KDE4_CREATE_HANDBOOK

--- Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115237: Relocate KDE4_CREATE_HANDBOOK

is created for folder doc. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115239: Relocate KDE4_CREATE_HANDBOOK

: kdoctools Description --- Moved to KDE4Support as discussed in Review Request 115077 Diffs - KF5DocToolsMacros.cmake 5bb0f72 Diff: https://git.reviewboard.kde.org/r/115239/diff/ Testing --- Thanks, David Narváez ___ Kde-frameworks

Re: Review Request 115237: Relocate KDE4_CREATE_HANDBOOK

and the doc-handbook target is created for folder doc. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115237: Relocate KDE4_CREATE_HANDBOOK

://git.reviewboard.kde.org/r/115237/diff/ Testing --- Tried using this on a Kig build for frameworks. The warning message is displayed and the doc-handbook target is created for folder doc. Thanks, David Narváez ___ Kde-frameworks-devel mailing list

Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

CMakeLists.txt files of frameworks for that macro, found nothing. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

; > However, they should probably be moved to kde4support. > > Aleix Pol Gonzalez wrote: > I wouldn't rename it indeed. > > Moving it to KDE4Support can be good indeed, although it kind of defeats > the purpose, as you'll need to actually depend on KDE4S

Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

: kdoctools Description --- As discussed in Review Request 115077 Diffs - KF5DocToolsMacros.cmake 191a2c5 Diff: https://git.reviewboard.kde.org/r/115213/diff/ Testing --- Searched all CMakeLists.txt files of frameworks for that macro, found nothing. Thanks, David Narváez

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

; > However, they should probably be moved to kde4support. > > Aleix Pol Gonzalez wrote: > I wouldn't rename it indeed. > > Moving it to KDE4Support can be good indeed, although it kind of defeats > the purpose, as you'll need to actually depend on KDE4S

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

/ Testing --- Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

on KDE4Support to get the > warning. Luigi, your call. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115077/#review47592 --------

Review Request 115077: Rename Macros in KF5DocTools to KDE5_

: kdoctools Description --- Part of the overall task of removing mentions of KDE4 from the code. Diffs - KF5DocToolsMacros.cmake 191a2c5 Diff: https://git.reviewboard.kde.org/r/115077/diff/ Testing --- Thanks, David Narváez ___ Kde

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2 I think you need to rename the targets in the new folders. Complete log at http://paste.kde.org/pf215b902 - David Narváez On Jan. 17, 2014, 11:30 a.m., Jonathan Riddell wrote: > > --

Re: Review Request 113792: Fix Build of KDNSSD with DNSSD Backend

KDNSSD with -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 2. Build Builds successfully. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113818: Add Remaining Tier 2 Builds to Superbuild

superbuild for dnssd, kjobwidgets, kwallet and dependencies. 2. Build. Builds successfully. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113818: Add Remaining Tier 2 Builds to Superbuild

. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113792: Fix Build of KDNSSD with DNSSD Backend

/mdnsd-domainbrowser.cpp 21c359e tier2/dnssd/src/CMakeLists.txt c71ade2 tier2/dnssd/CMakeLists.txt 13497d1 Diff: http://git.reviewboard.kde.org/r/113792/diff/ Testing --- 1. Configure KDNSSD with -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 2. Build Builds successfully. Thanks, David

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

-DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 Configures OK in both cases. Builds OK in case 1, does not build yet in case 2. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

-DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 Configures OK in both cases. Builds OK in case 1, does not build yet in case 2. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

case 1, does not build yet in case 2. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

it: http://git.reviewboard.kde.org/r/113657/#review43202 ------- On Nov. 7, 2013, 1:30 p.m., David Narváez wrote: > > --- > This is an automatically generated e

Review Request 113657: Fix Standalone Configuration of DNSSD

/dnssd/CMakeLists.txt 2cfcc40 Diff: http://git.reviewboard.kde.org/r/113657/diff/ Testing --- 1. Configure with cmake 2. Configure with cmake and -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 Configures OK in both cases. Builds OK in case 1, does not build yet in case 2. Thanks, David Narváez

Re: Review Request 113643: Fix Standalone Build for KJobWidgets

/diff/ Testing --- 1. Configure a standalone build Before this patch the configuration would complain of missing find_packages for KCore Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/ma

Re: Review Request 113642: Fix warnings about annotations in DBus XML for KWallet

ng: deprecated annotation 'com.trolltech.QtDBus.QtTypeName.Out0' found; suggest updating to 'org.qtproject.QtDBus.QtTypeName.Out0' Warning: deprecated annotation 'com.trolltech.QtDBus.QtTypeName.Out0' found; suggest updating to 'or

Re: Review Request 113645: Fix Warning of Unused Parameter in KJobWidgets

. Standalone build of KJobWidgets Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113643: Fix Standalone Build for KJobWidgets

org/r/113643/diff/ Testing --- 1. Configure a standalone build Before this patch the configuration would complain of missing find_packages for KCore Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Review Request 113645: Fix Warning of Unused Parameter in KJobWidgets

--- Now all output during build is about TODOs in the code. Diffs - tier2/kjobwidgets/src/kdialogjobuidelegate.cpp 29c2bae Diff: http://git.reviewboard.kde.org/r/113645/diff/ Testing --- 1. Standalone build of KJobWidgets Thanks, David Narváez

Re: Review Request 113643: Fix Standalone Build for KJobWidgets

x27;s source dir. Diffs (updated) - tier2/kjobwidgets/CMakeLists.txt 98bd0a1 Diff: http://git.reviewboard.kde.org/r/113643/diff/ Testing --- 1. Configure a standalone build Before this patch the configuration would complain of missing find_packages for KCore Thanks, David Na

Re: Review Request 113643: Fix Standalone Configuration for KJobWidgets

t; > if("${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}") > > > > This is more future-proof in case the top-level project gets renamed. > > David Narváez wrote: > Mmm, I understand your point but note that > > CMAKE_BINARY

Re: Review Request 113643: Fix Standalone Configuration for KJobWidgets

KE_CURRENT_BINARY_DIR /usr/local/src/kf5-standalone/kjobwidgets/src - David --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113643/#review43058 --------

Re: Review Request 113643: Fix Standalone Configuration for KJobWidgets

http://git.reviewboard.kde.org/r/113643/diff/ Testing --- 1. Configure a standalone build Before this patch the configuration would complain of missing find_packages for KCore Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kd

Re: Review Request 113642: Fix warnings about annotations in DBus XML for KWallet

ng: deprecated annotation 'com.trolltech.QtDBus.QtTypeName.Out0' found; suggest updating to 'org.qtproject.QtDBus.QtTypeName.Out0' Warning: deprecated annotation 'com.trolltech.QtDBus.QtTypeName.Out0' found; suggest updating to 'org.qtproject.QtDBus.QtTypeName.Out0' Thanks, D