Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

oHTML code from /r/121094 in a QGuiApplication and it seems to work. Thanks, Dan Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext -> HTML conversion

tests/CMakeLists.txt d5a5feb autotests/ktexttohtmltest.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121094/diff/ Testing --- Unit test passes Thanks, Dan Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

ion and it seems to work. Thanks, Dan Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121047: KCodecs: add MIME codecs, improve {encode, decode}RFC2047String()

csidentity.cpp PRE-CREATION src/kcodecsqp.h PRE-CREATION src/kcodecsqp.cpp PRE-CREATION src/kcodecsuuencode.h PRE-CREATION src/kcodecsuuencode.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121047/diff/ Testing --- Builds, all unit-tests pass. Thanks, Dan Vrátil _

Re: Review Request 120155: Correctly load non-square icons in KIconLoader

= QIcon::fromTheme(QLatin1String("process-working")); QPixmap pix = icon.pixmap(22, 8 * 22); With this patch, the pix looks as expected. Thanks, Dan Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.o

Re: Review Request 120155: Correctly load non-square icons in KIconLoader

. To reply, visit: https://git.reviewboard.kde.org/r/120155/#review66332 --- On Sept. 12, 2014, 10:35 a.m., Dan Vrátil wrote: > > --- > This is an automatically generated

Review Request 120155: Correctly load non-square icons in KIconLoader

rking")); QPixmap pix = icon.pixmap(22, 8 * 22); With this patch, the pix looks as expected. Thanks, Dan Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119321: kio-extras: Install KIO and KDED modules into correct folders

e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119321/#review62522 --- On July 16, 2014, 5:20 p.m., Dan Vrátil wrote: > > --- > This is an automatically ge

Re: Review Request 119321: kio-extras: Install KIO and KDED modules into correct folders

8 trash/trash.protocol 2776985 Diff: https://git.reviewboard.kde.org/r/119321/diff/ Testing --- Thanks, Dan Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 119321: kio-extras: Install KIO and KDED modules into correct folders

19321/diff/ Testing --- Thanks, Dan Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119011: KInit: call setgroups(0, 0) before calling setgid()

src/start_kdeinit/start_kdeinit.c 07a28d3 Diff: https://git.reviewboard.kde.org/r/119011/diff/ Testing --- Thanks, Dan Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 119011: KInit: call setgroups(0, 0) before calling setgid()

sting --- Thanks, Dan Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118667: KCrash: call setgroups(0, 0) before calling setgid()

h.cpp f05385b Diff: https://git.reviewboard.kde.org/r/118667/diff/ Testing --- Thanks, Dan Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118667: KCrash: call setgroups(0, 0) before calling setgid()

ruser things. The code does not check for return value, as the call will fail if we are not a superuser. This oneliner makes rpmlint happy and maybe prevents a security issue. Diffs - src/kcrash.cpp f05385b Diff: https://git.reviewboard.kde.org/r/118667/diff/ Testing --- Thanks,

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

pplication, got drkonqi window Thanks, Dan Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

opt/kde5 prefix - started broken application - no "could not find drkonqi" warning anymore - crashed application, got drkonqi window Thanks, Dan Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailma

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

quot;could not find drkonqi" warning anymore - crashed application, got drkonqi window Thanks, Dan Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

be interesting to figure out > what can be uncommented (see commit f8b59b6c in kde-runtime). There's many > things commented out and I'm unsure what to do with it. > > Dan Vrátil wrote: > I agree, however until it is done, this patch would make lifes of > distr

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

ail. To reply, visit: https://git.reviewboard.kde.org/r/117016/#review53939 ------- On March 24, 2014, 1:01 p.m., Dan Vrátil wrote: > > --- > This is an automat

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

tion packagers a bit easier :-) - Dan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117016/#review53985 ------- On Mar

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

on, got drkonqi window Thanks, Dan Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

sting --- - Installed KCrash into /usr prefix - Installed drkonqi from kde-runtime master to /opt/kde5 prefix - started broken application - no "could not find drkonqi" warning anymore - crashed application, got drkonqi window Thanks, Dan Vrátil ___

Re: Review Request 114888: Avoid "//" in path in generated headers

and kdnssd frameworks with rpmbuild, other frameworks still build too. Thanks, Dan Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114888: Avoid "//" in path in generated headers

ameworks still build too. Thanks, Dan Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114888: Avoid "//" in path in generated headers

is patch we are able to build solid and kdnssd frameworks with RPM build tools. Diffs - modules/ECMGenerateHeaders.cmake f72b1c0 Diff: https://git.reviewboard.kde.org/r/114888/diff/ Testing --- Successfully built solid and kdnssd frameworks with rpmbuild, other frameworks sti