D29463: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

Zren added reviewers: Kirigami, mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29463 To: Zren, #kirigami, mart Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29463: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

Zren created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Zren requested review of this revision. REVISION SUMMARY I recently noticed that `Kirigami.Units.devicePixelRatio` was `1.3` even though I was at the default 96dpi when writing a wid

D28874: Taiwanese holidays

Zren added a comment. Phab only understands `.diff`. Phab does not recognize `.patch`. git diff --staged > D28874.diff Or: git diff origin/master > D28874.diff REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winter

D28874: Taiwanese holidays

Zren added a comment. There's a few extra spaces at the end of `"植樹節 "` and `"中秋節 補假 "` too. Not sure how well you know `git`, but make sure to run `git add holidays/plan2/holiday_tw_zh` again after making your changes, before running `git diff --staged` to upload the modified diff. REP

D28874: Taiwanese holidays

Zren added a comment. Now you're missing `holidays/plan2/holiday_tw_zh` which can still be seen here: https://phabricator.kde.org/D28874?id=80260 git add holidays/holidays.qrc git add holidays/plan2/holiday_tw_zh git diff --staged > D28874.diff REPOSITORY R175 KHolidays REVI

D24524: Add a common widget config control library starting with ConfigIcon.qml

Zren created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Zren requested review of this revision. REVISION SUMMARY I'm submitting this to start discussion on creating a common config control library. I've started with a more common use

D24522: Add presentwindows icon (old "task view" from windows)

Zren added a comment. > `preferences-system-windows-effect-presentwindows` That would look like the `homerun` icon, which looks like the "windows" logo. F7557693: 2019-10-09___13-01-07.png When you clicked on "Task View" in Windows, the 2 "o

D24522: Add presentwindows icon (old "task view" from windows)

Zren created this revision. Zren added reviewers: VDG, Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Zren requested review of this revision. REVISION SUMMARY Needed for T11776 , but only we we want the widget for

D19821: Fix breeze dialog background with Qt 5.12.2

Zren added a comment. Another option I believe is to keep the `

D15321: [Calendar] Expose firstDayOfWeek in MonthView for calendar widgets to override the Locale

This revision was automatically updated to reflect the committed changes. Closed by commit R242:e5949866bb8f: [Calendar] Expose firstDayOfWeek in MonthView (authored by Zren). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15321?vs=41123&id=

D15321: [Calendar] Expose firstDayOfWeek in MonthView for calendar widgets to override the Locale

Zren created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Zren requested review of this revision. REVISION SUMMARY Users may want to start the week on a Sunday, Saturday, or Monday without changing their locale's date formatting. CCBUG

D15309: [Calendar] Wrap day name index around

Zren added a comment. Nice thinking on using `repeater.count` instead of the hardcoded `7`! Hmm, was worried `days.count` would trigger `onCountChanged` every time a delegate is made (count=1, count=2, etc), but it seems that the `delegate.text` is only calculated twice (delegate creatio

D15177: Emit signals when a package is installed/uninstalled

Zren added a dependent revision: D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D15177 To: davidedmundson, #plasma Cc: Zren, kde-frameworks-devel, michaelh, ngraham, bruns

D12206: Don't show "Open With" for folders, as was apparently originally intended

Zren added a comment. > So you're proposing that folders show the Open With... entry, but omit the recently added additional entry that shows the first app? Hmmm? Ah I missed D11569 . So the proposal is we don't show the inline "Open with Gwenview" and

D12206: Don't show "Open With" for folders, as was apparently originally intended

Zren added a comment. - Open with "Sublime Text" / "Atom" - Open with "K4DirStat" - Open with "Clementine" Comix, Gwenview, VLC, $MediaPlayer will usually "autoplay" the next file in a folder, so this won't really affect those apps. Do we really need these apps to define a contex

D5971: Expose the symbolic 22px kde icon by moving it to kde-symbolic and symlinking to it

Zren added a reviewer: Breeze. Zren added a comment. Forgot to add reviewers. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D5971 To: Zren, #breeze Cc: #frameworks, michaelh, ngraham

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit R252:35656828f12c: Support downloading the 2nd or 3rd download link from a KNS product (authored by Zren). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8636?vs=21841&id=22014#toc REPOSITORY R25

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

Zren added a comment. Quick note since I just notice you suggested a lowercase `i` in `?linkid=3`, should I change it to lowercase or stick with camelcase? REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D8636 To: Zren, apol Cc: #frameworks

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

Zren added a comment. Good idea. This will future proof us in case we ever want `?linkName=tiledmenu-v18-kde5.9.plasmoid` or something as well. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D8636 To: Zren, apol Cc: #frameworks

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

Zren updated this revision to Diff 21841. Zren edited the summary of this revision. Zren edited the test plan for this revision. REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8636?vs=21823&id=21841 REVISION DETAIL https://phabricator.kde.org/D

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

Zren added a reviewer: apol. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D8636 To: Zren, apol Cc: #frameworks

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

Zren edited the test plan for this revision. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D8636 To: Zren Cc: #frameworks

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

Zren edited the test plan for this revision. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D8636 To: Zren Cc: #frameworks

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

Zren created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Implementing the feature request in BUG #385429. https://bugs.kde.org/show_bug.cgi?id=385429 LookAndFeels introduced the ability to set d

D5209: Load translations from KPackage files if bundled

Zren added a comment. Another note: `plasmoidviewer` is unaffected by this patch. Meaning - `devpath/contents/locale/fr_CA/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo` will not show translations in plasmoidviewer, but if you install to - `/.local/share/plasma/plas

D5209: Load translations from KPackage files if bundled

Zren added a comment. This worked - `~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo` These didn't work - `~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/f

D5209: Load translations from KPackage files if bundled

Zren added a comment. Oh awesome. Just found out about this. So this would be added in Frameworks 5.37 then? Does this mean: 1. `digitalclock.plasmoid/translations/plasma_applet_org.kde.plasma.digitalclock.po` 2. `digitalclock.plasmoid/contents/translations/plasma_applet_org.kde.

D5971: Expose the symbolic 22px kde icon by moving it to kde-symbolic and symlinking to it

Zren updated this revision to Diff 14841. Zren added a comment. Apply to icons-dark too. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5971?vs=14840&id=14841 REVISION DETAIL https://phabricator.kde.org/D5971 AFFECTED FILES icons-dark/apps/22/kde

D5971: Expose the symbolic 22px kde icon by moving it to kde-symbolic and symlinking to it

Zren created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This lets panels >23px use the symbolic icon for their launcher. Right now the 48px version of kde.svg has a blue rounded rectangle background.

Review Request 128872: Revert distribute-randomize, view-calendar + reapply the transform fix

-calendar.svg 4ddeeb1 Diff: https://git.reviewboard.kde.org/r/128872/diff/ Testing --- Thanks, Chris Holland