D27252: add maui index icon in pm style

2020-02-11 Thread Camilo Higuita
camiloh accepted this revision. camiloh added a comment. This revision is now accepted and ready to land. I like it REPOSITORY R266 Breeze Icons BRANCH index (branched from master) REVISION DETAIL https://phabricator.kde.org/D27252 To: mbruchert, camiloh, #vdg Cc: kde-frameworks-devel

D27246: add buho icon

2020-02-11 Thread Camilo Higuita
camiloh accepted this revision. camiloh added a comment. This revision is now accepted and ready to land. Looks extra nice and appropriate REPOSITORY R266 Breeze Icons BRANCH buho (branched from master) REVISION DETAIL https://phabricator.kde.org/D27246 To: mbruchert, camiloh, #vdg Cc

D27215: add vvave icon

2020-02-07 Thread Camilo Higuita
camiloh accepted this revision. camiloh added a comment. This revision is now accepted and ready to land. I really nice. REPOSITORY R266 Breeze Icons BRANCH vvave (branched from master) REVISION DETAIL https://phabricator.kde.org/D27215 To: mbruchert, #vdg, camiloh Cc: kde-frameworks-

D23352: make button icons follow a reasonable size and layout

2019-08-28 Thread Camilo Higuita
camiloh updated this revision to Diff 64851. camiloh added a comment. correct slip from toolbutton REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23352?vs=64850&id=64851 BRANCH arcpatch-D23352_2 REVISION DETAIL https://phabricator.k

D23352: make button icons follow a reasonable size and layout

2019-08-28 Thread Camilo Higuita
camiloh updated this revision to Diff 64850. camiloh added a comment. suggested changes. use preferred width and height when the icon group height and width props are set REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23352?vs=64807&id=6

D23367: make the sizing of the toolbuttons more coherent

2019-08-28 Thread Camilo Higuita
This revision was automatically updated to reflect the committed changes. Closed by commit R242:069b4e95c155: make the sizing of the toolbuttons more coherent (authored by camiloh). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23367?vs=648

D23367: make the sizing of the toolbuttons more coherent

2019-08-28 Thread Camilo Higuita
camiloh updated this revision to Diff 64844. camiloh added a comment. make the icon fill height and width if the icon group height or width props are not set or are 0 REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23367?vs=64832&id=64844

D23367: make the sizing of the toolbuttons more coherent

2019-08-28 Thread Camilo Higuita
camiloh updated this revision to Diff 64832. camiloh added a comment. make usage of the icon group properties: height and width REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23367?vs=64449&id=64832 BRANCH arcpatch-D23367 REVISION DET

D23388: add a border for the toolbars WIP

2019-08-24 Thread Camilo Higuita
camiloh added a comment. In D23388#517778 , @apol wrote: > I don't think we can use Kirigami here, it will use the wrong color scheme. You'll have to copy over the Separator's rectangle. It seems to take the right color: In the followin

D23367: make the sizing of the toolbuttons more coherent

2019-08-23 Thread Camilo Higuita
This revision was automatically updated to reflect the committed changes. Closed by commit R242:3887f5ec9152: make the sizing of the toolbuttons more coherent (authored by camiloh). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23367?vs=644

D23388: add a border for the toolbars WIP

2019-08-23 Thread Camilo Higuita
camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23388: add a border for the toolbars WIP

2019-08-23 Thread Camilo Higuita
camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23388: add a border for the toolbars WIP

2019-08-23 Thread Camilo Higuita
camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23388: add a border for the toolbars WIP

2019-08-23 Thread Camilo Higuita
camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23388: add a border for the toolbars WIP

2019-08-23 Thread Camilo Higuita
camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23388: add a border for the toolbars WIP

2019-08-23 Thread Camilo Higuita
camiloh retitled this revision from "add a border for the toolbars" to "add a border for the toolbars WIP". camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc

D23388: add a border for the toolbars

2019-08-23 Thread Camilo Higuita
camiloh created this revision. camiloh added reviewers: Plasma, mart, ngraham, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. camiloh requested review of this revision. REVISION SUMMARY this is mostly mean for the QQC2 apps running on PlaMo and using t

D23367: make the sizing of the toolbuttons more coherent

2019-08-23 Thread Camilo Higuita
camiloh added a comment. In D23367#517658 , @ngraham wrote: > Not that it's an inappropriate fix, but are you sure you want to be using PlasmaComponents ToolButtons in Index? Why not use regular old QQC2 ToolButtons? My intention with the

D23367: make the sizing of the toolbuttons more coherent

2019-08-23 Thread Camilo Higuita
camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23367 To: camiloh, #plasma, mart, ngraham Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23367: make the sizing of the toolbuttons more coherent

2019-08-23 Thread Camilo Higuita
camiloh updated this revision to Diff 64432. camiloh marked an inline comment as done. camiloh added a comment. if parent is nto visible then children are not visible. fix REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23367?vs=64368&id=6

D23367: make the sizing of the toolbuttons more coherent

2019-08-23 Thread Camilo Higuita
camiloh marked an inline comment as done. camiloh added inline comments. INLINE COMMENTS > apol wrote in ToolButton.qml:56 > That's always the case, isn't it? if a parent isn't visible, an item will > never be visible. yes. you're right. REPOSITORY R242 Plasma Framework (Library) REVISION D

D23367: make the sizing of the toolbuttons more coherent

2019-08-22 Thread Camilo Higuita
camiloh created this revision. camiloh added reviewers: Plasma, mart, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. camiloh requested review of this revision. REVISION SUMMARY this makes the toolbutton icons follow a standard size. Maybe one coul

D23352: make button icons follow a reasonable size and layout

2019-08-22 Thread Camilo Higuita
This revision was automatically updated to reflect the committed changes. Closed by commit R242:f9736191161b: make button icons follow a reasonable size and layout (authored by camiloh). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23352?v

D23352: make button icons follow a reasonable size and layout

2019-08-22 Thread Camilo Higuita
camiloh marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) BRANCH button-style (branched from master) REVISION DETAIL https://phabricator.kde.org/D23352 To: camiloh, #plasma, mart, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23352: make button icons follow a reasonable size and layout

2019-08-22 Thread Camilo Higuita
camiloh updated this revision to Diff 64365. camiloh added a comment. remove white line REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23352?vs=64317&id=64365 BRANCH button-style (branched from master) REVISION DETAIL https://phabri

D23352: make button icons follow a reasonable size and layout

2019-08-22 Thread Camilo Higuita
camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23352 To: camiloh, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23352: make button icons follow a reasonable size and layout

2019-08-22 Thread Camilo Higuita
camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23352 To: camiloh, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23352: make button icons follow a reasonable size and layout

2019-08-22 Thread Camilo Higuita
camiloh updated this revision to Diff 64317. camiloh added a comment. correct import line REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23352?vs=64315&id=64317 BRANCH button-style (branched from master) REVISION DETAIL https://phab

D23352: make button icons follow a reasonable size and layout

2019-08-22 Thread Camilo Higuita
camiloh created this revision. camiloh added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. camiloh requested review of this revision. REVISION SUMMARY with the Plasma style buttons which have an icon look wrong. The icon size is to

Kirigami breeze icons on android

2018-03-06 Thread Camilo Higuita Rodriguez
file shipped by the project Maybe I'm missing something? I'm using qmake and Kirigami is being statically linked on Android. Saludos, Camilo Higuita