nittest, I can't think of a real-life problem with mtime having a 1s
> > resolution.
>
> Bruno Nova wrote:
> Great! Thank you for unittest!
>
> I think the unittest could also test filenames with spaces, like " with
> spaces " and " " (yes, on
-
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119607/#review72882
---
On Jan. 1, 2015, 9:55 p.m., Bruno Nova wrote:
>
>
required.
The version for KDE4/Qt4 submitted to Bug #246260 was tested in Kubuntu 14.04,
and it worked everywhere I tested (Dolphin, open/save dialogs, folder widget
and detailed/tree view in Dolphin).
It wasn't an intensive test, though.
Thanks,
Bruno Nova
__
omething else, it would be good to add a unittest to
> > autotests/kdirlistertest.cpp (or autotests/kdirmodeltest.cpp).
>
> Bruno Nova wrote:
> OK, I'll try to add a unittest later.
>
> I've searched for a general specification for ".hidden"
t to the "Desktop folder" (the default
option, not the custom location "~/Desktop").
More testing is required.
The version for KDE4/Qt4 submitted to Bug #246260 was tested in Kubuntu 14.04,
and it worked everywhere I tested (Dolphin, open/save dialogs, folder widget
and detailed/t
src/core/kfileitem.h, line 263
> > <https://git.reviewboard.kde.org/r/119607/diff/5/?file=331917#file331917line263>
> >
> > yes, make private, and friend the caller
Done.
- Bruno
---
This is an automaticall
ocation "~/Desktop").
More testing is required.
The version for KDE4/Qt4 submitted to Bug #246260 was tested in Kubuntu 14.04,
and it worked everywhere I tested (Dolphin, open/save dialogs, folder widget
and detailed/tree view in Dolphin).
It wasn't an intensive test, though.
> this class can make items "hidden", I'm not sure if this should be part of
> > KFileItem's public API.
>
> David Faure wrote:
> I don't have an issue with that. Gives more possibilities to the app (or
> file dialog) etc.
>
> Bruno Nova
> this class can make items "hidden", I'm not sure if this should be part of
> > KFileItem's public API.
>
> David Faure wrote:
> I don't have an issue with that. Gives more possibilities to the app (or
> file dialog) etc.
>
> Bruno Nova
> this class can make items "hidden", I'm not sure if this should be part of
> > KFileItem's public API.
>
> David Faure wrote:
> I don't have an issue with that. Gives more possibilities to the app (or
> file dialog) etc.
>
> Bru
t; >
> > This should take care of the case of desktop:/ URLs. Can you test?
>
> Bruno Nova wrote:
> Thanks! I'll test it in a few days. I haven't had time to look into this
> yet.
>
> Bruno Nova wrote:
> I finally had the time to look at th
> > you're not using it anywhere outside KCoreDirLister, right?
>
> Bruno Nova wrote:
> I left this method (and others) public because I thought that, maybe in
> the future, someone may want to use this method.
> But you're right, it's not used any
t to the "Desktop folder" (the default
option, not the custom location "~/Desktop").
More testing is required.
The version for KDE4/Qt4 submitted to Bug #246260 was tested in Kubuntu 14.04,
and it worked everywhere I tested (Dolphin, open/save dialogs, folder widget
and detailed/t
t; >
> > This should take care of the case of desktop:/ URLs. Can you test?
>
> Bruno Nova wrote:
> Thanks! I'll test it in a few days. I haven't had time to look into this
> yet.
>
> Bruno Nova wrote:
> I finally had the time to look at th
t; >
> > This should take care of the case of desktop:/ URLs. Can you test?
>
> Bruno Nova wrote:
> Thanks! I'll test it in a few days. I haven't had time to look into this
> yet.
>
> Bruno Nova wrote:
> I finally had the time to look at th
t; >
> > This should take care of the case of desktop:/ URLs. Can you test?
>
> Bruno Nova wrote:
> Thanks! I'll test it in a few days. I haven't had time to look into this
> yet.
I finally had the time to look at this again.
I tested this, and `dir
an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119607/#review70102
---
On Set. 18, 2014, 10:06 a.m., Bruno Nova wrote:
>
>
----
On Set. 18, 2014, 10:06 a.m., Bruno Nova wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119607/
> ---
struct CacheHiddenFile {
> QDateTime mtime;
> QSet listedFiles;
> }
> QCache
> m_cacheHiddenFiles;
>
> m_cacheHiddenFiles.setMaxCost(10);
>
> This requires making the filesInDotHiddenForDir method no
struct CacheHiddenFile {
> QDateTime mtime;
> QSet listedFiles;
> }
> QCache
> m_cacheHiddenFiles;
>
> m_cacheHiddenFiles.setMaxCost(10);
>
> This requires making the filesInDotHiddenForDir method no
> struct CacheHiddenFile {
> QDateTime mtime;
> QSet listedFiles;
> }
> QCache
> m_cacheHiddenFiles;
>
> m_cacheHiddenFiles.setMaxCost(10);
>
> This requires making the filesInDotHiddenFor
omething else, it would be good to add a unittest to
> > autotests/kdirlistertest.cpp (or autotests/kdirmodeltest.cpp).
>
> Bruno Nova wrote:
> OK, I'll try to add a unittest later.
>
> I've searched for a general specification for ".hidden"
e issues,
it can be reverted easily.
- Bruno
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119607/#review66872
---
On Set. 18,
> On Set. 14, 2014, 3:27 p.m., Frank Reininghaus wrote:
> > src/core/kcoredirlister.cpp, line 1218
> > <https://git.reviewboard.kde.org/r/119607/diff/2/?file=301215#file301215line1218>
> >
> > const
>
> Bruno Nova wrote:
> What do you mean?
n again,
maybe there's no impact and the compiler optimizes that.
I moved the declaration to where it's first used.
- Bruno
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/
;~/Desktop").
More testing is required.
The version for KDE4/Qt4 submitted to Bug #246260 was tested in Kubuntu 14.04,
and it worked everywhere I tested (Dolphin, open/save dialogs, folder widget
and detailed/tree view in Dolphin).
It wasn't an intensive test, though.
Thanks,
Bruno
> On Set. 14, 2014, 3:27 p.m., Frank Reininghaus wrote:
> > src/core/kcoredirlister.cpp, line 2801
> > <https://git.reviewboard.kde.org/r/119607/diff/2/?file=301215#file301215line2801>
> >
> > I think that you can remove this line.
>
> Bruno Nova wrote
e testing is required.
The version for KDE4/Qt4 submitted to Bug #246260 was tested in Kubuntu 14.04,
and it worked everywhere I tested (Dolphin, open/save dialogs, folder widget
and detailed/tree view in Dolphin).
It wasn't an intensive test, though.
Thanks,
Bruno Nova
___
-----
On Set. 14, 2014, 3:32 p.m., Bruno Nova wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119607/
>
Bruno
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119607/#review66475
---
On Set. 14, 2014, 3:32 p.m., Bruno
sktop").
More testing is required.
The version for KDE4/Qt4 submitted to Bug #246260 was tested in Kubuntu 14.04,
and it worked everywhere I tested (Dolphin, open/save dialogs, folder widget
and detailed/tree view in Dolphin).
It wasn't an intensive test, though.
Thanks,
Bruno Nova
_
31 matches
Mail list logo
