Re: Review Request 127470: kcodecs: Fix crash on invalid data

2016-03-25 Thread Boris Egorov
how to fix it properly. Diffs - autotests/kencodingprobertest.h e4edb06 autotests/kencodingprobertest.cpp 937bc13 src/probers/ctype_test_p.h 0421f99 Diff: https://git.reviewboard.kde.org/r/127470/diff/ Testing --- Build and run tests - all passes. Crash in #360797 is gone.

Review Request 127470: kcodecs: Fix crash on invalid data

2016-03-23 Thread Boris Egorov
6 autotests/kencodingprobertest.cpp 937bc13 src/probers/ctype_test_p.h 0421f99 Diff: https://git.reviewboard.kde.org/r/127470/diff/ Testing --- Build and run tests - all passes. Crash in #360797 is gone. Thanks, Boris Egorov ___ Kde-frameworks-devel ma

Re: Review Request 124821: karchive: Fix krazy2 warnings (foreach usage)

2015-08-20 Thread Boris Egorov
, Boris Egorov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124821: karchive: Fix krazy2 warnings (foreach usage)

2015-08-20 Thread Boris Egorov
> On Aug. 19, 2015, 7:41 p.m., Albert Astals Cid wrote: > > I meant all the explicit, not only this one, by declaring it explicit we > > are changing the source compatibility, personally i'd reduce the patch to > > just the foreach const & > > Boris Ego

Re: Review Request 124821: karchive: Fix krazy2 warnings (foreach usage)

2015-08-19 Thread Boris Egorov
(updated) - src/k7zip.cpp bdb2e5a Diff: https://git.reviewboard.kde.org/r/124821/diff/ Testing --- Build karchive, ktexteditor, kio. Thanks, Boris Egorov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 124821: karchive: Fix krazy2 warnings (explicit ctors, foreach)

2015-08-19 Thread Boris Egorov
- On Aug. 19, 2015, 3:51 p.m., Boris Egorov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124821/ > --

Re: Review Request 124821: karchive: Fix krazy2 warnings (explicit ctors, foreach)

2015-08-19 Thread Boris Egorov
: https://git.reviewboard.kde.org/r/124821/diff/ Testing --- Build karchive, ktexteditor, kio. Thanks, Boris Egorov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 124821: karchive: Fix krazy2 warnings (explicit ctors, foreach)

2015-08-19 Thread Boris Egorov
, ktexteditor, kio. Thanks, Boris Egorov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123598: kio: Fix more issues with QFile::rename return value

2015-05-03 Thread Boris Egorov
marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 36400c2f6e038e5028bf6347108270ec50cb1de2 by Boris Egorov to branch master. Repository: kio Description --- See my previous commit: e5c3f7eda489. I grepped kf5 sources to search

Review Request 123598: kio: Fix more issues with QFile::rename return value

2015-05-03 Thread Boris Egorov
kio builds successfully. Thanks, Boris Egorov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123590: ftp slave: Fix conditions for QFile::rename

2015-05-02 Thread Boris Egorov
marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit e5c3f7eda489ee22c2f9f266884faa43f444f03c by Boris Egorov to branch master. Bugs: 343329 https://bugs.kde.org/show_bug.cgi?id=343329 Repository: kio Description --- QFile

Re: Review Request 123589: kioexec: Fix path for writable location for kurl

2015-05-02 Thread Boris Egorov
marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit b290473167b9d0388715fffe494ee95a5c2c2851 by Boris Egorov to branch master. Bugs: 342732 https://bugs.kde.org/show_bug.cgi?id=342732 Repository: kio Description --- There

Re: Review Request 123590: ftp slave: Fix conditions for QFile::rename

2015-05-02 Thread Boris Egorov
from ftp loads and showed successfully. Thanks, Boris Egorov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123589: kioexec: Fix path for writable location for kurl

2015-05-02 Thread Boris Egorov
paths.html#writableLocation 2: https://bugs.kde.org/show_bug.cgi?id=343329 Diffs - src/kioexec/main.cpp 8fb7ef3 Diff: https://git.reviewboard.kde.org/r/123589/diff/ Testing --- New behavior was tested by removing CacheLocation, and it successfully creates needed path. Thanks, Bo