Re: Review Request 123929: If double-click is on empty area, then invoke back. (kfilewidgets)

6d601f3 src/filewidgets/kdiroperator.cpp 4a7ef02 Diff: https://git.reviewboard.kde.org/r/123929/diff/2/ Testing --- Works fine! Thanks, Ashish Bansal

Re: Review Request 123929: If double-click is on empty area, then invoke back. (kfilewidgets)

(dolphin) Diffs (updated) - src/filewidgets/kdiroperator.h 6d601f3 src/filewidgets/kdiroperator.cpp 4a7ef02 Diff: https://git.reviewboard.kde.org/r/123929/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Kde-frameworks-devel

Re: Review Request 123929: If double-click is on empty area, then invoke back. (kfilewidgets)

> On May 29, 2015, 12:45 p.m., David Faure wrote: > > I'm not sure this is a good idea, usability wise. Miss an icon by one > > pixel, and the effect is to go up, making the whole set of icons disappear? > > Ashish Bansal wrote: > Well about usability there&

Re: Review Request 123929: If double-click is on empty area, then invoke back. (kfilewidgets)

tps://git.reviewboard.kde.org/r/123929/#comment55464> Double click on item goes into that directory and then comes back. I'll fix it soon. - Ashish Bansal On May 28, 2015, 11:30 p.m., Ashish Bansal wrote: > > --- > This

Re: Review Request 123929: If double-click is on empty area, then invoke back. (kfilewidgets)

- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123929/#review80946 --- On May 28, 2015, 11:30 p.m., Ashish Bansal wrote: > > --- &g

Review Request 123929: If double-click is on empty area, then invoke back. (kfilewidgets)

fine! Thanks, Ashish Bansal ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

marked as submitted. Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun AK. Changes --- Submitted with commit c806f88e4ea65330719fa1721cdf15ea5cbddb5a by Ashish Bansal to branch master. Bugs: 341773 https://bugs.kde.org/show_bug.cgi?id=341773 Repository: kio

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

name: filename-1.6 (1).tar.gz Diffs (updated) - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Kde-frameworks

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

Do we even need this special case, with the way the code is now? It > > seems to me that removing this first if() branch would work just the same. > > Ashish Bansal wrote: > The first if() has been used for getting ". (1).txt" instead of ".txt (1)&

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review79629 ----------- On April 30, 2015, 9:05 a.m., Ashish Bansal wrote: > > -

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

). Expected name: filename-1.6 (1).tar.gz Diffs (updated) - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Kde-frameworks

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

gests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish B

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

> On April 6, 2015, 1:12 p.m., Martin Klapetek wrote: > > autotests/globaltest.cpp, line 96 > > <https://git.reviewboard.kde.org/r/123224/diff/2/?file=359784#file359784line96> > > > > This should be (1).txt? > > Ashish Bansal wrote: > imho if

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review79509 ------- On April 26, 2015, 12:19 p.m., Ashish Bansal wrote: > > --- > This is an aut

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

ted e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review78559 ------- On April 4, 2015, 1:15 p.m., Ashish Bansal wrote: > > --- > This is an

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel