marked as submitted.
Review request for KDE Frameworks, Aleix Pol Gonzalez and Sergio Martins.
Changes
---
Submitted with commit 8d8a20f3d066e886dfbd63c739cf0dd5a50d58a5 by Lamarque V.
Souza on behalf of Artur Puzio to branch master.
Repository: karchive
Description
---
Fixed
view90401
---
On Gru 23, 2015, 8:50 po południu, Artur Puzio wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewb
marked as submitted.
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Changes
---
Submitted with commit 5568d780b22e9b247ff2721346f3f380ab2c2a1d by Aleix Pol on
behalf of Artur Puzio to branch master.
Repository: kparts
Description
---
Fixed `warning: QString* being called
to compile it. (of
course the changed isn't included in this RR)
Thanks,
Artur Puzio
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
6620/diff/
Testing
---
Automated tests pass.
Imported note: On my computer I'm runing versions 5.17.0 and it wasn't possible
for me to upgrade easly, so I changed the CMakeFiles.txt to compile it. (of
course the changed isn't included in this RR)
Thanks,
Artur Puzio
> On Gru 23, 2015, 3:49 po południu, Aleix Pol Gonzalez wrote:
> > src/k7zip.cpp, line 2029
> > <https://git.reviewboard.kde.org/r/126429/diff/1/?file=424823#file424823line2029>
> >
> > I wouldn't get this all in. Is that suggested by
> > `-Wclazy
: unused variable [-Wunused-const-variable], by commenting unused
variables
Diffs (updated)
-
src/k7zip.cpp 7b5e6a3
Diff: https://git.reviewboard.kde.org/r/126429/diff/
Testing
---
Automated tests pass.
Thanks,
Artur Puzio
___
Kde
> On Gru 23, 2015, 3:49 po południu, Aleix Pol Gonzalez wrote:
> > src/k7zip.cpp, line 2029
> > <https://git.reviewboard.kde.org/r/126429/diff/1/?file=424823#file424823line2029>
> >
> > I wouldn't get this all in. Is that suggested by
> > `-Wclazy
marked as submitted.
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Changes
---
Submitted with commit 44dc685db39d8c762e51af82da45582db4fe7bf0 by Aleix Pol on
behalf of Artur Puzio to branch master.
Repository: ki18n
Description
---
Fixed `warning: KuitSetup has dtor
On Gru 23, 2015, 3:49 po południu, Artur Puzio wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126429/
>
---
On Gru 23, 2015, 3:49 po południu, Artur Puzio wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126429/
> --
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126350/#review89750
---
Hey, when my patch will be reviewed?
- Artur Puzio
On Gru
> On Gru 19, 2015, 4:55 po południu, Aleix Pol Gonzalez wrote:
> > In general I don't like commented code. Why keep it?
> > David, do you think we should keep it?
> >
> > Artur, have you made sure the tests still pass? It doesn't say so in the
>
----
On Gru 19, 2015, 4:56 po południu, Artur Puzio wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126429/
> -
warning: unused variable [-Wunused-const-variable], by commenting unused
variables
Diffs
-
src/k7zip.cpp 7b5e6a3
Diff: https://git.reviewboard.kde.org/r/126429/diff/
Testing
---
Automated tests pass.
Thanks,
Artur Puzio
___
Kde-frameworks
a3
src/kuitmarkup.cpp 02b891a
Diff: https://git.reviewboard.kde.org/r/126350/diff/
Testing
---
Automated tests 1,3 and 4 passing.
Test 2 fails on my system both: after changes and before.
Thanks,
Artur Puzio
___
Kde-frameworks-devel mailing
the first place?
> there is operator<<(const char * s) for latin1 text, which is the case
> (i.e. no non-latin symbols are used in the literals)
>
> using strings for debugging output is suboptimal
>
> Artur Puzio wrote:
> look at line 487:
> ```
>
d2
src/ktranscript.cpp 04dda66
src/kuitmarkup.h d110ca3
src/kuitmarkup.cpp 02b891a
Diff: https://git.reviewboard.kde.org/r/126350/diff/
Testing
---
Automated tests 1,3 and 4 passing.
Test 2 fails on my system both: after changes and before.
Thanks,
Ar
-
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126350/#review89492
---
On Gru 14, 2015, 7:46 po południu, Artur Puzio wrote:
>
>
sing.
Test 2 fails on my system both: after changes and before.
Thanks,
Artur Puzio
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
anks,
Artur Puzio
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
21 matches
Mail list logo
