Re: Review Request 124788: Replace std::auto_ptr with std::unique_ptr

2015-09-22 Thread Armin K.
/graphics/SVGPaintServerPattern.h 5ba655f src/svg/graphics/SVGPaintServerPattern.cpp 7fcd4f3 Diff: https://git.reviewboard.kde.org/r/124788/diff/ Testing --- It builds! Thanks, Armin K. ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 124788: Replace std::auto_ptr with std::unique_ptr

2015-09-22 Thread Armin K.
/graphics/SVGPaintServerPattern.cpp 7fcd4f3 Diff: https://git.reviewboard.kde.org/r/124788/diff/ Testing --- It builds! Thanks, Armin K. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 124789: Respect -DBUILD_TESTING=OFF

2015-08-18 Thread Armin K.
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 433254caa442e86dd8bef15dc25558b494b6633b by David Rosca on behalf of Armin K to branch master. Repository: bluez-qt Description --- Other frameworks don't uncoditionally enable buildi

Re: Review Request 124789: Respect -DBUILD_TESTING=OFF

2015-08-17 Thread Armin K.
> On Aug. 17, 2015, 3:51 p.m., David Rosca wrote: > > Thanks. I will commit it for you. > > David Rosca wrote: > But I need your full name. I've used Armin K. all the time I've been online and nobody has complained when using it in git commits. I don't

Review Request 124789: Respect -DBUILD_TESTING=OFF

2015-08-17 Thread Armin K.
Testing --- I have verified that no files in tests and autotests subdir were built when -DBUILD_TESTING=OFF was passed to cmake. Everything was built when the mentioned build option wasn't used. Thanks, Armin K. ___ Kde-frameworks-devel m

Review Request 124788: Replace std::auto_ptr with std::unique_ptr

2015-08-17 Thread Armin K.
73b9f src/svg/graphics/SVGPaintServerPattern.h 5ba655f src/svg/graphics/SVGPaintServerPattern.cpp 7fcd4f3 Diff: https://git.reviewboard.kde.org/r/124788/diff/ Testing --- It builds! Thanks, Armin K. ___ Kde-frameworks-devel mailing lis

Re: Review Request 121086: Rename jpegcreatorsettings.kcfg to avoid conflicts with KDE4

2015-04-19 Thread Armin K.
/diff/ Testing --- Thanks, Armin K. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

2015-02-09 Thread Armin K.
- network/ioslave/CMakeLists.txt 06a964d network/kded/CMakeLists.txt 3be676e network/network/CMakeLists.txt c0fb43e Diff: https://git.reviewboard.kde.org/r/121084/diff/ Testing --- Thanks, Armin K. ___ Kde-frameworks-devel mailing list

Re: Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

2015-01-09 Thread Armin K.
4/#review73572 --- On Nov. 9, 2014, 4:10 p.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.re

Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

2014-11-09 Thread Armin K.
/network/CMakeLists.txt c0fb43e Diff: https://git.reviewboard.kde.org/r/121084/diff/ Testing --- Thanks, Armin K. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121086: Rename jpegcreatorsettings.kcfg to avoid conflicts with KDE4

2014-11-09 Thread Armin K.
68f46 thumbnail/jpegcreatorsettings.kcfgc 3f6cdab thumbnail/jpegcreatorsettings5.kcfg PRE-CREATION thumbnail/jpegcreatorsettings5.kcfgc PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121086/diff/ Testing --- Thanks, Armin K. __