This revision was automatically updated to reflect the committed changes.
Closed by commit R236:d47b970e9802: Fix
KActionSelectorPrivate::insertionIndex() (authored by antonanikin).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5329?vs=13177&id=13315
antonanikin added a comment.
In https://phabricator.kde.org/D5275#100458, @ochurlaud wrote:
> Corrected antonanikin issue
Olivier, thanks for fixing - now such collapsable lists works good.
REPOSITORY
R264 KApiDox
REVISION DETAIL
https://phabricator.kde.org/D5275
To: ochurla
antonanikin added a comment.
> Is this really needed?
> Without your code it defaults to
> index = -1;
> what is the same as appending that is the same as atBottom, no?
Yes, it needed - see here about negative index
http://code.qt.io/cgit/qt/qtbase.git/tree/src/widgets/itemviews/
antonanikin edited the summary of this revision.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D5329
To: antonanikin, #frameworks
Cc: kde-frameworks-devel
antonanikin added a subscriber: kde-frameworks-devel.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D5329
To: antonanikin, #frameworks
Cc: kde-frameworks-devel
antonanikin created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Old version ignores InsertionPolicy::AtBottom enum value and produce behavior
same as for InsertionPolicy::AtTop.
REPOSITORY
R236 KWidgetsAddons
BRANCH
master
REVISION DETAIL
https:/
antonanikin added a comment.
Hi, Olivier.
Your QCH files displayed normally but with one bug - broken links for some
JavaScript code. For example open `KTipDialog` class doc from your `Frameworks`
file. Then try to click (open) `Public Member Functions inherited from QDialog`
- nothing
