D8705: Remove Qt5::Widgets as a dependency

asturmlechner added a comment. Herald added a subscriber: kde-frameworks-devel. FYI, after https://invent.kde.org/frameworks/kwindowsystem/-/commit/5cc5734b46cd3bcc2a35402718731cdae5000803 and https://invent.kde.org/frameworks/kwindowsystem/-/commit/374a29075694f530d2d0673e33a166c83

D14967: Disable loading of translations for kformattest, which was not designed with translations

asturmlechner added a comment. Hm, I find myself disabling ever more tests because I get a report like kformattest when someone has translations installed. How does CI get over that? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14967 To: habacker, dfaure, aac

T11542: Remove KHTML

asturmlechner added a subtask: T13968: Port KTechlab away from KHTML. TASK DETAIL https://phabricator.kde.org/T11542 To: asturmlechner Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, #frameworks, knauss, davidre, GB_2, ahmadsamir, kpiwowarski, usta, asturmlechner,

T11542: Remove KHTML

asturmlechner added a subtask: T13967: Port Kopete away from KHTML. TASK DETAIL https://phabricator.kde.org/T11542 To: asturmlechner Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, #frameworks, knauss, davidre, GB_2, ahmadsamir, kpiwowarski, usta, asturmlechner, ju

D19338: New location for KNSRC files

asturmlechner added a comment. In D19338#676682 , @kossebau wrote: > In D19338#676680 , @asturmlechner wrote: > > > Hm, why was this new variable KDE_INSTALL_KNSRCDIR not put into KDEInstallDirs?

D19338: New location for KNSRC files

asturmlechner added a comment. Hm, why was this new variable KDE_INSTALL_KNSRCDIR not put into KDEInstallDirs? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19338 To: leinir, #knewstuff, apol, ngraham, fvogt Cc: asturmlechner, kossebau, kde-frameworks-devel, #kn

D17205: Build kio_nfs against standalone libtirpc

This revision was automatically updated to reflect the committed changes. Closed by commit R320:1029148d9ca7: Build kio_nfs against standalone libtirpc (authored by asturmlechner). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17205?vs=46374&id=76978#toc REPOSITORY R320 KIO Extras CH

D26306: Define more documentation search paths (also custom)

asturmlechner added a comment. In D26306#585587 , @asturmlechner wrote: > Thanks for that, works for me! Correction, the tests seem to fail even though runtime is fine. See also https://bugs.gentoo.org/705340 REPOSITORY R238 KDocTools

D26596: Drop unused dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R252:08b1eabe3f54: Drop unused dependency (authored by asturmlechner). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26596?vs=73318&id=73320 REVISION DET

D26597: Drop HAVE_X11 remnants

asturmlechner closed this revision. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D26597 To: asturmlechner, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26596: Drop unused dependency

asturmlechner created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. asturmlechner requested review of this revision. REPOSITORY R252 Framework Integration BRANCH unused-deps REVISION DETAIL https://phabricator.kde.org/D26596 AFFECTED F

D26597: Drop HAVE_X11 remnants

asturmlechner created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. asturmlechner requested review of this revision. REPOSITORY R252 Framework Integration BRANCH no-have-x11 REVISION DETAIL https://phabricator.kde.org/D26597 AFFECTED F

D26306: Define more documentation search paths (also custom)

asturmlechner added a comment. Thanks for that, works for me! REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D26306 To: ltoscano Cc: cgiboudeaux, lbeltrame, rdieter, arojas, rikmills, maximilianocuria, asturmlechner, kde-frameworks-devel, kde-doc-english, LeGast00

D25812: ECMFindQMLModule.cmake.in: Add ECM_DISABLE_QMLPLUGINDUMP to avoid sandbox violations

asturmlechner added a reviewer: Frameworks. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25812 To: asturmlechner, #frameworks Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D25812: ECMFindQMLModule.cmake.in: Add ECM_DISABLE_QMLPLUGINDUMP to avoid sandbox violations

asturmlechner created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. asturmlechner requested review of this revision. REVISION SUMMARY In the end, not opening device nodes readonly just because it does not concern

D25809: Use standard ECMQMLModules

This revision was automatically updated to reflect the committed changes. Closed by commit R495:8d7123896b98: Use standard ECMQMLModules (authored by asturmlechner). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25809?vs=71085&id=71087 REVISION DETAI

D25809: Use standard ECMQMLModules

asturmlechner created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. asturmlechner requested review of this revision. REVISION SUMMARY Drop obsolete QMLModules.cmake and FindQMLModule.cmake.in Superseded by standard ECM modules. TEST PLA

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

asturmlechner closed this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D23229 To: asturmlechner, #frameworks, ltoscano Cc: ltoscano, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

asturmlechner marked 2 inline comments as done. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D23229 To: asturmlechner, #frameworks Cc: ltoscano, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

asturmlechner updated this revision to Diff 63954. asturmlechner added a comment. Use deprecated variables as fallback if defined REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23229?vs=63952&id=63954 BRANCH kdeinstalldirs REVISION DETAIL https://ph

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

asturmlechner added a reviewer: Frameworks. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D23229 To: asturmlechner, #frameworks Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

asturmlechner created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. asturmlechner requested review of this revision. REVISION SUMMARY HTML_INSTALL_DIR -> KDE_INSTALL_DOCBUNDLEDIR MAN_INSTALL_DIR -> KDE_INSTALL_

D21400: Downgrade KDEWebKit from Tier 3 to Porting Aids

asturmlechner added a comment. This should probably also be posted on release-team ML. REPOSITORY R300 KDEWebKit BRANCH master REVISION DETAIL https://phabricator.kde.org/D21400 To: vkrause, apol, cullmann Cc: cullmann, apol, asturmlechner, kde-frameworks-devel, LeGast00n, michaelh,

D12761: Allow building kio-nfs against standalone libtirpc

asturmlechner added a comment. In D12761#367223 , @arojas wrote: > @asturmlechner can you post that in a new review request? I'll abandon this one. Done, this is now in https://phabricator.kde.org/D17205 REPOSITORY R320 KIO Extras REV

D17205: Build kio_nfs against standalone libtirpc

asturmlechner created this revision. asturmlechner added reviewers: Dolphin, dfaure, rdieter. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. asturmlechner requested review of this revision. REVISION SUMMARY Since glibc-2.26, cmake skipped o

D12761: Allow building kio-nfs against standalone libtirpc

asturmlechner added inline comments. INLINE COMMENTS > cgiboudeaux wrote in CMakeLists.txt:4 > Any solution is fine however, we now patched ours kdebase4-runtime package to > disable kio-nfs completely. Pick the solution you prefer. Thanks, your FindTIRPC works for me. This is what I came up wi

D12761: Allow building kio-nfs against standalone libtirpc

asturmlechner added inline comments. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. INLINE COMMENTS > CMakeLists.txt:175 > + add_feature_info("NFS kioslave" RPC_H_DIR "The RPC library is needed to > build the NFS kioslave") > + if(RPC_H

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

asturmlechner added a comment. The problem with that is cmake picking the wrong dir (first in order is `lib`, while it should be e.g. `lib64`). REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13585 To: asturmlechner, #baloo Cc: pino, kde-frameworks-devel, #baloo, asha

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

asturmlechner added a comment. Not convinved it is the best way but it is some way to make it point to the desired multiarch libdir rather than make it choose a random one. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13585 To: asturmlechner, #baloo Cc: kde-framewo

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

asturmlechner added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13585 To: asturmlechner, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

asturmlechner created this revision. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. asturmlechner requested review of this revision. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde

D12696: Use the new uds implementation

asturmlechner added a comment. No crash in my case, but this commit makes links with sftp:/ inaccessible. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12696 To: jtamate, dfaure, #frameworks Cc: asturmlechner, martinkostolny, kde-frameworks-devel, bruns, michaelh, ngr

D10587: Restore KTextEditor Document Dbus bindings

asturmlechner added a comment. This change has history, for reference: https://git.reviewboard.kde.org/r/129398/ REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10587 To: lukedashjr, cullmann, dhaumann, gregormi Cc: anthonyfieroni, #ktexteditor, #kate, asturmlech

D10201: FindQtWaylandScanner.cmake: Use qmake-query for HINT

asturmlechner closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D10201 To: asturmlechner, #frameworks, #build_system, cgiboudeaux Cc: michaelh, ngraham

D10201: FindQtWaylandScanner.cmake: Use qmake-query for HINT

asturmlechner created this revision. asturmlechner added reviewers: Frameworks, Build System, cgiboudeaux. Restricted Application added projects: Frameworks, Build System. asturmlechner requested review of this revision. REVISION SUMMARY Instead of hardcoded /usr/lib, same solution as in https:

D9116: Make sure to search for Qt5-based qmlplugindump

This revision was automatically updated to reflect the committed changes. Closed by commit R240:92eb3e9767cb: Make sure to search for Qt5-based qmlplugindump (authored by asturmlechner). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9116?vs=26253&

D9116: Make sure to search for Qt5-based qmlplugindump

asturmlechner added a comment. Want me to fix FindQtWaylandScanner.cmake in the same way? REPOSITORY R240 Extra CMake Modules BRANCH arcpatch-D9116 REVISION DETAIL https://phabricator.kde.org/D9116 To: asturmlechner, apol, cgiboudeaux Cc: aacid, dfaure, cgiboudeaux, #frameworks, #buil

D9116: Make sure to search for Qt5-based qmlplugindump

asturmlechner edited the summary of this revision. REPOSITORY R240 Extra CMake Modules BRANCH arcpatch-D9116 REVISION DETAIL https://phabricator.kde.org/D9116 To: asturmlechner, apol, cgiboudeaux Cc: aacid, dfaure, cgiboudeaux, #frameworks, #build_system, michaelh, ngraham

D9116: Make sure to search for Qt5-based qmlplugindump

asturmlechner updated this revision to Diff 26253. asturmlechner added a comment. Use ECMQueryQmake.cmake as suggested. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9116?vs=23304&id=26253 BRANCH arcpatch-D9116 REVISION DETAIL https://pha

D9880: Fix build with >=attr-2.4.48

This revision was automatically updated to reflect the committed changes. Closed by commit R286:4bbc7a2f5c77: Fix build with >=attr-2.4.48 (authored by Lars Wendler , committed by asturmlechner). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabric

D9880: Fix build with >=attr-2.4.48

asturmlechner added a comment. In https://phabricator.kde.org/D9880#191545, @mgallien wrote: > Are you sure attr/xattr.h is deprecated ? Yep, it is gone in 2.4.48, but the commit that removed it is from 2015: http://git.savannah.nongnu.org/cgit/attr.git/commit/?id=7921157890d07858

D9880: Fix build with >=attr-2.4.48

asturmlechner created this revision. asturmlechner added reviewers: Frameworks, mgallien. Restricted Application added a project: Frameworks. asturmlechner requested review of this revision. REVISION SUMMARY It was looking for long deprecated attr/xattr.h header. TEST PLAN Built fine with att

D9116: Make sure to search for Qt5-based qmlplugindump

asturmlechner added a comment. Can we move forward with this? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9116 To: asturmlechner, apol Cc: aacid, dfaure, cgiboudeaux, #frameworks, #build_system

D9116: Make sure to search for Qt5-based qmlplugindump

asturmlechner added a comment. In https://phabricator.kde.org/D9116#174894, @aacid wrote: > is this a problem caused by qmlplugindump being one of those magic things that are "symlinks" to the qt4 or qt5 depending on the QT_SELECT env var? exactly REPOSITORY R240 Extra CMake Mo

D9116: Make sure to search for Qt5-based qmlplugindump

asturmlechner added a comment. In https://phabricator.kde.org/D9116#174856, @dfaure wrote: > Which distro was this commit for? Looks like a debian/ubuntu path? If so, how did this go unnoticed until now? This is for Gentoo - now I don't do Qt packaging, but as far as I'm aware th

D9116: Make sure to search for Qt5-based qmlplugindump

asturmlechner created this revision. asturmlechner added a reviewer: apol. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY Without any hint, qmlplugindump version is whatever default is set by

D7330: Don't enter test subdirectories if BUILD_TESTING=OFF

asturmlechner closed this revision. asturmlechner added a comment. Thanks! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D7330 To: asturmlechner, #frameworks, dfaure, mgallien

D7330: Don't enter test subdirectories if BUILD_TESTING=OFF

asturmlechner added a reviewer: dfaure. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D7330 To: asturmlechner, #frameworks, dfaure

D7328: Don't enter test subdirectories if BUILD_TESTING=OFF

asturmlechner closed this revision. asturmlechner added a comment. Merged, closing manually. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7328 To: asturmlechner, #frameworks, dfaure

D7230: Save up a bunch of stat() calls on application start

asturmlechner accepted this revision. asturmlechner added a comment. Briefly runtime tested it as well with and without translations, no issues. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D7230 To: apol, #frameworks, dfaure, asturmlechner Cc: lto

D7330: Don't enter test subdirectories if BUILD_TESTING=OFF

asturmlechner created this revision. Restricted Application added a project: Frameworks. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D7330 AFFECTED FILES CMakeLists.txt src/file/extractor/CMakeLists.txt To: asturmlechner, #frameworks

D7328: Don't enter test subdirectories if BUILD_TESTING=OFF

asturmlechner created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY The proposed change to ECMAddTest was reverted because it led to failures with subsequent calls depending on then nonexisting test targets. Instead, just make the test subdirectories con

D7230: Save up a bunch of stat() calls on application start

asturmlechner added a comment. Sounds fine. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D7230 To: apol, #frameworks, dfaure, asturmlechner Cc: ltoscano, aacid, dfaure, elvisangelaccio, broulik

D7230: Save up a bunch of stat() calls on application start

asturmlechner added a comment. Thanks for adding me, at least Gentoo indeed supports stripping translations even after they were moved into the packages - so that would break. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D7230 To: apol, #framework

D7213: Use ecm_add_test and benefit from BUILD_TESTING awareness

This revision was automatically updated to reflect the committed changes. Closed by commit R241:dec4afb4145b: Use ecm_add_test and benefit from BUILD_TESTING awareness (authored by asturmlechner). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7213?vs=17908&id=179

D7213: Use ecm_add_test and benefit from BUILD_TESTING awareness

asturmlechner created this revision. Restricted Application added a project: Frameworks. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D7213 AFFECTED FILES src/ioslaves/trash/tests/CMakeLists.txt To: asturmlechner, #frameworks Cc: kfunk

D7156: Qt5DBus is only required with HAVE_XSCREENSAVER

This revision was automatically updated to reflect the committed changes. Closed by commit R274:93a2acfe2e66: Qt5DBus is only required with HAVE_XSCREENSAVER (authored by asturmlechner). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7156?vs=17763&id=17852#toc REPOSITORY R274 KIdleTime

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

asturmlechner added a comment. In https://phabricator.kde.org/D7187#11, @kfunk wrote: > Anyhow, this patch tries to make it easy to build KDevelop without tests; trying to avoid hacky approaches like those being done in Gentoo: Much appreciated if we can drop those. REPOSITOR

D7156: Qt5DBus is only required with HAVE_XSCREENSAVER

asturmlechner added a reviewer: Frameworks. REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D7156 To: asturmlechner, #frameworks Cc: #frameworks

D7156: Qt5DBus is only required with HAVE_XSCREENSAVER

asturmlechner created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN Continues to build fine. REPOSITORY R274 KIdleTime BRANCH master REVISION DETAIL https://phabricator.kde.org/D7156 AFFECTED FILES

D6493: Add KF5WindowSystem to link interface

This revision was automatically updated to reflect the committed changes. Closed by commit R242:5033a104e226: Add KF5WindowSystem to link interface (authored by asturmlechner). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6493?vs=16896&id=

D6493: Add KF5WindowSystem to link interface

asturmlechner updated this revision to Diff 16896. asturmlechner added a comment. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Changed according to review REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https

D6495: Don't list KF5::WindowSystem in public libraries

asturmlechner added a comment. Thanks, works for me! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6495 To: davidedmundson, #plasma Cc: asturmlechner, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts

D6493: Add KF5WindowSystem to link interface

asturmlechner abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6493 To: asturmlechner, #plasma Cc: davidedmundson, #frameworks

D6493: Add KF5WindowSystem to link interface

asturmlechner added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6493 To: asturmlechner, #plasma Cc: #frameworks

D6493: Add KF5WindowSystem to link interface

asturmlechner created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Otherwise, reverse-dependencies are bugged with finding KF5WindowSystem themselves. TEST PLAN Builds fine, plasma-sdk does not nee

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

> On April 1, 2017, 7:59 p.m., David Faure wrote: > > Makes sense to me, +1. > > Andreas Sturmlechner wrote: > Thanks, anyone else who wants to +1? > > I've tried to test migration today but it didn't work. May as well have > nothing to

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

marked as submitted. Review request for KDE Frameworks and Stefan Brüns. Changes --- Submitted with commit c2fe10e2e75304114de89aa83381cfa20e6e9734 by Andreas Sturmlechner on behalf of Stefan Brüns to branch master. Repository: kwallet Description --- These are not my own patches

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

> On April 1, 2017, 7:59 p.m., David Faure wrote: > > Makes sense to me, +1. > > Andreas Sturmlechner wrote: > Thanks, anyone else who wants to +1? > > I've tried to test migration today but it didn't work. May as well have > nothing to

Re: Review Request 122206: [kio] Make tests optional

://git.reviewboard.kde.org/r/122206/diff/ Testing --- Thanks, Andreas Sturmlechner

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

> On April 1, 2017, 7:59 p.m., David Faure wrote: > > Makes sense to me, +1. > > Andreas Sturmlechner wrote: > Thanks, anyone else who wants to +1? > > I've tried to test migration today but it didn't work. May as well have > nothing to

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

> On April 1, 2017, 7:59 p.m., David Faure wrote: > > Makes sense to me, +1. > > Andreas Sturmlechner wrote: > Thanks, anyone else who wants to +1? > > I've tried to test migration today but it didn't work. May as well have > nothing to

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

30058/#review102982 --- On March 29, 2017, 12:52 p.m., Andreas Sturmlechner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://g

Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

have kwalletd4 installed anymore. Thanks, Andreas Sturmlechner

Re: Review Request 129742: Add option FORCE_ENABLE_HUNSPELL

ps://git.reviewboard.kde.org/r/129742/#review101749 ------- On Jan. 1, 2017, 11:01 p.m., Andreas Sturmlechner wrote: > > --- > This is an automatically generated e-mail.

Review Request 129742: Add option FORCE_ENABLE_HUNSPELL

. This was the least disruptive solution I could come up with. Diffs - CMakeLists.txt edac12f6cdc1fddc7f6b9df0baeb519a6c6502fb src/plugins/CMakeLists.txt 58b254c670e7e57202bbc9c889c86a48041a044e Diff: https://git.reviewboard.kde.org/r/129742/diff/ Testing --- Thanks, Andreas

Re: Review Request 129613: Revert "If Gpgmepp is not found, try to use KF5Gpgmepp"

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 47323f431f5ccea34dd7d21668d625bd9651dfec by Andreas Sturmlechner to branch master. Repository: kwallet Description --- GpgME-1.7.0 released > 2 months ago, KF5Gpgmepp no lon

Re: Review Request 129613: Revert "If Gpgmepp is not found, try to use KF5Gpgmepp"

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 47323f431f5ccea34dd7d21668d625bd9651dfec by Andreas Sturmlechner to branch master. Repository: kwallet Description --- GpgME-1.7.0 released > 2 months ago, KF5Gpgmepp no lon

Re: Review Request 129611: Make Gpgme a required dependency if we build Gpgme interface.

, but not Gpgme? In the past, that call was necessary to fix build with gpgme not being in a subdir below /usr/include, but not anymore. I guess there would be a way to get rid of gpgme.h instead. - Andreas Sturmlechner On Dec. 4, 2016, 12:49 a.m., Sandro Knauß wrote

Re: Review Request 129613: Revert "If Gpgmepp is not found, try to use KF5Gpgmepp"

https://git.reviewboard.kde.org/r/129613/diff/ Testing --- Thanks, Andreas Sturmlechner

Review Request 129613: Revert "If Gpgmepp is not found, try to use KF5Gpgmepp"

txt fe72f2ef50417010a9c49b9b6dfdf6465c2e23fb src/runtime/kwalletd/backend/CMakeLists.txt 0bd312688b2cdc49be14ffe278068309ac06051c tests/kwalletd/CMakeLists.txt 1e7c4b77ba478147fae964f61c28a736e32b9ea9 Diff: https://git.reviewboard.kde.org/r/129613/diff/ Testing --- Thanks, Andr

Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit f4e1653eefe9e81adbb7ec7f8eda51e02cd58f7b by Andreas Sturmlechner to branch master. Repository: kwallet Description --- Dropping implicit boost usage. Also, rename HAVE_QGPGME to HAVE_GPGMEPP

Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit f4e1653eefe9e81adbb7ec7f8eda51e02cd58f7b by Andreas Sturmlechner to branch master. Repository: kwallet Description --- Dropping implicit boost usage. Also, rename HAVE_QGPGME to HAVE_GPGMEPP

Re: Review Request 129426: refactor gpg finding

> On Nov. 18, 2016, 8:05 p.m., Andreas Sturmlechner wrote: > > CMakeLists.txt, line 37 > > <https://git.reviewboard.kde.org/r/129426/diff/1/?file=485781#file485781line37> > > > > that looks to me as if it does the opposite as in $description; prefe

Re: Review Request 129426: refactor gpg finding

> On Nov. 18, 2016, 8:05 p.m., Andreas Sturmlechner wrote: > > CMakeLists.txt, line 37 > > <https://git.reviewboard.kde.org/r/129426/diff/1/?file=485781#file485781line37> > > > > that looks to me as if it does the opposite as in $description; prefe

Re: Review Request 129426: refactor gpg finding

org/r/129426/#comment67701> that looks to me as if it does the opposite as in $description; prefer the old one to the new one. - Andreas Sturmlechner On Nov. 18, 2016, 2 p.m., Harald Sitter wrote: > > --- > This is a

Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

tps://git.reviewboard.kde.org/r/129341/diff/ Testing --- Thanks, Andreas Sturmlechner

Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

board.kde.org/r/129341/#review100597 --- On Nov. 5, 2016, 12:05 p.m., Andreas Sturmlechner wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

0d9ffb8ed469536cee9d4055ac0bd001fff115a0 src/runtime/kwalletd/kwalletd.cpp ca7d4ffbdff4178878b3c705921ef2b1970e0dbd src/runtime/kwalletd/kwalletwizard.cpp cd52e54a668554fc0e14f4ad4cb29ba6f27fd330 Diff: https://git.reviewboard.kde.org/r/129341/diff/ Testing --- Thanks, Andreas Sturmlechner

Re: Review Request 129071: Use Gpgmepp from GpgME-1.7.0

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 211e150f1ccbc1ac2a6e74575535dd6858cdbeaf by Andreas Sturmlechner to branch master. Repository: kwallet Description --- If Gpgmepp is not found, try to use KF5Gpgmepp Diffs - src

Re: Review Request 129071: Use Gpgmepp from GpgME-1.7.0

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 211e150f1ccbc1ac2a6e74575535dd6858cdbeaf by Andreas Sturmlechner to branch master. Repository: kwallet Description --- If Gpgmepp is not found, try to use KF5Gpgmepp Diffs - src

Re: Review Request 129071: Use Gpgmepp from GpgME-1.7.0

generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129071/#review99853 --- On Sept. 29, 2016, 11:32 a.m., Andreas Sturmlechner wrote: > > --- > This is an automat

Re: Review Request 129071: Use Gpgmepp from GpgME-1.7.0

-------- On Sept. 29, 2016, 11:32 a.m., Andreas Sturmlechner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129071/ > ---

Review Request 129071: Use Gpgmepp from GpgME-1.7.0

c84c1db6003412b6a7ac2768f171cbab380b376c Diff: https://git.reviewboard.kde.org/r/129071/diff/ Testing --- Builds and links fine with either GpgME-1.7.0 or KF5Gpgmepp present. Thanks, Andreas Sturmlechner

Re: Review Request 129012: kwallet: Add missing boost header

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 0ae542bfa6e266ead736d6cca5f979dac75e24f2 by Andreas Sturmlechner to branch master. Repository: kwallet Description --- Fixes build error with GpgME-1.7.0 (which was ported away from boost

Re: Review Request 129012: kwallet: Add missing boost header

/diff/ Testing --- Thanks, Andreas Sturmlechner

Review Request 129012: Remove duplicate search for KF5DocTools

://git.reviewboard.kde.org/r/129012/diff/ Testing --- Thanks, Andreas Sturmlechner

Re: Review Request 128582: Remove unused KF5 dependencies

three dependencies still in use. - Andreas Sturmlechner On Aug. 3, 2016, 2:23 a.m., Alexander Potashev wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128576/#review98020 --- Works for me, thanks! - Andreas Sturmlechner On Aug. 2

Re: Review Request 127410: Fix crash in rename dialog (KF 5.20)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127410/#review93640 --- works for me, thanks! - Andreas Sturmlechner On March 17

  1   2   >