akrutzler accepted this revision.
REPOSITORY
R320 KIO Extras
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16674
To: dfaure, akrutzler, elvisangelaccio, apol
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh,
spoorun, navarromorales, firef, ngraham
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:aaa1edbb74c4: [mtp] Move MTP device handling from
kioslave to kiod-module (authored by akrutzler).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15277?vs=43074&
akrutzler added a comment.
Great! Is there anything else left to do @elvisangelaccio and @mlaurent
before I land this?
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15277
To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent
Cc: mlaurent, kde-
akrutzler retitled this revision from "[RFC] kio_mtp: Move MTP device handling
from kioslave to kiod-module" to "[mtp] Move MTP device handling from kioslave
to kiod-module".
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15277
To: akrutzler, elvisangelaccio, ltosc
akrutzler updated this revision to Diff 43074.
akrutzler marked 4 inline comments as done.
akrutzler added a comment.
- Rebase
- Reserve memory for lists/vectors in advance.
- Prepend "static" to all class-level functions
- Fix typos
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDAT
akrutzler added inline comments.
INLINE COMMENTS
> mlaurent wrote in mtpstorage.cpp:176
> QString() directly no ?
Of course, thanks! :)
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15277
To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent
Cc:
akrutzler updated this revision to Diff 42685.
akrutzler marked 5 inline comments as done.
akrutzler added a comment.
- Use QString() directly instead of QStringLiteral("")
- Use explicit specifier
- Call either finished or error in slave methods
REPOSITORY
R320 KIO Extras
CHANGES SINCE
akrutzler added inline comments.
INLINE COMMENTS
> dfaure wrote in mtpstorage.cpp:499
> DBus timeouts are actually configurable, if you need to block until the copy
> is done, btw.
In my previous approach I increased the timeout to 10 minutes. This worked fine
until I downloaded a file of abou
akrutzler updated this revision to Diff 42450.
akrutzler marked 13 inline comments as done.
akrutzler added a comment.
- Rebase
- Remove unrelated changes
- Remove Q_FUNC_INFO
- Remove private static methods from header file
- Use currentDateTimeUtc instead of currentDateTime
- Genera
akrutzler added a comment.
Thanks for the review. I will address your comments and hopefully have a
patch ready in the next days. :)
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15277
To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure
Cc: kde-framew
akrutzler added inline comments.
INLINE COMMENTS
> michaelh wrote in kcoredirlister.cpp:1233
> I'd like to ask for some help here.
> Debugging in KDevelop, trying to step through the code:
> it's not possible for me. Sometimes the debugger even crashed.
>
> - I checked for debugging symbols with
akrutzler added inline comments.
INLINE COMMENTS
> michaelh wrote in kcoredirlister.cpp:1233
> I'm working with kio right now. Is better to just comment it out for the time
> being?
Yes, i would just comment this out :) Once you are done, undo the comment.
REPOSITORY
R241 KIO
REVISION DETAI
akrutzler added inline comments.
INLINE COMMENTS
> kcoredirlister.cpp:1233
>
> -Q_ASSERT(!name.isEmpty());
> if (name.isEmpty()) {
Q_ASSERT is just executed in debug builds. It wont crash in release builds.
Checkout https://doc-snapshots.qt.io/qt5-dev/qtglobal.html#Q_ASSERT
R
13 matches
Mail list logo
