D12959: [Breeze Plasma Theme] Fix kleopatra icon to use color stylesheet

aheinecke accepted this revision. aheinecke added a comment. This revision is now accepted and ready to land. Works in Ubuntu 18.04 with default breeze theme: F5855745: kleo-plasma-tray.png Thanks! REPOSITORY R242 Plasma Framework (Library) BRANC

Re: Review Request 127275: Ki18n: Fallback to QLocale::system uiLanguages in language initalisation

marked as submitted. Review request for KDE Frameworks and Localization and Translation (l10n). Changes --- Submitted with commit 26750a15fba059d3a703131e9cd400893aa596a6 by Andre Heinecke to branch master. Repository: ki18n Description --- The intention for this patch is to fix

Re: Review Request 127275: Ki18n: Fallback to QLocale::system uiLanguages in language initalisation

dated) - src/klocalizedstring.cpp b24fe9b Diff: https://git.reviewboard.kde.org/r/127275/diff/ Testing --- Tested on a german Windows system and got a "de" localized application. Thanks, Andre Heinecke ___ Kde-frameworks-devel m

Re: Review Request 127275: Ki18n: Fallback to QLocale::system uiLanguages in language initalisation

To reply, visit: https://git.reviewboard.kde.org/r/127275/#review93158 --- On March 4, 2016, 2:53 p.m., Andre Heinecke wrote: > > --- > This is an automatical

Review Request 127275: Ki18n: Fallback to QLocale::system uiLanguages in language initalisation

ystem and got a "de" localized application. Thanks, Andre Heinecke ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127265: Fix windows build of Ki18n

marked as submitted. Review request for KDE Frameworks, Andreas Cord-Landwehr and Kåre Särs. Changes --- Submitted with commit b91904c55ef1aaeeb60f9e8153dc8a1f00d77fb0 by Andre Heinecke to branch master. Repository: ki18n Description --- In review Request 127048 (Restrict

Re: Review Request 127265: Fix windows build of Ki18n

tch. - Andre --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127265/#review93140 --- On March 3, 2016, 5:49 p.m., Andre

Re: Review Request 127265: Fix windows build of Ki18n

ux GCC and it still compiled. - Andre --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127265/#review93104 --- On March 3, 2016

Re: Review Request 127265: Fix windows build of Ki18n

move and logic change while keeping the __USE_GNU_GETTEXT guard. Diffs (updated) - src/kcatalog.cpp 083443d Diff: https://git.reviewboard.kde.org/r/127265/diff/ Testing --- Compiled with mingw and __USE_GNU_GETTEXT for Windows. Also compiled for G

Review Request 127265: Fix windows build of Ki18n

://git.reviewboard.kde.org/r/127265/diff/ Testing --- Compiled with mingw and __USE_GNU_GETTEXT for Windows. Also compiled for GNU/Linux. Thanks, Andre Heinecke ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.

Re: Review Request 127245: Fix Kdelibs4 config migration for Windows

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit acd2c096632a5ae54b9b2267a7159b0f658c4243 by Andre Heinecke to branch master. Repository: kcoreaddons Description --- The old config was by default in ~/AppData/Roaming/.kde so on Windows we

Re: Review Request 127245: Fix Kdelibs4 config migration for Windows

/util/kdelibs4migration.cpp f631efa Diff: https://git.reviewboard.kde.org/r/127245/diff/ Testing --- On Windows: Made changes to XMLGui rc file and both kleopatra config files with a KDE 4 Kleo. Checked that they were migrated and changes show up. Thanks, Andre Hei

Re: Review Request 127245: Fix Kdelibs4 config migration for Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127245/#review93055 ------- On March 1, 2016, 4:50 p.m., Andre Heinecke wrote: > >

Review Request 127245: Fix Kdelibs4 config migration for Windows

both kleopatra config files with a KDE 4 Kleo. Checked that they were migrated and changes show up. Thanks, Andre Heinecke ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KWidgetsAddons License (included breeze icons)

dgetsAddons LGPLv3 and did not have the COPYING files updated? I've tried contacting the Author of the Icons to ask directly about this but I have not received a reply. (Probably a wrong mail) Regards, Andre -- Andre Heinecke | ++49-541-335083-262 | http://www.intevation.de/ Intevation Gmb

Re: Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit f40cc922540c423f424b48ec047da015353071af by Andre Heinecke to branch master. Repository: kxmlgui Description --- While packaging Kleopatra's translations for Gpg4win I've noticed

Re: Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127136/#review92833 ------- On Feb. 23, 2016, 3:16 p.m., Andre Heinecke wrote: > >

Re: Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

> On Feb. 22, 2016, 9:55 a.m., Albert Astals Cid wrote: > > I'd prefer if you could fix this at the Qt level, why would > > nativeLanguageName ever return empty? > > Andre Heinecke wrote: > I've just checked. It's a Windows thing. qlocale

Re: Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

ded/files/2016/02/22/762062c5-ff18-47da-aeb0-93b16ca28883__languages_after.png Thanks, Andre Heinecke ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

hink this should be Ifdefed for Windows. - Andre --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127136/#review92630 --- On Feb. 22, 2016, 9:52 a.m., Andre Heinecke wrote: > > --

Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

ewboard.kde.org/media/uploaded/files/2016/02/22/a6a31417-1ad6-432e-bee9-65a367fac28d__languages_before.png Dialog after the patch https://git.reviewboard.kde.org/media/uploaded/files/2016/02/22/762062c5-ff18-47da-aeb0-93b16ca28883__languages_after.png Thanks,

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit cca106313c9ec77f5dc409bd1b104f4e93da3cf1 by Andre Heinecke to branch master. Repository: kxmlgui Description --- This is part of a three patch series that aims to allow a "leightweight&q

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

src/kshortcuteditwidget.cpp 670d031 src/kshortcutseditor.cpp 99dfb3d src/kshortcutseditoritem.cpp 461a90c src/kxmlguifactory.cpp 6848610 Diff: https://git.reviewboard.kde.org/r/126895/diff/ Testing --- Compiled with and without dependency. Tested Kleopatra against it. Not ye

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

functionality. And building a > library and including it is always a burden, so I would say it's much better > to make it optional. > > Andre Heinecke wrote: > Hi, > > Abstracting it out would also be quite invasive imho. And from my > experience abs

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

functionality. And building a > library and including it is always a burden, so I would say it's much better > to make it optional. > > Andre Heinecke wrote: > Hi, > > Abstracting it out would also be quite invasive imho. And from my > experience abs

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

functionality. And building a > library and including it is always a burden, so I would say it's much better > to make it optional. > > Andre Heinecke wrote: > Hi, > > Abstracting it out would also be quite invasive imho. And from my > experience abs

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

functionality. And building a > library and including it is always a burden, so I would say it's much better > to make it optional. > > Andre Heinecke wrote: > Hi, > > Abstracting it out would also be quite invasive imho. And from my > experience abs

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

functionality. And building a > library and including it is always a burden, so I would say it's much better > to make it optional. > > Andre Heinecke wrote: > Hi, > > Abstracting it out would also be quite invasive imho. And from my > experience abs

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

src/kshortcuteditwidget.cpp 670d031 src/kshortcutseditor.cpp 99dfb3d src/kshortcutseditoritem.cpp 461a90c src/kxmlguifactory.cpp 2767e69 Diff: https://git.reviewboard.kde.org/r/126895/diff/ Testing --- Compiled with and without dependency. Tested Kleopatra against it. Not ye

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

functionality. And building a > library and including it is always a burden, so I would say it's much better > to make it optional. > > Andre Heinecke wrote: > Hi, > > Abstracting it out would also be quite invasive imho. And from my > experience abs

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

ould imho be a more invasive change and harder to maintain then the ifdefs. > The thing to be faked is a system that has no global shortcuts and where > setting them somehow always fails. Maybe pretend to applications that it > doesn't fail, shouldn't really matter. Why would yo

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

functionality. And building a > library and including it is always a burden, so I would say it's much better > to make it optional. > > Andre Heinecke wrote: > Hi, > > Abstracting it out would also be quite invasive imho. And from my > experience abs

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

functionality. And building a > library and including it is always a burden, so I would say it's much better > to make it optional. > > Andre Heinecke wrote: > Hi, > > Abstracting it out would also be quite invasive imho. And from my > experience abs

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

src/kactioncollection.cpp 9c45725 > src/kkeysequencewidget.cpp b2e2b6a > src/kshortcuteditwidget.cpp 670d031 > src/kshortcutseditor.cpp 99dfb3d > src/kshortcutseditoritem.cpp 461a90c > src/kxmlguifactory.cpp 2767e69 > > Diff: https://git.reviewboard.kde.org/r/126895/diff/ > > > Testing > --- > > Compiled with and without dependency. Tested Kleopatra against it. > Not yet tested on Windows, will do so in the next days. > > > Thanks, > > Andre Heinecke > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

b2e2b6a src/kshortcuteditwidget.cpp 670d031 src/kshortcutseditor.cpp 99dfb3d src/kshortcutseditoritem.cpp 461a90c src/kxmlguifactory.cpp 2767e69 Diff: https://git.reviewboard.kde.org/r/126895/diff/ Testing --- Compiled with and without dependency. Tested Kleopatra against it. Not ye

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

functionality. And building a > library and including it is always a burden, so I would say it's much better > to make it optional. > > Andre Heinecke wrote: > Hi, > > Abstracting it out would also be quite invasive imho. And from my > experience abs

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

Hi, On Tuesday 26 January 2016 20:47:34 Boudewijn Rempt wrote: > On Tue, 26 Jan 2016, Andre Heinecke wrote: > > On Tuesday 26 January 2016 19:50:13 Boudewijn Rempt wrote: > >> Reminds me a bit of https://git.reviewboard.kde.org/r/125530/ :-) > In the end, I decided to fork, i

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

e DBus / KService dependency. Let's see if my patches fare better. ConfigWidgets and IconThemes i find ok. :-) Regards, Andre P.S. I have not figured out how to create reviewrequests that depend on a revision under review so you have to look at the phabricator link for the other (similar) patch

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126895/#review91623 --- On Jan. 26, 2016, 6:25 p.m., Andre Heinecke wrote: > > --

Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

kxmlguifactory.cpp 2767e69 Diff: https://git.reviewboard.kde.org/r/126895/diff/ Testing --- Compiled with and without dependency. Tested Kleopatra against it. Not yet tested on Windows, will do so in the next days. Thanks, Andre Heinecke _

Re: [Kde-pim] [kf5-]gpgmepp

Hi, On Tuesday 24 November 2015 10:27:08 René J. V. Bertin wrote: > Andre Heinecke wrote: > > We won't get there before 15.12 though, probably start of 2016. > > Fine with me, but pray tell, are we going to see each and every point > release from 15.08.04 onwards until

Re: [kf5-]gpgmepp

d after that take out gpgme++ from the KDE releases / retire the repo. We won't get there before 15.12 though, probably start of 2016. Regards, Andre -- Andre Heinecke | ++49-541-335083-262 | http://www.intevation.de/ Intevation GmbH, Neuer Graben 17, 49074 Osnabrück | AG Osnabrück, H

Re: From kdelibs4 to KDE frameworks... how to make KDE more cross platform...

Hi, Am Samstag, 11. Februar 2012, 20:00:01 schrieb Alexander Neundorf: > Hi, > While there are Windows and also OSX builds of KDE4, they are not really > successful. > I mean, it's not like everybody is running amarok today under Windows, or > kate, or kdevelop, or digikam, kmail, etc. > Some appli