D28739: activities: Close the database connection to prevent file descriptor leak

akandaurov added a comment. Yes, I don't have an account, so I'll need someone to land it, thanks. REVISION DETAIL https://phabricator.kde.org/D28739 To: akandaurov, ivan, meven Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbam

D28739: activities: Close the database connection to prevent file descriptor leak

akandaurov retitled this revision from "Close the database connection to prevent file descriptor leak" to "activities: Close the database connection to prevent file descriptor leak". REVISION DETAIL https://phabricator.kde.org/D28739 To: akandaurov, ivan, meven Cc: meven, kde-frameworks-devel

D28739: Close the database connection to prevent file descriptor leak

akandaurov marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D28739 To: akandaurov, ivan, meven Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, spo

D28739: Close the database connection to prevent file descriptor leak

akandaurov updated this revision to Diff 79827. akandaurov added a comment. Added indentation. The block is suggested by the Qt Documentation . Without it, a warning will be thrown: QSqlDatabasePrivate::removeDatabase: connection

D28739: Close the database connection to prevent file descriptor leak

akandaurov added a reviewer: ivan. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28739 To: akandaurov, ivan Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D28739: Close the database connection to prevent file descriptor leak

akandaurov created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. akandaurov requested review of this revision. REVISION SUMMARY The connection to the database doesn't get closed, which leads to a leakage of file descriptors