D27357: Fix infinite recursion in xscreensaver plugin

alnikiforov added a comment. Could you please merge this change? Or is something stopping from merging it? REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D27357 To: alnikiforov, davidedmundson, broulik, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2

D27357: Fix infinite recursion in xscreensaver plugin

alnikiforov added a comment. In D27357#610605 , @broulik wrote: > Neither the XSync nor the windows backend explicitly call `resumingFromIdle` in `simulateUserActivity`, so I think this should be fine. > However, I don't know if that won't ind

D27357: Fix infinite recursion in xscreensaver plugin

alnikiforov created this revision. alnikiforov added reviewers: davidedmundson, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alnikiforov requested review of this revision. REVISION SUMMARY Follow up for D27279

D27279: Port away from QWidget

alnikiforov added a comment. I think I found source of infinite recursion. First call is on https://phabricator.kde.org/source/powerdevil/browse/master/daemon/powerdevilcore.cpp$821 Second call is on https://phabricator.kde.org/source/kidletime/browse/master/src/plugins/xscreensaver/xs

D27279: Port away from QWidget

alnikiforov added a comment. I've managed to reproduce it and take a backtrace. It's an infinite recursion. Eventually stack's end is reached, although it takes some time to do it. Here's a piece of backtrace I got: #460 0x764dcbec in KIdleTimePrivate::_k_resumingFromIdle (thi

D27279: Port away from QWidget

alnikiforov added a comment. I've tested this patch in it's current form, and powerdevil no longer crashes for me on launch too. How can I reproduce crash in resume on idle? Can it be done in virtual machine? REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D27279

D17392: Fix checkDesktopFile function

i.Dark_Templar abandoned this revision. i.Dark_Templar added a comment. Abandoning this change in that case. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17392 To: i.Dark_Templar, davidedmundson, #frameworks Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham

D17392: Fix checkDesktopFile function

i.Dark_Templar added a commit: R241:16edef0dca46: Remove unused variable. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17392 To: i.Dark_Templar, davidedmundson, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17392: Fix checkDesktopFile function

i.Dark_Templar created this revision. i.Dark_Templar added a reviewer: davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. i.Dark_Templar requested review of this revision. REVISION SUMMARY Variable isLocal is no longer initialized anywhere. Ret