KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 185 - Still Unstable!

2020-06-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/185/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 14 Jun 2020 23:35:20 + Build duration: 2 min 59 sec and counting BUILD ARTIFACTS abi-com

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.14 - Build # 20 - Still Unstable!

2020-06-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.14/20/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 14 Jun 2020 23:35:20 + Build duration: 2 min 1 sec and counting BUILD ARTIFACTS abi-compa

D29258: Don't use notifybysnore.h on MSYS2

2020-06-14 Thread Łukasz Wojniłowicz
wojnilowicz closed this revision. wojnilowicz marked an inline comment as done. wojnilowicz added a comment. In D29258#675261 , @vonreth wrote: > It probably won't hurt Thank you. I pushed it to gitlab. REPOSITORY R289 KNotifications R

D29258: Don't use notifybysnore.h on MSYS2

2020-06-14 Thread Hannah von Reth
vonreth accepted this revision. vonreth added a comment. This revision is now accepted and ready to land. It probably won't hurt REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29258 To: wojnilowicz, broulik, brute4s99, vonreth Cc: vonreth, kd

D29258: Don't use notifybysnore.h on MSYS2

2020-06-14 Thread Łukasz Wojniłowicz
wojnilowicz marked an inline comment as done. wojnilowicz added inline comments. INLINE COMMENTS > brute4s99 wrote in CMakeLists.txt:75 > please maintain the REQUIRED call for normal Windows builds. > You can use the OS specific build variables.. Is it ready to land now? REPOSITORY R289 KNot

D29258: Don't use notifybysnore.h on MSYS2

2020-06-14 Thread Łukasz Wojniłowicz
wojnilowicz updated this revision to Diff 83272. wojnilowicz added a comment. Qt5Network added as required REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29258?vs=81529&id=83272 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29258

Re: New Framework Review: KDAV

2020-06-14 Thread Albert Astals Cid
El diumenge, 14 de juny de 2020, a les 10:17:01 CEST, Ben Cooksley va escriure: > On Sun, Jun 14, 2020 at 8:03 PM Volker Krause wrote: > > > > With both 20.04.2 and 5.71.0 out I think it's now time to do this move. > > > > What extra steps do we need to take now that the framework/application > >

Re: New Framework Review: KDAV

2020-06-14 Thread Ben Cooksley
On Sun, Jun 14, 2020 at 8:03 PM Volker Krause wrote: > > With both 20.04.2 and 5.71.0 out I think it's now time to do this move. > > What extra steps do we need to take now that the framework/application > distinction exists in Gitlab as well? I guess this is the first case of a > post-migration m

Re: New Framework Review: KDAV

2020-06-14 Thread Volker Krause
With both 20.04.2 and 5.71.0 out I think it's now time to do this move. What extra steps do we need to take now that the framework/application distinction exists in Gitlab as well? I guess this is the first case of a post-migration move. Also, what is the impact on the 20.04.3 release when we m