Re: New Framework Review: KDAV

The remaining issues that didn't change ABI anymore (movable value types, hide private methods/slots inside the private classes, etc) have long since been addressed. I think there's two possible time slots to actually execute the move to frameworks now: * ASAP, for the June release. * For the J

D29397: KPreviewJob : Support for DeviceRatioPixel

meven updated this revision to Diff 83139. meven marked 3 inline comments as done. meven added a comment. Typo, const, doxygen fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29397?vs=82709&id=83139 BRANCH arcpatch-D29397 REVISION DETAIL https://phabri

D29810: Don't use the setenv function after fork

bruns added inline comments. INLINE COMMENTS > kcrash.cpp:689 > { > +static char autorestarted_envvar[] = "KCRASH_AUTO_RESTARTED"; > +char** environ_end; move this to the lambda scope, you can also make the var name shorter then. > kcrash.cpp:698 > +} > +auto end = std::copy(en

D29810: Don't use the setenv function after fork

jpalecek marked an inline comment as done. jpalecek added inline comments. INLINE COMMENTS > apol wrote in kcrash.cpp:823 > Use {} instead of ; for readability. Done that. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29810 To: jpalecek, #frameworks Cc: apol, anthony

D29811: t/simplify-sending-data-through-socket

jpalecek abandoned this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29811 To: jpalecek, #frameworks Cc: anthonyfieroni, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29813: t/minimize-allocations-in-crash-handler

jpalecek abandoned this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29813 To: jpalecek Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29812: t/handle-errors-from-socket

jpalecek abandoned this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29812 To: jpalecek Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29814: Fix segfault on no restart args

jpalecek updated this revision to Diff 83138. jpalecek edited the summary of this revision. jpalecek added a dependency: D29810: Don't use the setenv function after fork. jpalecek added a comment. Edited the commit msg, also prune the dependencies I want to abandon REPOSITORY R285 KCrash CH

D29810: Don't use the setenv function after fork

jpalecek added a dependent revision: D29814: Fix segfault on no restart args. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29810 To: jpalecek, #frameworks Cc: apol, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29810: Don't use the setenv function after fork

jpalecek updated this revision to Diff 83137. jpalecek retitled this revision from "Don't use setenv after fork" to "Don't use the setenv function after fork". jpalecek edited the summary of this revision. jpalecek added a comment. Change the code a bit for readability REPOSITORY R285 KCras

D29809: Don't invoke qstring localized stuff in critical section

jpalecek updated this revision to Diff 83136. jpalecek retitled this revision from "Don't invoke QString localized stuff in critical section" to "Don't invoke qstring localized stuff in critical section". jpalecek edited the summary of this revision. jpalecek added a comment. (edited the commi

D29397: KPreviewJob : Support for DeviceRatioPixel

elvisangelaccio added inline comments. INLINE COMMENTS > previewjob.cpp:587 > +if > (thumb.textKeys().contains(QStringLiteral("Thumb::DevicePixelRatio"))) { > +qreal dpr = > thumb.text(QStringLiteral("Thumb::DevicePixelRatio")).toDouble(); > +thumb.setDevicePixelRatio(dpr);

D27731: Improve KDirModel to avoid showing '+' if there are no subdirs

meven added a comment. I believe this causes https://bugs.kde.org/show_bug.cgi?id=419434 It causes similar issue with dolphin and KFileWidget This is not a correct behavior. It prevents file treeview to show files within folders with no subfolders. The bug has a proposed patch : ht

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

aacid added a comment. Do you think we should mention something like // TODO Remove once we can depend on a Qt version that has https://codereview.qt-project.org/c/qt/qtbase/+/301588 Or maybe i'm being too optimistic in getting that landed ^_^ 😄 REPOSITORY R263 KXmlGui REVISION D

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

ervin added a comment. LGTM now, I'll let the other reviewers weight in though. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter, dfaure Cc: dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

Hi, I did a bit research, I think this might be https://bugreports.qt.io/browse/QTBUG-84363 => This makes actually Qt 5.14 completely unusable for KTextEditor/Kate/KWrite/. I run into this kind of crashs during normal editing, too :( I still have no 5.15 build with the fix here, will ne

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

poboiko added a comment. In D29826#673585 , @aacid wrote: > What about discover for example? Good point... REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D29826 To: poboiko, aacid, mart, broulik Cc: mart, kde-fr

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

ahmadsamir added a comment. This wasn't landed on master, but rather phabricator is confused by me pushing to work/ branch on gitlab :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29782 To: ahmadsamir, #frameworks, dfaure, sitter Cc: kde-frameworks-devel, LeGast00n,

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

poboiko updated this revision to Diff 83129. poboiko added a comment. Don't override if fallbackThemeName is already set REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29826?vs=83109&id=83129 BRANCH icon-load (branched from master) REVISION DETAIL htt

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:f2984ff28e72: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs (authored by ahmadsamir). CHANGED PRIOR

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.12 - Build # 94 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.12/94/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 23 May 2020 12:40:49 + Build duration: 2 min 47 sec and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.14 - Build # 17 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.14/17/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 23 May 2020 12:40:49 + Build duration: 2 min 16 sec and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » krunner » kf5-qt5 FreeBSDQt5.14 - Build # 18 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20FreeBSDQt5.14/18/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 23 May 2020 12:40:49 + Build duration: 1 min 14 sec and counting JUnit Tests Name: projec

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

meven added a comment. In D28590#673609 , @dfaure wrote: > @meven you're confusing me with my clone @ervin. lol I thought this was still you when I read the comment. Thanks @ervin REPOSITORY R245 Solid REVISION DETAIL https://pha

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

dfaure added a comment. @meven you're confusing me with my clone @ervin. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter, dfaure Cc: dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

meven added a comment. This makes the patch way less intrusive in the process, thanks @dfaure REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter, dfaure Cc: dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michae

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

meven updated this revision to Diff 83128. meven added a comment. Remove unneeded change REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28590?vs=83127&id=83128 BRANCH arcpatch-D28590_1 REVISION DETAIL https://phabricator.kde.org/D28590 AFFECTED FILES

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

meven updated this revision to Diff 83127. meven marked 5 inline comments as done. meven added a comment. Use a default implementation for Device::displayName() REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28590?vs=83112&id=83127 BRANCH arcpatch-D28590_1

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

ervin added inline comments. INLINE COMMENTS > device.h:99 > + */ > +virtual QString displayName() const = 0; > + Why not have a default implementation which returns descriptions()? This would make for a less intrusive patch (I think it's in part what @bruns suggested earlier). REPOS

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fstabdevice.cpp:73 > +if (m_displayName.isEmpty()) { > +QStringList currentMountPoints = > FstabHandling::currentMountPoints(m_device); > +

Re: KEmoticons, emoticons kcm

On 5/22/20 6:49 PM, Aleix Pol wrote: Hi, I was looking through some Plasma code and I saw that we have some fairly old emoticons KCM using KF5Emoticons. Now while I know why this exists, it feels like it's more of a thing of the past from when people wrote :) instead of 🙂. While keeping it aroun

D22488: invoke QIcon::setFallbackThemeName a bit later

aacid added a comment. In D22488#673575 , @poboiko wrote: > UPD: seems like it doesn't. I've added couple qDebug lines, to `QIcon::fromTheme()` method and near `QIcon::setFallbackThemeName()` with your patch, and then ran okular and dolphin.

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

aacid added a comment. In D29826#673572 , @poboiko wrote: > Thanks for looking into it! :) > > In D29826#673543 , @aacid wrote: > > > I don't think moving this code from KIconThemes to kmainwindow

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

meven added subscribers: broulik, dfaure. meven added a comment. Maybe @dfaure or @broulik would be nice to help the review effort. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter Cc: dfaure, broulik, ervin, kde-frameworks-de

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 26 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/26/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 23 May 2020 09:50:09 + Build duration: 20 min and counting JUnit Tests Name: projectroot Fa

KDE CI: Frameworks » solid » kf5-qt5 WindowsMSVCQt5.14 - Build # 41 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.14/41/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 23 May 2020 09:50:09 + Build duration: 13 min and counting JUnit Tests Name: projec

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.12 - Build # 132 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.12/132/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 23 May 2020 09:50:09 + Build duration: 7 min 42 sec and counting BUILD ARTIFACTS abi-compatibilit

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.14 - Build # 25 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.14/25/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 23 May 2020 09:50:09 + Build duration: 3 min 50 sec and counting BUILD ARTIFACTS abi-compatibility

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 25 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/25/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 23 May 2020 09:09:29 + Build duration: 15 min and counting CONSOLE OUTPUT [...truncated 602

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.14 - Build # 24 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.14/24/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 23 May 2020 09:07:43 + Build duration: 3 min 50 sec and counting CONSOLE OUTPUT [...truncated 717

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.12 - Build # 131 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.12/131/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 23 May 2020 09:07:43 + Build duration: 2 min 11 sec and counting CONSOLE OUTPUT [...truncated 541

KDE CI: Frameworks » solid » kf5-qt5 WindowsMSVCQt5.14 - Build # 40 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.14/40/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 23 May 2020 09:07:43 + Build duration: 1 min 35 sec and counting CONSOLE OUTPUT [...

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 24 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/24/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 23 May 2020 08:45:53 + Build duration: 23 min and counting CONSOLE OUTPUT [...truncated 633

D22488: invoke QIcon::setFallbackThemeName a bit later

poboiko added a comment. In D22488#673544 , @aacid wrote: > Wouldn't it make more sense to fix in Qt? It would make more sense. I thought as a temporary solution it would be nice to fix it in KF as well, since KF releases go out more of

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

poboiko added a comment. Thanks for looking into it! :) In D29826#673543 , @aacid wrote: > I don't think moving this code from KIconThemes to kmainwindow makes sense, what about all the apps that use KIconThemes but no KMainWindow? I

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.14 - Build # 23 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.14/23/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 23 May 2020 08:45:53 + Build duration: 3 min 1 sec and counting CONSOLE OUTPUT [...truncated 720 l

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.12 - Build # 130 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.12/130/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 23 May 2020 08:45:53 + Build duration: 1 min 32 sec and counting CONSOLE OUTPUT [...truncated 524

KDE CI: Frameworks » solid » kf5-qt5 WindowsMSVCQt5.14 - Build # 39 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.14/39/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 23 May 2020 08:45:53 + Build duration: 1 min 52 sec and counting CONSOLE OUTPUT [...

D29281: Deprecate defunct functions

alex closed this revision. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29281 To: alex, #plasma, broulik, davidedmundson, vkrause, meven Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: KEmoticons, emoticons kcm

On Saturday, 23 May 2020 02:49:57 CEST Aleix Pol wrote: > I was looking through some Plasma code and I saw that we have some > fairly old emoticons KCM using KF5Emoticons. > > Now while I know why this exists, it feels like it's more of a thing > of the past from when people wrote :) instead of 🙂.

D29358: Implement lock-screen visibility control on Android

vkrause closed this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29358 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns