D27152: Introduce FilesystemEntry class

hallas marked an inline comment as done. hallas added a comment. Hi @bruns - did you have a chance to go through this patch again? Am I missing anything to move on with this? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27152 To: hallas, #frameworks, bruns, meven

D28766: Add auth-sim-locked and auth-sim-missing

This revision was automatically updated to reflect the committed changes. Closed by commit R266:169b438c9fc1: Add auth-sim-locked and auth-sim-missing (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28766?vs=79895&id=79896 REVISION D

D28766: Add auth-sim-locked and auth-sim-missing

cblack accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH sim-card (branched from master) REVISION DETAIL https://phabricator.kde.org/D28766 To: ndavis, #vdg, cblack Cc: kde-frameworks-devel, salvahg, Orage, LeGast00n, cblack, hann

D28766: Add auth-sim-locked and auth-sim-missing

ndavis edited the test plan for this revision. ndavis added a project: Plasma: Mobile. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28766 To: ndavis, #vdg Cc: kde-frameworks-devel, salvahg, Orage, LeGast00n, cblack, hannahk, frmdstryr, fbampaloukas, emrek, mkrae

D28766: Add auth-sim-locked and auth-sim-missing

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY For Plasma Mobile REPOSITORY R266 Breeze Icons BRANCH sim-card (branched from master)

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

cblack added inline comments. INLINE COMMENTS > kcmoduleinfo.h:130 > * @return a QExplicitlySharedDataPointer to KService created from the > modules .desktop file > + * WARNING: this will be null if this KCModuleInfo was created from a > KPluginInfo coming from KPluginMetaData > +

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

dfaure created this revision. dfaure added reviewers: pino, broulik, mart, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY KPluginInfo evolved into an abstraction over old-style plugin

Re: Update on Status of Gitlab Migration

On Sun, Apr 12, 2020 at 11:04 AM Johan Ouwerkerk wrote: > > On Sun, Apr 12, 2020 at 12:49 AM Johan Ouwerkerk > wrote: > > > > Yes the only reason why a cleanup script might be needed is if the > > logical path used to express the repo in dependency information > > changes at the same time. E.g.

Re: Update on Status of Gitlab Migration

On Sun, Apr 12, 2020 at 12:49 AM Johan Ouwerkerk wrote: > > Yes the only reason why a cleanup script might be needed is if the > logical path used to express the repo in dependency information > changes at the same time. E.g. suppose a `frameworks/kf5foo` gets > remapped to `frameworks/kf5/foo` or

Re: Update on Status of Gitlab Migration

On Sat, Apr 11, 2020 at 11:03 PM Michael Pyne wrote: > > On Sat, Apr 11, 2020 at 09:25:11PM +0200, Johan Ouwerkerk wrote: > > > > > A cleanup script could be handy. I think kdesrc-build will > > automatically pick up new repo paths from metadata and that should > > work transparently, but the old

D28760: KSettings::Dialog: avoid duplicate entries due cascading $XDG_DATA_DIRS

dfaure updated this revision to Diff 79892. dfaure edited the summary of this revision. dfaure removed a subscriber: pino. dfaure added a comment. Use QMap, thanks Pino for the idea. REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28760?vs=79877&id=79892 B

D28372: Remove rounded borders to plasmoidHeading

This revision was automatically updated to reflect the committed changes. Closed by commit R242:0f9abc2d403d: Remove rounded borders to plasmoidHeading (authored by niccolove). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28372?vs=79740&id

D28734: Port to Aether Bootstrap 4

cblack closed this revision. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28734 To: cblack, #vdg, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna

Re: Notice of upcoming changes to the behaviour of the anongit network

On Sat, Apr 11, 2020 at 10:14:38PM +1200, Ben Cooksley wrote: > Hi all, > > As part of the preparations for the move to Gitlab, and the rewrite of > our anongit tooling, one of the things we have looked into is how the > anongit network in general operates. > > As part of this, it has been observ

D27632: Implement UString operator= to make gcc happy

porten accepted this revision. porten added a comment. This revision is now accepted and ready to land. I now see that the member is kept as a RefPtr. Unlike the previously used raw pointer I now understand why the the assignment operator can be implemented that simple. For completness:

Re: Update on Status of Gitlab Migration

On Sat, Apr 11, 2020 at 09:25:11PM +0200, Johan Ouwerkerk wrote: > On Sat, Apr 11, 2020 at 8:39 PM Ben Cooksley wrote: > > > > Yes, the hostname git.kde.org will be fully retired as part of this > > transition. > > > > From my understanding kdesrc-build will automatically pick this up > > once we

Re: Update on Status of Gitlab Migration

El sáb., 11 de abr. de 2020 a la(s) 16:26, Johan Ouwerkerk (jm.ouwerk...@gmail.com) escribió: > > On Sat, Apr 11, 2020 at 8:39 PM Ben Cooksley wrote: > > > > Yes, the hostname git.kde.org will be fully retired as part of this > > transition. > > > > From my understanding kdesrc-build will automat

Re: Update on Status of Gitlab Migration

On Sat, Apr 11, 2020 at 9:01 PM Nicolás Alvarez wrote: > > How would it work during the "grace period"? Keeping an outdated read-only > mirror on the old URL? I have done some research into redirecting or > remapping from the old URL to the new one so we can keep it working for a > longer perio

Re: Update on Status of Gitlab Migration

On Sat, Apr 11, 2020 at 8:39 PM Ben Cooksley wrote: > > Yes, the hostname git.kde.org will be fully retired as part of this > transition. > > From my understanding kdesrc-build will automatically pick this up > once we update sysadmin/repo-metadata to show the new repository > paths. > This is so

Re: Update on Status of Gitlab Migration

El 11 abr. 2020, a la(s) 08:31, Johan Ouwerkerk escribió: > > On Sat, Apr 11, 2020 at 11:36 AM Ben Cooksley wrote: >> Should anyone have any questions on the above, please let us know. > > Does the migration also mean that `git.kde.org` push URL will be > retired and would need to be remapped

Re: Update on Status of Gitlab Migration

On Sat, Apr 11, 2020 at 11:31 PM Johan Ouwerkerk wrote: > > On Sat, Apr 11, 2020 at 11:36 AM Ben Cooksley wrote: > > > > Should anyone have any questions on the above, please let us know. > > > > Does the migration also mean that `git.kde.org` push URL will be > retired and would need to be remap

D28760: KSettings::Dialog: avoid duplicate entries due cascading $XDG_DATA_DIRS

pino added a comment. Why not instead use a `QMap` to collect the files? This way you wouldn't need the double QStandardPaths lookup. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28760 To: dfaure, apol, broulik, davidedmundson, kossebau Cc: pino, kde-frameworks-

D28760: KSettings::Dialog: avoid duplicate entries due cascading $XDG_DATA_DIRS

dfaure created this revision. dfaure added reviewers: apol, broulik, davidedmundson, kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY I had every toplevel entry doubled in kontact's configura

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven planned changes to this revision. meven added a comment. The modification date is not what to expect currently, working on it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24773 To: meven, #frameworks, ngraham, elvisangelaccio, dfaure Cc: kde-frameworks-devel, L

D28739: activities: Close the database connection to prevent file descriptor leak

meven added a comment. Well done @akandaurov Keep the patch coming ;-) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28739 To: akandaurov, ivan, meven Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack,

D28739: activities: Close the database connection to prevent file descriptor leak

This revision was automatically updated to reflect the committed changes. Closed by commit R320:8c3c27daa03b: activities: Close the database connection to prevent file descriptor leak (authored by akandaurov, committed by meven). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28739?vs=798

D24773: kio_trash: Add size, modification, access and create date for trash:/

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D24773_1 REVISION DETAIL https://phabricator.kde.org/D24773 To: meven, #frameworks, ngraham, elvisangelaccio, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, n

D28743: Port kruntest to ApplicationLauncherJob

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28743 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28675: [KMimeTypeChooser] Add the ability to filter the treeview with a QSFPM

This revision was automatically updated to reflect the committed changes. Closed by commit R236:75298895a5e3: [KMimeTypeChooser] Add the ability to filter the treeview with a QSFPM (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D28758: [KFontChooser] Make the code slightly more readable

This revision was automatically updated to reflect the committed changes. Closed by commit R236:9e97265723f2: [KFontChooser] Make the code slightly more readable (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28758?vs=79863&id=

D28758: [KFontChooser] Make the code slightly more readable

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks ;) REPOSITORY R236 KWidgetsAddons BRANCH l-kfontchooser-5 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28758 To: ahmadsamir, #frameworks, dfaure Cc: kd

D28675: [KMimeTypeChooser] Add the ability to filter the treeview with a QSFPM

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH l-kmimechooser (branched from master) REVISION DETAIL https://phabricator.kde.org/D28675 To: ahmadsamir, #frameworks, cfeck, dfaure Cc: kde-frameworks-devel, LeGast00n, cb

D28739: activities: Close the database connection to prevent file descriptor leak

akandaurov added a comment. Yes, I don't have an account, so I'll need someone to land it, thanks. REVISION DETAIL https://phabricator.kde.org/D28739 To: akandaurov, ivan, meven Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbam

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

kossebau added a comment. (nullptr used as arguments always make me consider finally working on a patch to add to normal kdevelop the feature "Show argument names at call site" like demoed here among other things: https://kate-editor.org/wp-content/uploads/2018/08/inline-note-anim.gif so fa

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

dfaure closed this revision. REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik, davidedmundson, ervin Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

ervin added a comment. Agreed, nullptr is going to be the boolean flag of our time, before it was 0 though, so still an improvement. ;-) More seriously, here I'm not sure how to avoid it, at least it's a case of "if you feel like passing nullptr here you might be doing something wrong".

D28755: Breeze Icons cannot be built from read-only source location

marten updated this revision to Diff 79867. marten added a comment. Yes, that would mean fewer changes to the validate_svg.sh script. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28755?vs=79845&id=79867 REVISION DETAIL https://phabricator.kde.org/

D28675: [KMimeTypeChooser] Add the ability to filter the treeview with a QSFPM

ahmadsamir updated this revision to Diff 79866. ahmadsamir added a comment. - Bring the comment column back, more filter-ability - Use QFontMetrics fm(fontMetrics()), more efficient as it gets copied REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D28739: activities: Close the database connection to prevent file descriptor leak

meven added a comment. Do you want me to land the commit ? I believe you don't have a KDE Developer account. REVISION DETAIL https://phabricator.kde.org/D28739 To: akandaurov, ivan, meven Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n,

KDE CI: Frameworks » ktextwidgets » kf5-qt5 WindowsMSVCQt5.14 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20WindowsMSVCQt5.14/19/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 11 Apr 2020 14:57:22 + Build duration: 5 min 1 sec and counting JUnit Tests N

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

kossebau added a comment. Not into details, so if there is no sane default, forcing developers to pass something sane here make sense Second thought I also had was avoiding code which uses `nullptr` as arguments, which harms humans reading code a bit as in, "nullptr of what?!!" (compare b

KDE CI: Frameworks » ktextwidgets » kf5-qt5 SUSEQt5.14 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20SUSEQt5.14/6/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 11 Apr 2020 14:57:22 + Build duration: 1 min 59 sec and counting BUILD ARTIFACTS abi-compati

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

ervin accepted this revision. REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik, davidedmundson, ervin Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » ktextwidgets » kf5-qt5 SUSEQt5.12 - Build # 79 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20SUSEQt5.12/79/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Apr 2020 14:57:22 + Build duration: 1 min 58 sec and counting BUILD ARTIFACTS abi-compat

KDE CI: Frameworks » ktextwidgets » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20FreeBSDQt5.14/7/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 14:57:22 + Build duration: 1 min 31 sec and counting JUnit Tests Name: pro

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

ervin added a comment. In D28742#646050 , @dfaure wrote: > In D28742#646009 , @kossebau wrote: > > > And perhaps could be defaulted to nullptr, for use-cases which do not have a window at hand and a

D28756: [findreplace] Handle searching for WholeWordsOnly in Regex mode

This revision was automatically updated to reflect the committed changes. Closed by commit R310:fcaeccbcd633: [findreplace] Handle searching for WholeWordsOnly in Regex mode (authored by ahmadsamir). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28756?vs

D28758: [KFontChooser] Make the code slightly more readable

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R236 KWidgetsAddons BRANCH l-kfontchooser-5 (branched from master) REVISION DETAIL https

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

This revision was automatically updated to reflect the committed changes. ahmadsamir marked an inline comment as done. Closed by commit R236:e9c92b7e3620: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINC

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kfontchooser.cpp:393 > would `true` be more readable? > > (same for the previous line, actually) Indeed; however onlyFixedCheckbox->setChecked(usingFixed) doesn't need to be in that

D28756: [findreplace] Handle searching for WholeWordsOnly in Regex mode

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets BRANCH l-wholewords (branched from master) REVISION DETAIL https://phabricator.kde.org/D28756 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, micha

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

dfaure added a comment. In D28742#646009 , @kossebau wrote: > `window` parameter wants API dox mentioning, though. Oops, I thought I did that. Fixed. > And perhaps could be defaulted to nullptr, for use-cases which do not have a wind

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

ahmadsamir updated this revision to Diff 79861. ahmadsamir added a comment. A better location for onlyFixedCheckbox->setChecked() is next to its siblings REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28274?vs=79823&id=79861 BRANCH l-monospace-che

D28726: [KJS] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R314:da9d1e44ebf2: [KJS] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R314 KJs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28726?vs=79776&id=79860 REVISION DETAIL

D28756: [findreplace] Handle searching for WholeWordsOnly in Regex mode

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY The unit test passes again. TEST PLAN make && ctest REPOSITORY R310 KTextWidgets BRANCH l-wholewords (bran

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

dfaure updated this revision to Diff 79857. dfaure added a comment. Expand docs about the associated window REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28742?vs=79848&id=79857 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28742 AF

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

kossebau added a comment. `window` parameter wants API dox mentioning, though. And perhaps could be defaulted to nullptr, for use-cases which do not have a window at hand and are fine with any default? REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

ervin accepted this revision. ervin added a comment. Indeed, good point. REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik, davidedmundson, ervin Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngrah

D28753: Add KNotificationJobUiDelegate(KJobUiDelegate::Flags) constructor

dfaure closed this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D28753 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28753: Add KNotificationJobUiDelegate(KJobUiDelegate::Flags) constructor

broulik accepted this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D28753 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28726: [KJS] Port QRegExp to QRegularExpression

porten accepted this revision. REPOSITORY R314 KJs BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D28726 To: ahmadsamir, #frameworks, porten, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

dfaure updated this revision to Diff 79848. dfaure added a comment. Add QWidget *window parameter. Even better, no? Needed for dialog boxes to respect stacking order, centering to parent, focus going back to parent after closing... REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE

D28753: Add KNotificationJobUiDelegate(KJobUiDelegate::Flags) constructor

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D28753 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, b

D28755: Breeze Icons cannot be built from read-only source location

pino added a comment. Or maybe the other way round: - add an optional parameter to the script to specify the source directory, defaulting to "." - run the script in the build directory, passing the source directory as parameter REPOSITORY R266 Breeze Icons REVISION DETAIL https:/

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

ervin accepted this revision. REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik, davidedmundson, ervin Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28755: Breeze Icons cannot be built from read-only source location

marten created this revision. marten added a reviewer: Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. marten requested review of this revision. REVISION SUMMARY In the situation, for example, where a master source tree may be shared among a number o

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

dfaure accepted this revision. dfaure added inline comments. INLINE COMMENTS > kfontchooser.cpp:393 > q->setFont(QFontDatabase::systemFont(QFontDatabase::FixedFont), > usingFixed); > +onlyFixedCheckbox->setChecked(usingFixed); > } else { would `true` be more readable? (sa

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 10 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/10/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 11 Apr 2020 13:51:54 + Build duration: 2 min 51 sec and counting BUILD ARTIFACTS abi-compat

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 182 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/182/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Apr 2020 13:51:49 + Build duration: 3 min 9 sec and counting BUILD ARTIFACTS abi-compati

D28753: Add KNotificationJobUiDelegate(KJobUiDelegate::Flags) constructor

dfaure created this revision. dfaure added reviewers: broulik, davidedmundson, ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. TEST PLAN Builds REPOSITORY R289 KNotifications BRANCH master REVISION DETAI

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/9/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 11 Apr 2020 13:48:37 + Build duration: 3 min 16 sec and counting BUILD ARTIFACTS abi-compatib

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 181 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/181/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Apr 2020 13:48:37 + Build duration: 3 min 10 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/9/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 13:50:17 + Build duration: 1 min 29 sec and counting JUnit Tests Name: pro

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

dfaure updated this revision to Diff 79840. dfaure marked an inline comment as done. dfaure added a comment. explicit REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28742?vs=79820&id=79840 BRANCH master REVISION DETAIL https://phabricator.kde.org/

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/8/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 13:48:37 + Build duration: 1 min 38 sec and counting JUnit Tests Name: pro

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

dfaure marked an inline comment as done. dfaure added inline comments. INLINE COMMENTS > kossebau wrote in kdialogjobuidelegate.h:51 > Why no explicit? good point REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik, davidedmu

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

kossebau added inline comments. INLINE COMMENTS > kdialogjobuidelegate.h:51 > + */ > +KDialogJobUiDelegate(KJobUiDelegate::Flags flags); // KF6 TODO merge > with default constructor, using AutoHandlingDisabled as default value > + Why no explicit? REPOSITORY R288 KJobWidgets BRANCH

D28741: [KJobUiDelegate] Add AutoHandlingEnabled flag

dfaure closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D28741 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28743: Port kruntest to ApplicationLauncherJob

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28743 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, brun

D28741: [KJobUiDelegate] Add AutoHandlingEnabled flag

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D28741 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, brun

D28739: activities: Close the database connection to prevent file descriptor leak

akandaurov retitled this revision from "Close the database connection to prevent file descriptor leak" to "activities: Close the database connection to prevent file descriptor leak". REVISION DETAIL https://phabricator.kde.org/D28739 To: akandaurov, ivan, meven Cc: meven, kde-frameworks-devel

D28739: Close the database connection to prevent file descriptor leak

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Too bad we have so many lines to change. Could you maybe add some context to your commit comment like `activities: Close the database connection to prevent file descriptor leak` LGTM

D28726: [KJS] Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R314 KJs BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D28726 To: ahmadsamir, #frameworks, porten, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB

D28737: Add sim card device icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:95ebf0c1d3ea: Add sim card device icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28737?vs=79800&id=79839 REVISION DETAIL https:/

D28739: Close the database connection to prevent file descriptor leak

akandaurov marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D28739 To: akandaurov, ivan, meven Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, spo

D28745: Skipping catching of thumbnails on encrytped filesystems

marcingu added a dependency: D28746: Show previews on encrypted filesystems. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde,

D28746: Show previews on encrypted filesystems

marcingu added a dependent revision: D28745: Skipping catching of thumbnails on encrytped filesystems. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28746 To: marcingu Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28746: Show previews on encrypted filesystems

marcingu created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. marcingu requested review of this revision. REVISION SUMMARY Instead of skipping generating previews on encrypted filesystems, do create them but don't cache. BUG: 411919 REPO

D28745: Skipping catching of thumbnails on encrytped filesystems

marcingu created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. marcingu requested review of this revision. REVISION SUMMARY When generating thumbnails for directory, don't cache the previews for files stored on encrypted fi

D28739: Close the database connection to prevent file descriptor leak

akandaurov updated this revision to Diff 79827. akandaurov added a comment. Added indentation. The block is suggested by the Qt Documentation . Without it, a warning will be thrown: QSqlDatabasePrivate::removeDatabase: connection

D28406: Fix sonnet autodetect test failure

waqar added a comment. In D28406#644383 , @dfaure wrote: > @waqar ping? What do you think about my suggestion? If you agree, can you update the patch? Sorry I have been really busy at work, and overlooked the last email. I did plan to wo

D28406: Fix sonnet autodetect test failure

dfaure added a comment. I pushed it with my changes included. The test is fixed: https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/sonnet/job/kf5-qt5%20SUSEQt5.12/ REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28406 To: dfaure, waqar Cc: dfaur

KDE CI: Frameworks » sonnet » kf5-qt5 SUSEQt5.12 - Build # 90 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20SUSEQt5.12/90/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Apr 2020 11:53:06 + Build duration: 2 min 2 sec and counting BUILD ARTIFACTS abi-compatibility

KDE CI: Frameworks » sonnet » kf5-qt5 WindowsMSVCQt5.14 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20WindowsMSVCQt5.14/21/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 11 Apr 2020 11:53:06 + Build duration: 1 min 57 sec and counting JUnit Tests Name:

KDE CI: Frameworks » sonnet » kf5-qt5 SUSEQt5.14 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20SUSEQt5.14/5/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 11 Apr 2020 11:53:06 + Build duration: 2 min 1 sec and counting BUILD ARTIFACTS abi-compatibility-

KDE CI: Frameworks » sonnet » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20FreeBSDQt5.14/7/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 11:53:06 + Build duration: 57 sec and counting JUnit Tests Name: projectroot Fai

D28406: Fix sonnet autodetect test failure

dfaure commandeered this revision. dfaure edited reviewers, added: waqar; removed: dfaure. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28406 To: dfaure, waqar Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28406: Fix sonnet autodetect test failure

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R246:78450298149e: Fix sonnet autodetect test failure (authored by waqar, committed by dfaure). CHANGED PRIOR TO COMMIT

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

ahmadsamir updated this revision to Diff 79823. ahmadsamir added a comment. Handle the case where KFontChooser::FixedFontsOnly is set, the fixedOnlyCheckBox should be shown as "checked" from the get go. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

  1   2   >