D27355: POC: Make kstatusnotifieritem available without dbus

jjazeix added a comment. Can we push it as this to fix the Windows builds? It also breaks a few ones in https://binary-factory.kde.org/view/Windows%2064-bit/ REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D27355 To: vonreth, bcooksley, jjazeix, broulik Cc: kd

D27769: modemmanager-qt: Convert license headers to SPDX expressions

This revision was automatically updated to reflect the committed changes. Closed by commit R281:8ad494d957ca: modemmanager-qt: Convert license headers to SPDX expressions (authored by cordlandwehr). REPOSITORY R281 ModemManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27769?v

D27872: sftp: fix partial transfer resuming when copying to local

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Erroneous submit? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27872 To: sitter, ngraham, feverfew, bruns Cc: bruns, kde-frameworks-devel, kfm-devel,

D27873: sftp: do not show creation time when we do not know it

bruns added a comment. At least the openssh implementation apparently only supports atime/mtime: https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/sftp-common.c?rev=1.31&content-type=text/x-cvsweb-markup REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27

D27873: sftp: do not show creation time when we do not know it

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Btrfs definitely does support birthtime INLINE COMMENTS > kio_sftp.cpp:496 > entry.fastInsert(KIO::UDSEntry::UDS_MODIFICATION_TIME, sb->mtime); > -entry.fastInsert(

D27133: kconfig_compiler : generate kconfig settings with subgroup

crossi marked 5 inline comments as done. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27133 To: crossi, ervin, dfaure, #frameworks Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

crossi updated this revision to Diff 77049. crossi added a comment. rename attribute to parentGroupName REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27133?vs=76833&id=77049 REVISION DETAIL https://phabricator.kde.org/D27133 AFFECTED FILES autotests/

D27133: kconfig_compiler : generate kconfig settings with subgroup

crossi planned changes to this revision. crossi added inline comments. INLINE COMMENTS > ervin wrote in test_subgroups.kcfg:10 > Now that I see it, I think I'd go for "parentGroupName" since this is not > referential and really about the name (like the name parameter) `parentGroupName` sounds m

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 57 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/57/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 05 Mar 2020 17:39:57 + Build duration: 3 min 49 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 58 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/58/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 05 Mar 2020 17:39:57 + Build duration: 2 min 52 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 56 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/56/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 05 Mar 2020 17:39:57 + Build duration: 1 min 31 sec and counting JUnit Tests Name:

D9734: [KFileItemActions] Allow specifying the number of selected files required for an action

ngraham closed this revision. ngraham added a comment. Please file a bug report with your concerns. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9734 To: broulik, #frameworks, dfaure, michaelh, mlaurent Cc: ngraham, kde-frameworks-devel, juansimon, LeGast00n, cblac

D27876: KRearrangeColumnsProxyModel: reset in setSourceColumns()

dfaure closed this revision. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D27876 To: dfaure, kossebau, vkrause, davidedmundson, ahiemstra Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27876: KRearrangeColumnsProxyModel: reset in setSourceColumns()

dfaure added a comment. It did indeed... Thanks, fixing. REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D27876 To: dfaure, kossebau, vkrause, davidedmundson, ahiemstra Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27840: Introduce SettingState* elements to ease KCM writing

ervin added a comment. In D27840#622937 , @ngraham wrote: > This patch doesn't apply on top of KDeclarative for me: > > This diff is against commit 3d8757d5dfea2360304e2c8e7d0d575d04b00735, but > the commit is nowhere in the wor

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 57 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/57/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 05 Mar 2020 16:49:42 + Build duration: 1 min 28 sec and counting CONSOLE OUTPUT [...trunca

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 56 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/56/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 05 Mar 2020 16:49:42 + Build duration: 1 min 15 sec and counting CONSOLE OUTPUT [...trunca

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 55 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/55/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 05 Mar 2020 16:49:42 + Build duration: 32 sec and counting CONSOLE OUTPUT [...trunca

D27876: KRearrangeColumnsProxyModel: reset in setSourceColumns()

kossebau added inline comments. INLINE COMMENTS > rearrangecolumns.cpp:37 > +QTimer::singleShot(500, &pm, [&]() { > +pm.setSourceColumns(QVector() << 2 << 1 << 0 << 3); > +}); Thanks :) This one slipped? REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://p

D27876: KRearrangeColumnsProxyModel: reset in setSourceColumns()

dfaure updated this revision to Diff 77047. dfaure added a comment. Use initializer lists REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27876?vs=77044&id=77047 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27876 AFFECTED FILES src

D27840: Introduce SettingState* elements to ease KCM writing

ngraham added a comment. This patch doesn't apply on top of KDeclarative for me: This diff is against commit 3d8757d5dfea2360304e2c8e7d0d575d04b00735, but the commit is nowhere in the working copy. Try to apply it against the current working copy state? (a1282da765c1

D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding

ngraham edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27841 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jra

D27871: sftp: fix seekPos + file resuming when part file is of size 11

bruns added a comment. Can you also mention why errno == EGAIN does not have to be handled ("EAGAIN could only happen iff the file where opened with O_NONBLOCK. All other seek errors are fatal."). REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27871 To: sitter,

D27811: [KConfigGui] Check font weight when clearing styleName property

ervin added a comment. In D27811#622916 , @ahmadsamir wrote: > In D27811#622885 , @ervin wrote: > > > This styleName thing is an endless amount of fun... The patch LGTM, I'll let others weight in th

D27811: [KConfigGui] Check font weight when clearing styleName property

ahmadsamir added a comment. In D27811#622885 , @ervin wrote: > This styleName thing is an endless amount of fun... The patch LGTM, I'll let others weight in though since it can have ramifications I might miss. Well this one is the tip of

D27833: Add an accessor to get the last loaded value for KConfigSkeletonItem

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. In D27833#622353 , @apol wrote: > What's the use-case? Having an idea of the patch you want to build on top of this would indee

D27871: sftp: fix seekPos + file resuming when part file is of size 11

bruns added inline comments. INLINE COMMENTS > kio_sftp.cpp:1687 > if (pos != sbPart->size) { > -qCDebug(KIO_SFTP_LOG) << "Failed to seek to" << > sbPart->size << "bytes in source file. Reason given" << strerror(errno); > +qCDebug(KIO_SFTP

D27876: KRearrangeColumnsProxyModel: reset in setSourceColumns()

kossebau added a comment. Small nitpick: can we have initializer lists for the stringlist and columns in the tests, to promote (IMHO) good C++ code? :) REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D27876 To: dfaure, kossebau, vkrause, davidedm

D27876: KRearrangeColumnsProxyModel: reset in setSourceColumns()

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D27876 To: dfaure, kossebau, vkrause, davidedmundson, ahiemstra Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27876: KRearrangeColumnsProxyModel: reset in setSourceColumns()

dfaure created this revision. dfaure added reviewers: kossebau, vkrause, davidedmundson, ahiemstra. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY Otherwise the view won't update, when doing this dyn

D27811: [KConfigGui] Check font weight when clearing styleName property

ervin added a comment. This styleName thing is an endless amount of fun... The patch LGTM, I'll let others weight in though since it can have ramifications I might miss. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27811 To: ahmadsamir, #frameworks, dfaure, david

D27463: KconfigXT: Add a value attribute to Enum field choices

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcoreconfigskeleton.cpp:581 > +// HACK for BC concerns > +// TODO KF6: remove KCoreConfigSkeletonPrivate::mValues and add a value > field to KCoreConfig

D27811: [KConfigGui] Check font weight when clearing styleName property

ervin added a reviewer: bport. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27811 To: ahmadsamir, #frameworks, dfaure, davidedmundson, cfeck, ervin, meven, bport Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

sitter added a comment. It's doable in cmake but it'd be awkward and needlessly complex I think, you are much better served putting the actual processing into a script. ki18n's cmake/ macros have function with very similar tech. In fact, KI18N_INSTALL probably is super close in the funct

D27873: sftp: do not show creation time when we do not know it

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH sftp-ctime REVISION DETAIL https://phabricator.kde.org/D27873 To: sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe

D23465: Add new non standard mime type for ROOT cern files

alexde abandoned this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23465 To: alexde, #vdg Cc: yurchor, ltoscano, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

ahmadsamir added a comment. FTR, gwenview should be fixed by D27875 . REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27865 To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27533: Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

kossebau retitled this revision from "[Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks" to "Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks". kossebau edited the summary of this revision. REPOSITORY R39 KTextEditor BRANCH addmarkinterfacev2 REVISION DETAIL h

D27533: [Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

kossebau added a comment. Having thought some more about the KDevelop cases, their pixmap preprocessing really should be replaced by proper custom icons, so the currently proposed MarkInterfaceV2 should be fine also for KDevelop. Thus going to land this post 5.68 tagging then as is. Thanks

D27533: [Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

kossebau updated this revision to Diff 77041. kossebau added a comment. Do proper static_cast into QMetaType enum REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27533?vs=76127&id=77041 BRANCH addmarkinterfacev2 REVISION DETAIL https://phabricator.k

D27533: [Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

kossebau retitled this revision from "[WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks" to "[Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks". REPOSITORY R39 KTextEditor BRANCH addmarkinterfacev2 REVISION DETAIL https://phabricator.kde.org/D27533 To: k

D27802: smb: fix ipv6 support

sitter added a comment. Ah sorry for the unnecessary wait. I wasn't planning on 19.12. Thanks for asking though :) REPOSITORY R320 KIO Extras BRANCH smb-smburl-static-autotest-ipv6 REVISION DETAIL https://phabricator.kde.org/D27802 To: sitter, ngraham Cc: cfeck, thiago, kde-framework

D27873: sftp: do not show creation time when we do not know it

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY creation time (aka birth time) is file system dependent, if the fs doe

D27133: kconfig_compiler : generate kconfig settings with subgroup

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kconfigcompiler_test.cpp:80 > "test_signal", > +"test_notifiers", > "test_translation_kde", This seems unrelated... So we had this test case avail

D27872: sftp: fix partial transfer resuming when copying to local

sitter created this revision. sitter added reviewers: ngraham, feverfew. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the previous condition checked if the final target path size

D27871: sftp: fix seekPos + file resuming when part file is of size 11

sitter created this revision. sitter added reviewers: ngraham, feverfew. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY previously seekPos would loop over offset==EAGAIN. the return

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

ahmadsamir updated this revision to Diff 77032. ahmadsamir added a comment. Remove redundant #include REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27865?vs=77031&id=77032 BRANCH l-kfilefiltercombo (branched from master) REVISION DETAIL https://phabricat

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

ahmadsamir updated this revision to Diff 77031. ahmadsamir added a comment. Fix _debug.h file name REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27865?vs=77029&id=77031 BRANCH l-kfilefiltercombo (branched from master) REVISION DETAIL https://phabricator.

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

kossebau added inline comments. INLINE COMMENTS > CMakeLists.txt:57 > +ecm_qt_declare_logging_category(kiofilewidgets_SRCS > +HEADER kiofilewidgets_debug.h > +IDENTIFIER KIO_KFILEWIDGETS_KFILEFILTERCOMBO Perhaps name the header matching kfilefiltercombo, to make clear this one is not pr

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

ahmadsamir updated this revision to Diff 77029. ahmadsamir retitled this revision from "[KFileFilterCombo] Don't add inavlid QMimeType to mime filter" to "[KFileFilterCombo] Don't add invalid QMimeType to mimes filter". ahmadsamir removed a reviewer: kossebau. ahmadsamir removed a subscriber: kos

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

kossebau added a comment. BTW, typo in title of commit ("inadlid"). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27865 To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik, kossebau Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in kfilefiltercombo.cpp:31 > Err why don't you include kiofilewidgets_debug.h instead? > > You're redefining what the generated file contains, here. No, the generated one contains only `kf5.kio.filewidgets`, not `kf5.kio.filewidget

D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

This revision was automatically updated to reflect the committed changes. Closed by commit R268:8e14750977c6: Fix "Make it compile against last qt5.15 without deprecated method. QProcess… (authored by fvogt). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfilefiltercombo.cpp:31 > +Q_DECLARE_LOGGING_CATEGORY(KIO_KFILEWIDGETS_KFILEFILTERCOMBO) > +Q_LOGGING_CATEGORY(KIO_KFILEWIDGETS_KFILEFILTERCOMBO, > "kf5.kio.f

D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R268 KGlobalAccel BRANCH somefix REVISION DETAIL https://phabricator.kde.org/D27863 To: fvogt, #frameworks, mlaurent Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngrah

D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

fvogt marked an inline comment as done. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D27863 To: fvogt, #frameworks, mlaurent Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

fvogt edited the test plan for this revision. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D27863 To: fvogt, #frameworks, mlaurent Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

fvogt updated this revision to Diff 77022. fvogt added a comment. Do it differently, just like it's done below REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27863?vs=77009&id=77022 BRANCH somefix REVISION DETAIL https://phabricator.kde.org/D2786

D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

fvogt retitled this revision from "Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"" to "Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"". REPOSITORY R268 KGlobalAccel

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

fvogt added a comment. In D27863#622655 , @mlaurent wrote: > if splitting is already done why this code re-call "m_desktopFile.desktopGroup().readEntry(QStringLiteral("Exec"), QString())" ? > => QProcess::startDetached(commands, parts) no ?

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

mlaurent added a comment. if splitting is already done why this code re-call "m_desktopFile.desktopGroup().readEntry(QStringLiteral("Exec"), QString())" ? > QProcess::startDetached(commands, parts) no ? === REPOSITORY R268 KGlobalAccel REV

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

kossebau added a comment. Looks good from a quick scan. If the content of the generated kio.categories files also matches what you expect, things are fine. Perhaps I would invert things and generate the header for kf5.kio.filewidgets.kfilefiltercombo and include that, instead of the manual d

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

ahmadsamir added a reviewer: kossebau. ahmadsamir added a subscriber: kossebau. ahmadsamir added a comment. @kossebau: did I get the Qt logging bits correctly? (I copied from your other related commits :)). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27865 To: ahmad

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

ahmadsamir updated this revision to Diff 77015. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Give a warning about invalid mimeTypes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27865?vs=77012&id=77015 BRANCH l-kfilefiltercomb

Problems in KWayland causes by API and ABI compatibility promises

Hi, KWayland is a library that provides convenience wrappers for Wayland protocols. Usually, when we want to implement some Wayland protocol, first, we add corresponding wrappers in KWayland and after that we actually implement the protocol in KWin. Unfortunately, we made a bad design choice

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

fvogt added a comment. The split arguments are already available as `parts` above, as used in the klauncher call AFAICT. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D27863 To: fvogt, #frameworks, mlaurent Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cbla

D9734: [KFileItemActions] Allow specifying the number of selected files required for an action

juansimon reopened this revision. juansimon added a comment. This revision is now accepted and ready to land. Herald added a subscriber: kde-frameworks-devel. Operating System: Arch Linux KDE Plasma Version: 5.18.2 KDE Frameworks Version: 5.67.0 Qt Version: 5.14.1 Besides th

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 324 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/324/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 05 Mar 2020 12:00:21 + Build duration: 12 min and counting BUILD ARTIFACTS acc/KF5KIO-5.68.0.xmllog

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

ahmadsamir added a comment. Looking at upstream code, it looks like they introduced a static splitCommad() method since 5.15, so I think we'll have to use a #if QT_VERSION < QT_VERSION_CHECK(5, 15, 0) kludge to handle this case. Their rationale is more precise argument handling, which

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 315 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/315/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 05 Mar 2020 12:00:21 + Build duration: 9 min 44 sec and counting JUnit Tests Name: projectro

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 449 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/449/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 05 Mar 2020 12:00:21 + Build duration: 5 min 44 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.68.0.

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

ahmadsamir added a comment. In D27865#622605 , @dfaure wrote: > Maybe add a warning about the invalid type? After all it's a programmer error to send us invalid mimetypes here, right? Are you also fixing the source of the issue in gwenview?

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

mlaurent added inline comments. INLINE COMMENTS > kserviceactioncomponent.cpp:72 > } else { > - > QProcess::startDetached(m_desktopFile.desktopGroup().readEntry(QStringLiteral("Exec"), > QString()), QStringList()); > + > QProcess::startDetached(m_desktopFile.desk

D27864: KIO::iconNameForUrl(): handle the case of a file/folder under trash:/

This revision was automatically updated to reflect the committed changes. Closed by commit R241:082e01b19a8e: KIO::iconNameForUrl(): handle the case of a file/folder under trash:/ (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27864?vs=77

D27838: Port to new QML Connections syntax

davidedmundson added a comment. Relevant temporary "fix": https://codereview.qt-project.org/c/qt/qtdeclarative/+/293011 REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D27838 To: jbbgameich, #frameworks, apol Cc: davidedmundson, apol, plasm

D27864: KIO::iconNameForUrl(): handle the case of a file/folder under trash:/

meven accepted this revision. REPOSITORY R241 KIO BRANCH l-trash-stuff (branched from master) REVISION DETAIL https://phabricator.kde.org/D27864 To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

dfaure added a comment. Maybe add a warning about the invalid type? After all it's a programmer error to send us invalid mimetypes here, right? Are you also fixing the source of the issue in gwenview? Thanks! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27865 T

D27864: KIO::iconNameForUrl(): handle the case of a file/folder under trash:/

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Yay for unittests :-) REPOSITORY R241 KIO BRANCH l-trash-stuff (branched from master) REVISION DETAIL https://phabricator.kde.org/D27864 To: ahmadsamir, #frameworks, dfaure, meven,

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven, sitter, broulik. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY When setting the mime filter, check that the QMimeType we get from QMimeDatabase::mimeTyp

D27864: KIO::iconNameForUrl(): handle the case of a file/folder under trash:/

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven, sitter, broulik. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY For trash:/ we have two individual cases: - trash:/ itself, show empty/full trash icon

D27544: Fix update scenarios with no explicit downloadlink selected

alexde added a comment. In D27544#622272 , @ngraham wrote: > (...) there has to be a way to (...) label everything properly etc. In D27544#622501 , @leinir wrote: > We are at least two

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

fvogt added a reviewer: mlaurent. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D27863 To: fvogt, #frameworks, mlaurent Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

fvogt created this revision. fvogt added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY This port is broken AFAICT - it tries to run the full Exec= line as binary, without s

D27463: KconfigXT: Add a value attribute to Enum field choices

meven marked 4 inline comments as done. meven added inline comments. INLINE COMMENTS > ervin wrote in kcoreconfigskeleton.cpp:580 > No I meant the comment needs to be adjusted due to the changes (fields > changing place and such) sorry if I was unclear. I updated the comment since your first co

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 77006. meven added a comment. Fix typo REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=76999&id=77006 BRANCH arcpatch-D27463_2 REVISION DETAIL https://phabricator.kde.org/D27463 AFFECTED FILES autotests/k

D27463: KconfigXT: Add a value attribute to Enum field choices

ervin added inline comments. INLINE COMMENTS > meven wrote in kcoreconfigskeleton.cpp:580 > You mean I should prepare this and put it in KF6 waiting for merge queue ? No I meant the comment needs to be adjusted due to the changes (fields changing place and such) sorry if I was unclear. > meven

D27802: smb: fix ipv6 support

cfeck added a comment. Well, cannot delay the release any longer. REPOSITORY R320 KIO Extras BRANCH smb-smburl-static-autotest-ipv6 REVISION DETAIL https://phabricator.kde.org/D27802 To: sitter, ngraham Cc: cfeck, thiago, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice,

D27463: KconfigXT: Add a value attribute to Enum field choices

meven added inline comments. INLINE COMMENTS > ervin wrote in kcoreconfigskeleton.cpp:580 > Will need an update You mean I should prepare this and put it in KF6 waiting for merge queue ? > ervin wrote in kcoreconfigskeleton.h:788 > const QString &name > > Probably worth adding a KF6 comment so

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 76999. meven marked 9 inline comments as done. meven added a comment. Remove enumValues, const ref args, move mValues to KCoreConfigSkeletonItemPrivate, improve comments REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D274

D27544: Fix update scenarios with no explicit downloadlink selected

leinir added a comment. In D27544#622272 , @ngraham wrote: > As an aside, I'm somewhat dissatisfied with the current UX when there are multiple files. :( I converted a friend of mine to Plasma the other day and he was very confused by the multip

D27463: KconfigXT: Add a value attribute to Enum field choices

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcoreconfigskeleton.cpp:580 > +{ > +// TODO KF6 move value to ItemEnum::Choice and remove > KCoreConfigSkeleton::ItemEnum::mValues > +const auto inHash

D27859: [server] Expose SurfaceRole class

zzag added a dependent revision: D27860: [server] Add some sub-surface life cycle signals. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27859 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27828: [server] Introduce SurfaceInterface::boundingRect()

zzag added a dependent revision: D27859: [server] Expose SurfaceRole class. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27828 To: zzag, #kwin, davidedmundson Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27860: [server] Add some sub-surface life cycle signals

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY These signals can be very useful when one wants to monitor changes in a sub-surface tree. REPO

D27860: [server] Add some sub-surface life cycle signals

zzag added a dependency: D27859: [server] Expose SurfaceRole class. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27860 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27859: [server] Expose SurfaceRole class

zzag added a dependency: D27828: [server] Introduce SurfaceInterface::boundingRect(). REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27859 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27777: Fix clicking thumb-only delegate

This revision was automatically updated to reflect the committed changes. Closed by commit R304:b9a1dd14800b: Fix clicking thumb-only delegate (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=76754&id=76997 REVISION DETAIL htt

D27859: [server] Expose SurfaceRole class

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY This can be useful for implementing out-of-tree shell surface protocols. REPOSITORY R127 KWayl

D26342: Allow overriding to disable auto language detection

sdepiets updated this revision to Diff 76992. sdepiets added a comment. Disable autodetect on language change REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26342?vs=74851&id=76992 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26342 AFFEC